Skip to contentSkip to conversation

quagga: fix build breakage without snmp

PATCH New Gustavo Zacarias 2 participants 2 messages Apr 18, 2013 – Apr 21, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 quagga: fix build breakage without snmp

Quagga no longer supports explicitly disabling snmp, and what's worse, it interprets --disable-snmp as --enable-snmp.
Remove the disable configure option.
While at it add a comment about net-snmp requiring AgentX support for quagga to build properly as suggested by Arnout.
Fixes:
http://autobuild.buildroot.net/results/a9bce6dd8065ddb1850a4e14f0e4eb257ee89286/

---
 package/quagga/Config.in | 3 +++
 package/quagga/quagga.mk | 4 +---
 2 files changed, 4 insertions(+), 3 deletions(-)
package/quagga/Config.in +3 -0
index 0834201..c364ae1 100644
@@ -84,4 +84,7 @@ config BR2_PACKAGE_QUAGGA_SNMP
 	help
 	  Make quagga information available via SNMP SMUX.
 
+comment "AgentX support must be enabled in net-snmp or the build will break"
+	depends on BR2_PACKAGE_QUAGGA_SNMP
+
 endif
package/quagga/quagga.mk +1 -3
index 42f8506..347ec4d 100644
@@ -26,10 +26,8 @@ QUAGGA_CONF_OPT += $(if $(BR2_PACKAGE_QUAGGA_OPAQUE_LSA),--enable-opaque-lsa,--d
 
 ifeq ($(BR2_PACKAGE_QUAGGA_SNMP),y)
 QUAGGA_CONF_ENV += ac_cv_path_NETSNMP_CONFIG=$(STAGING_DIR)/usr/bin/net-snmp-config
-QUAGGA_CONF_OPT += --enable-snmp
+QUAGGA_CONF_OPT += --enable-snmp=agentx
 QUAGGA_DEPENDENCIES += netsnmp
-else
-QUAGGA_CONF_OPT +=--disable-snmp
 endif
 
 $(eval $(autotools-package))
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 quagga: fix build breakage without snmp

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Gustavo> Quagga no longer supports explicitly disabling snmp, and what's worse, Gustavo> it interprets --disable-snmp as --enable-snmp.
Gustavo> Remove the disable configure option.
Gustavo> While at it add a comment about net-snmp requiring AgentX support for Gustavo> quagga to build properly as suggested by Arnout.
Gustavo> Fixes:
Gustavo> http://autobuild.buildroot.net/results/a9bce6dd8065ddb1850a4e14f0e4eb257ee89286/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard