Skip to contentSkip to conversation

kernel/nsproxy.c: Improving a snippet of code.

PATCH In review Raphael S.Carvalho 3 participants 3 messages Feb 27, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/nsproxy.c: Improving a snippet of code.

It seems GCC generates a better code in that way, so I changed that statement. Btw, they have the same semantic, so I'm sending this patch due to performance issues.

---
 kernel/nsproxy.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/nsproxy.c +2 -1
index 78e2ecb..21da3d1 100644
@@ -148,7 +148,8 @@ int copy_namespaces(unsigned long flags, struct task_struct *tsk)
 	 * means share undolist with parent, so we must forbid using
 	 * it along with CLONE_NEWIPC.
 	 */
-	if ((flags & CLONE_NEWIPC) && (flags & CLONE_SYSVSEM)) {
+	if ((flags & (CLONE_NEWIPC | CLONE_SYSVSEM)) ==
+		(CLONE_NEWIPC | CLONE_SYSVSEM)) {
 		err = -EINVAL;
 		goto out;
 	}
Signature · 1 line
1.7.2.5
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Raphael S.Carvalho

It seems GCC generates a better code in that way, so I changed that statement. Btw, they have the same semantic, so I'm sending this patch due to performance issues.

Quoted 21 lines
---
 kernel/nsproxy.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/nsproxy.c +2 -1
index 78e2ecb..21da3d1 100644
@@ -148,7 +148,8 @@ int copy_namespaces(unsigned long flags, struct task_struct *tsk)
 	 * means share undolist with parent, so we must forbid using
 	 * it along with CLONE_NEWIPC.
 	 */
-	if ((flags & CLONE_NEWIPC) && (flags & CLONE_SYSVSEM)) {
+	if ((flags & (CLONE_NEWIPC | CLONE_SYSVSEM)) ==
+		(CLONE_NEWIPC | CLONE_SYSVSEM)) {
 		err = -EINVAL;
 		goto out;
 	}
Signature · 1 line
1.7.2.5