ext4: do not get s_umount sem on ext4_quota_off
PATCH 1/1 ext4: do not get s_umount sem on ext4_quota_off
It must be already acquired by caller. Fix lock_dep complain.
Signed-off-by Dmitry Monakhov <[email protected]>
Reviewed-by Jan Kara <[email protected]>
fs/ext4/super.c +3 -5
@@ -4107,12 +4107,10 @@ static int ext4_quota_on(struct super_block *sb, int type, int format_id,static int ext4_quota_off (struct super_block *sb,int type) { -/* Force all delayed allocation blocks to be allocated */ -if (test_opt (sb,DELALLOC )) { -down_read (&sb->s_umount); +/* Force all delayed allocation blocks to be allocated. +* Caller already holds s_umount sem */ +if (test_opt (sb,DELALLOC ))sync_filesystem (sb); -up_read (&sb->s_umount); - }return dquot_quota_off (sb, type); }
Ted Ts'o
maintainerQuoted 5 lines · Dmitry Monakhov
It must be already acquired by caller. Fix
lock_depcomplain.Signed-off-by Dmitry Monakhov <[email protected]>Reviewed-by Jan Kara <[email protected]>
Added to the patch queue, thanks.
- Ted