Skip to contentSkip to conversation

pxamci: fix printing gpio numbers in pxamci_probe

PATCH New Antonio Ospite 3 participants 5 messages Oct 2, 2009 – Oct 8, 2009 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pxamci: fix printing gpio numbers in pxamci_probe

---
 drivers/mmc/host/pxamci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/pxamci.c +2 -2
index 5e0b152..b00d673 100644
@@ -693,7 +693,7 @@ static int pxamci_probe(struct platform_device *pdev)
 	if (gpio_is_valid(gpio_ro)) {
 		ret = gpio_request(gpio_ro, "mmc card read only");
 		if (ret) {
-			dev_err(&pdev->dev, "Failed requesting gpio_ro %d\n", gpio_power);
+			dev_err(&pdev->dev, "Failed requesting gpio_ro %d\n", gpio_ro);
 			goto err_gpio_ro;
 		}
 		gpio_direction_input(gpio_ro);
@@ -701,7 +701,7 @@ static int pxamci_probe(struct platform_device *pdev)
 	if (gpio_is_valid(gpio_cd)) {
 		ret = gpio_request(gpio_cd, "mmc card detect");
 		if (ret) {
-			dev_err(&pdev->dev, "Failed requesting gpio_cd %d\n", gpio_power);
+			dev_err(&pdev->dev, "Failed requesting gpio_cd %d\n", gpio_cd);
 			goto err_gpio_cd;
 		}
 		gpio_direction_input(gpio_cd);
Signature · 1 line
1.6.4.3
#1 lore raw

PATCH 1/1 pxamci: fix printing gpio numbers in pxamci_probe

Quoted 30 lines · On Fri, 2 Oct 2009 16:24:02 +0200 Antonio Ospite <[email protected]>…
---
 drivers/mmc/host/pxamci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/pxamci.c +2 -2
index 5e0b152..b00d673 100644
@@ -693,7 +693,7 @@ static int pxamci_probe(struct platform_device *pdev)
 	if (gpio_is_valid(gpio_ro)) {
 		ret = gpio_request(gpio_ro, "mmc card read only");
 		if (ret) {
-			dev_err(&pdev->dev, "Failed requesting gpio_ro %d\n", gpio_power);
+			dev_err(&pdev->dev, "Failed requesting gpio_ro %d\n", gpio_ro);
 			goto err_gpio_ro;
 		}
 		gpio_direction_input(gpio_ro);
@@ -701,7 +701,7 @@ static int pxamci_probe(struct platform_device *pdev)
 	if (gpio_is_valid(gpio_cd)) {
 		ret = gpio_request(gpio_cd, "mmc card detect");
 		if (ret) {
-			dev_err(&pdev->dev, "Failed requesting gpio_cd %d\n", gpio_power);
+			dev_err(&pdev->dev, "Failed requesting gpio_cd %d\n", gpio_cd);
 			goto err_gpio_cd;
 		}
 		gpio_direction_input(gpio_cd);
Signature · 1 line
1.6.4.3

Ping.

Thanks,
Antonio

Signature · 17 lines
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20091005/cadc7a03/attachment.sig>
Applied
#3 lore raw

PATCH 1/1 pxamci: fix printing gpio numbers in pxamci_probe

Quoted 5 lines · Robert Jarzmik
Quoted 3 lines · Antonio Ospite

On Fri, ?2 Oct 2009 16:24:02 +0200
Antonio Ospite <[email protected]> wrote:

Quoted 8 lines
Quoted 1 line
Quoted 1 line

As this fixes code I wrote poorly, feel free to have my :

Eric, I think this can be scheduled without any problem into your linux-next branch.

Applied to 'fix'.

#4 lore raw

PATCH 1/1 pxamci: fix printing gpio numbers in pxamci_probe

Quoted 8 lines · On Thu, 8 Oct 2009 21:21:48 +0800 Eric Miao <[email protected]> wrote:
Quoted 7 lines · Robert Jarzmik
Quoted 4 lines · Antonio Ospite
Quoted 1 line · On Fri, ?2 Oct 2009 16:24:02 +0200 Antonio Ospite <[email protected]>…
Quoted 8 lines
Quoted 6 lines

As this fixes code I wrote poorly, feel free to have my :

Eric, I think this can be scheduled without any problem into your linux-next branch.

Applied to 'fix'.

Thanks,
Antonio

Signature · 17 lines
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20091008/d6ba79f0/attachment-0001.sig>