net/smc911x: Match up spin lock/unlock
Subsystems (2)
PATCH 1/1 net/smc911x: Match up spin lock/unlock
smc911x_phy_configure's error handling unconditionally unlocks the spinlock even if it wasn't locked. Patch fixes it.
Signed-off-by Peter Korsgaard <[email protected]>
--- drivers/net/smc911x.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/smc911x.c +3 -2
@@ -969,11 +969,11 @@* We should not be called if phy_type is zero. */ if (lp->phy_type ==0 ) - goto smc911x_phy_configure_exit; + goto smc911x_phy_configure_exit_nolock;if (smc911x_phy_reset (dev, phyaddr)) {printk ("%s: PHY reset timed out\n" , dev->name); - goto smc911x_phy_configure_exit; + goto smc911x_phy_configure_exit_nolock; }spin_lock_irqsave (&lp->lock, flags);
@@ -1042,6 +1042,7 @@ smc911x_phy_configure_exit:spin_unlock_irqrestore (&lp->lock, flags); +smc911x_phy_configure_exit_nolock: lp->work_pending =0 ; }
Signature · 1 line
Bye, Peter Korsgaard