Skip to contentSkip to conversation

git-tag: add flag to verify a tag

PATCH In review Santi Béjar 2 participants 4 messages Jun 15, 2016 Documentation

lore
Share & tools
lore

Santi Béjar

author
#0 lore raw

PATCH 1/1 git-tag: add flag to verify a tag

This way "git tag -v $tag" is the UI for git-verify-tag.

---
 Documentation/git-tag.txt |    7 ++++++-
 generate-cmdlist.sh       |    1 -
 git-tag.sh                |   10 +++++++++-
 3 files changed, 15 insertions(+), 3 deletions(-)
Documentation/git-tag.txt +6 -1
index 48b82b8..80bece0 100644
@@ -9,7 +9,7 @@ git-tag - Create a tag object signed with GPG
 SYNOPSIS
 --------
 [verse]
-'git-tag' [-a | -s | -u <key-id>] [-f | -d] [-m <msg> | -F <file>]
+'git-tag' [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>]
 	 <name> [<head>]
 'git-tag' -l [<pattern>]
 

@@ -35,6 +35,8 @@ GnuPG key for signing.
 
 `-d <tag>` deletes the tag.
 
+`-v <tag>` verifies the gpg signature of the tag.
+
 `-l <pattern>` lists tags that match the given pattern (or all
 if no pattern is given).
 

@@ -55,6 +57,9 @@ OPTIONS
 -d::
 	Delete an existing tag with the given name
 
+-v::
+	Verify the gpg signature of given the tag
+
 -l <pattern>::
 	List tags that match the given pattern (or all if no pattern is given).
generate-cmdlist.sh +0 -1
index 06c42b0..1de14ea 100755
@@ -37,7 +37,6 @@ show
 show-branch
 status
 tag
-verify-tag
 EOF
 while read cmd
 do
git-tag.sh +9 -1
index e1bfa82..c9e1180 100755
@@ -1,7 +1,7 @@
 #!/bin/sh
 # Copyright (c) 2005 Linus Torvalds
 
-USAGE='-l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d] [-m <msg>] <tagname> [<head>]'
+USAGE='-l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg>] <tagname> [<head>]'
 SUBDIRECTORY_OK='Yes'
 . git-sh-setup
 

@@ -12,6 +12,7 @@ force=
 message=
 username=
 list=
+verify=
 while case "$#" in 0) break ;; esac
 do
     case "$1" in

@@ -69,6 +70,13 @@ do
 		echo "Deleted tag $tag_name."
 	exit $?
 	;;
+    -v)
+	shift
+	tag_name="$1"
+	tag=$(git-show-ref --verify --hash -- "refs/tags/$tag_name") ||
+		die "Seriously, what tag are you talking about?"
+	git-verify-tag -v "$tag"
+	exit $?
     -*)
         usage
 	;;
Signature · 1 line
1.5.0.rc0.g91ea
#1 lore raw
Quoted 4 lines · Santi Béjar

This way "git tag -v $tag" is the UI for git-verify-tag.

---
 Documentation/git-tag.txt |    7 ++++++-

...

Signoffs?

author
#2 lore raw
Quoted 9 lines · Junio C Hamano
Quoted 4 lines · Santi Béjar

This way "git tag -v $tag" is the UI for git-verify-tag.

---
 Documentation/git-tag.txt |    7 ++++++-

...

Signoffs?

Forgotten, long time since the last patch :-|

Signed-off-by Santi Béjar <[email protected]>

Santi

author
#3 lore raw

PATCH 1/1 git-tag: add flag to verify a tag

In reply to Santi Béjar

This way "git tag -v $tag" is the UI for git-verify-tag.

Signed-off-by Santi Béjar <[email protected]>

---
Hi *,

But maybe the -v flag should give a similar output as:

 $ git branch -v

Then this flag could be -c for check?

This version has a syntax fix (sorry) and a typo fix.

 Documentation/git-tag.txt |    7 ++++++-
 generate-cmdlist.sh       |    1 -
 git-tag.sh                |   11 ++++++++++-
 3 files changed, 16 insertions(+), 3 deletions(-)
Documentation/git-tag.txt +6 -1
index 48b82b8..5cf114d 100644
@@ -9,7 +9,7 @@ git-tag - Create a tag object signed with GPG
 SYNOPSIS
 --------
 [verse]
-'git-tag' [-a | -s | -u <key-id>] [-f | -d] [-m <msg> | -F <file>]
+'git-tag' [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>]
 	 <name> [<head>]
 'git-tag' -l [<pattern>]
 

@@ -35,6 +35,8 @@ GnuPG key for signing.
 
 `-d <tag>` deletes the tag.
 
+`-v <tag>` verifies the gpg signature of the tag.
+
 `-l <pattern>` lists tags that match the given pattern (or all
 if no pattern is given).
 

@@ -55,6 +57,9 @@ OPTIONS
 -d::
 	Delete an existing tag with the given name
 
+-v::
+	Verify the gpg signature of the given tag
+
 -l <pattern>::
 	List tags that match the given pattern (or all if no pattern is given).
generate-cmdlist.sh +0 -1
index 06c42b0..1de14ea 100755
@@ -37,7 +37,6 @@ show
 show-branch
 status
 tag
-verify-tag
 EOF
 while read cmd
 do
git-tag.sh +9 -1
index e1bfa82..c3e4e15 100755
@@ -1,7 +1,7 @@
 #!/bin/sh
 # Copyright (c) 2005 Linus Torvalds
 
-USAGE='-l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d] [-m <msg>] <tagname> [<head>]'
+USAGE='-l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg>] <tagname> [<head>]'
 SUBDIRECTORY_OK='Yes'
 . git-sh-setup
 

@@ -69,6 +69,14 @@ do
 		echo "Deleted tag $tag_name."
 	exit $?
 	;;
+    -v)
+	shift
+	tag_name="$1"
+	tag=$(git-show-ref --verify --hash -- "refs/tags/$tag_name") ||
+		die "Seriously, what tag are you talking about?"
+	git-verify-tag -v "$tag"
+	exit $?
+	;;
     -*)
         usage
 	;;
Signature · 1 line
1.5.0.rc0.g1eb3