Skip to contentSkip to conversation

drm/i915/dp: Guarantee a minimum HBlank time

PATCH Superseded Arun R Murthy 4 participants 5 messages Jan 3, 2025

Subsystems (3)

v5 of 9 Superseded Latest is v9 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 drm/i915/dp: Guarantee a minimum HBlank time

Mandate a minimum Hblank symbol cycle count between BS and BE in 8b/10b MST and 128b/132b mode.
Spec: DP2.1a

v2: Affine calculation/updation of min HBlank to dp_mst (Jani)
v3: moved min_hblank from struct intel_dp to intel_crtc_state (Jani)
v4: use max/min functions, change intel_xx *intel_xx to intel_xx *xx
(Jani)
Limit hblank to 511 and accommodate BS/BE in calculated value (Srikanth)
v5: Some spelling corrections (Suraj)

---
 .../gpu/drm/i915/display/intel_crtc_state_dump.c   |  1 +
 drivers/gpu/drm/i915/display/intel_display_types.h |  1 +
 drivers/gpu/drm/i915/display/intel_dp_mst.c        | 35 ++++++++++++++++++++++
 drivers/gpu/drm/i915/i915_reg.h                    |  4 +++
 4 files changed, 41 insertions(+)
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +1 -0
index 1faef60be4728cd80a0a6b0151797ceda5c443ce..0e7e0b7803d9865177d6f68e8afdef94a91d9697 100644
@@ -248,6 +248,7 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config,
 			   str_enabled_disabled(pipe_config->has_sel_update),
 			   str_enabled_disabled(pipe_config->has_panel_replay),
 			   str_enabled_disabled(pipe_config->enable_psr2_sel_fetch));
+		drm_printf(&p, "minimum HBlank: %d\n", pipe_config->min_hblank);
 	}
 
 	drm_printf(&p, "framestart delay: %d, MSA timing delay: %d\n",
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
index eb9dd1125a4a09511936b81219e7f38fae106dfd..7d3a7700c44ef200d811d9e90ea465c06104287e 100644
@@ -1095,6 +1095,7 @@ struct intel_crtc_state {
 
 	int max_link_bpp_x16;	/* in 1/16 bpp units */
 	int pipe_bpp;		/* in 1 bpp units */
+	int min_hblank;		/* min HBlank for DP2.1 */
 	struct intel_link_m_n dp_m_n;
 
 	/* m2_n2 for eDP downclock */
drivers/gpu/drm/i915/display/intel_dp_mst.c +35 -0
index fffd199999e02eb66ea478ff872f72b277bd3970..bd561c08d945fcafa65af9254a71cd66f17923d2 100644
@@ -211,6 +211,35 @@ static int intel_dp_mst_dsc_get_slice_count(const struct intel_connector *connec
 					    num_joined_pipes);
 }
 
+static void intel_dp_mst_compute_min_hblank(struct intel_crtc_state *crtc_state,
+					    struct intel_connector *connector,
+					    int bpp_x16)
+{
+	struct intel_encoder *encoder = connector->encoder;
+	struct intel_display *display = to_intel_display(encoder);
+	const struct drm_display_mode *adjusted_mode =
+					&crtc_state->hw.adjusted_mode;
+	int symbol_size = intel_dp_is_uhbr(crtc_state) ? 32 : 8;
+	int hblank;
+
+	if (DISPLAY_VER(display) < 20)
+		return;
+
+	/* Calculate min Hblank Link Layer Symbol Cycle Count for 8b/10b MST & 128b/132b */
+	hblank = DIV_ROUND_UP((DIV_ROUND_UP(adjusted_mode->htotal - adjusted_mode->hdisplay, 4) * bpp_x16), symbol_size);
+
+	/* bit 8:0 minimum hblank symbol cylce count, i.e maximum value would be 511 */
+	hblank = min(511, hblank);
+
+	/* Software needs to adjust the BS/BE framing control from the calculated value */
+	hblank = hblank - 2;
+
+	if (intel_dp_is_uhbr(crtc_state))
+		crtc_state->min_hblank = max(hblank, 5);
+	else
+		crtc_state->min_hblank = max(hblank, 3);
+}
+
 static int mst_stream_find_vcpi_slots_for_bpp(struct intel_dp *intel_dp,
 					      struct intel_crtc_state *crtc_state,
 					      int max_bpp, int min_bpp,
@@ -284,6 +313,8 @@ static int mst_stream_find_vcpi_slots_for_bpp(struct intel_dp *intel_dp,
 		remote_bw_overhead = intel_dp_mst_bw_overhead(crtc_state, connector,
 							      true, dsc_slice_count, link_bpp_x16);
 
+		intel_dp_mst_compute_min_hblank(crtc_state, connector, link_bpp_x16);
+
 		intel_dp_mst_compute_m_n(crtc_state, connector,
 					 local_bw_overhead,
 					 link_bpp_x16,
@@ -1267,6 +1298,10 @@ static void mst_stream_enable(struct intel_atomic_state *state,
 			       TRANS_DP2_VFREQ_PIXEL_CLOCK(crtc_clock_hz & 0xffffff));
 	}
 
+	if (DISPLAY_VER(display) >= 20)
+		intel_de_write(display, DP_MIN_HBLANK_CTL(trans),
+			       pipe_config->min_hblank);
+
 	enable_bs_jitter_was(pipe_config);
 
 	intel_ddi_enable_transcoder_func(encoder, pipe_config);
drivers/gpu/drm/i915/i915_reg.h +4 -0
index 765e6c0528fb0b5a894395b77a5edbf0b0c80009..7bd783931199e2e5c7e15358bb4d2c904f28176a 100644
@@ -3197,6 +3197,10 @@
 #define _TRANS_DP2_VFREQLOW_D			0x630a8
 #define TRANS_DP2_VFREQLOW(trans)		_MMIO_TRANS(trans, _TRANS_DP2_VFREQLOW_A, _TRANS_DP2_VFREQLOW_B)
 
+#define _DP_MIN_HBLANK_CTL_A			0x600ac
+#define _DP_MIN_HBLANK_CTL_B			0x610ac
+#define DP_MIN_HBLANK_CTL(trans)		_MMIO_TRANS(trans, _DP_MIN_HBLANK_CTL_A, _DP_MIN_HBLANK_CTL_B)
+
 /* SNB eDP training params */
 /* SNB A-stepping */
 #define  EDP_LINK_TRAIN_400MV_0DB_SNB_A		(0x38 << 22)

---
base-commit: 048d83e7f9dae81c058d31c371634c1c317b3013
change-id: 20250103-hblank-cd7e78cbe178

Best regards,

Signature · 1 line
Arun R Murthy <[email protected]>
Reviewed-by on v5 1/1
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Arun R Murthy
Sent: Friday, January 3, 2025 10:43 AM
To: [email protected]; [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH v5] drm/i915/dp: Guarantee a minimum HBlank time

Quoted 3 lines

Mandate a minimum Hblank symbol cycle count between BS and BE in 8b/10b MST and 128b/132b mode.
Spec: DP2.1a

The spec is mentioned usually right before the Signed-off-by Spec:
Signed-off-by

Quoted 46 lines

v2: Affine calculation/updation of min HBlank to dp_mst (Jani)
v3: moved min_hblank from struct intel_dp to intel_crtc_state (Jani)
v4: use max/min functions, change intel_xx *intel_xx to intel_xx *xx
(Jani)
Limit hblank to 511 and accommodate BS/BE in calculated value (Srikanth)
v5: Some spelling corrections (Suraj)

---
 .../gpu/drm/i915/display/intel_crtc_state_dump.c   |  1 +
 drivers/gpu/drm/i915/display/intel_display_types.h |  1 +
 drivers/gpu/drm/i915/display/intel_dp_mst.c        | 35
++++++++++++++++++++++
 drivers/gpu/drm/i915/i915_reg.h                    |  4 +++
 4 files changed, 41 insertions(+)
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +0 -0

index 1faef60be4728cd80a0a6b0151797ceda5c443ce..0e7e0b7803d9865177d6f 68e8afdef94a91d9697 100644

drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +0 -0
@@ -248,6 +248,7 @@ void intel_crtc_state_dump(const struct
 intel_crtc_state *pipe_config,
 			   str_enabled_disabled(pipe_config-
 >has_sel_update),
 			   str_enabled_disabled(pipe_config-
 >has_panel_replay),
 			   str_enabled_disabled(pipe_config-
Quoted 1 line

enable_psr2_sel_fetch));

drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +1 -0
+		drm_printf(&p, "minimum HBlank: %d\n", pipe_config-
Quoted 1 line

min_hblank);

drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +0 -1
 	}
 
 	drm_printf(&p, "framestart delay: %d, MSA timing delay: %d\n", diff -
-git a/drivers/gpu/drm/i915/display/intel_display_types.h

b/drivers/gpu/drm/i915/display/intel_display_types.h index eb9dd1125a4a09511936b81219e7f38fae106dfd..7d3a7700c44ef200d811 d9e90ea465c06104287e 100644

drivers/gpu/drm/i915/display/intel_display_types.h struct intel_crtc_state { · line 1098

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
@@ -1095,6 +1095,7 @@ struct intel_crtc_state {
 
 	int max_link_bpp_x16;	/* in 1/16 bpp units */
 	int pipe_bpp;		/* in 1 bpp units */
+	int min_hblank;		/* min HBlank for DP2.1 */

I think this comment should state min HBlank for MST and not DP2.1 since we use it For non uhbr cases too
With the above fixed

Quoted 105 lines
drivers/gpu/drm/i915/display/intel_display_types.h +0 -0
 	struct intel_link_m_n dp_m_n;
 
 	/* m2_n2 for eDP downclock */
drivers/gpu/drm/i915/display/intel_dp_mst.c +0 -0

index fffd199999e02eb66ea478ff872f72b277bd3970..bd561c08d945fcafa65af92 54a71cd66f17923d2 100644

drivers/gpu/drm/i915/display/intel_dp_mst.c +0 -0
@@ -211,6 +211,35 @@ static int intel_dp_mst_dsc_get_slice_count(const

struct intel_connector *connec

drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -0
 					    num_joined_pipes);
 }
 
+static void intel_dp_mst_compute_min_hblank(struct intel_crtc_state

*crtc_state,

drivers/gpu/drm/i915/display/intel_dp_mst.c +14 -0
+					    struct intel_connector *connector,
+					    int bpp_x16)
+{
+	struct intel_encoder *encoder = connector->encoder;
+	struct intel_display *display = to_intel_display(encoder);
+	const struct drm_display_mode *adjusted_mode =
+					&crtc_state->hw.adjusted_mode;
+	int symbol_size = intel_dp_is_uhbr(crtc_state) ? 32 : 8;
+	int hblank;
+
+	if (DISPLAY_VER(display) < 20)
+		return;
+
+	/* Calculate min Hblank Link Layer Symbol Cycle Count for 8b/10b

MST & 128b/132b */

drivers/gpu/drm/i915/display/intel_dp_mst.c +4 -0
+	hblank = DIV_ROUND_UP((DIV_ROUND_UP(adjusted_mode->htotal -
+adjusted_mode->hdisplay, 4) * bpp_x16), symbol_size);
+
+	/* bit 8:0 minimum hblank symbol cylce count, i.e maximum value

would be 511 */

drivers/gpu/drm/i915/display/intel_dp_mst.c +3 -0
+	hblank = min(511, hblank);
+
+	/* Software needs to adjust the BS/BE framing control from the

calculated value */

drivers/gpu/drm/i915/display/intel_dp_mst.c +8 -0
+	hblank = hblank - 2;
+
+	if (intel_dp_is_uhbr(crtc_state))
+		crtc_state->min_hblank = max(hblank, 5);
+	else
+		crtc_state->min_hblank = max(hblank, 3); }
+
 static int mst_stream_find_vcpi_slots_for_bpp(struct intel_dp *intel_dp,
 					      struct intel_crtc_state *crtc_state,
 					      int max_bpp, int min_bpp,
@@ -284,6 +313,8 @@ static int mst_stream_find_vcpi_slots_for_bpp(struct
 intel_dp *intel_dp,
 		remote_bw_overhead =
 intel_dp_mst_bw_overhead(crtc_state, connector,
 							      true,
 dsc_slice_count, link_bpp_x16);
 
+		intel_dp_mst_compute_min_hblank(crtc_state, connector,

link_bpp_x16);

drivers/gpu/drm/i915/display/intel_dp_mst.c +5 -0
+
 		intel_dp_mst_compute_m_n(crtc_state, connector,
 					 local_bw_overhead,
 					 link_bpp_x16,
@@ -1267,6 +1298,10 @@ static void mst_stream_enable(struct
 intel_atomic_state *state,
 			       TRANS_DP2_VFREQ_PIXEL_CLOCK(crtc_clock_hz
 & 0xffffff));
 	}
 
+	if (DISPLAY_VER(display) >= 20)
+		intel_de_write(display, DP_MIN_HBLANK_CTL(trans),
+			       pipe_config->min_hblank);
+
 	enable_bs_jitter_was(pipe_config);

intel_ddi_enable_transcoder_func(encoder, pipe_config); diff --git
a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 765e6c0528fb0b5a894395b77a5edbf0b0c80009..7bd783931199e2e5c7e1 5358bb4d2c904f28176a 100644

drivers/gpu/drm/i915/i915_reg.h +4 -0
@@ -3197,6 +3197,10 @@
 #define _TRANS_DP2_VFREQLOW_D			0x630a8
 #define TRANS_DP2_VFREQLOW(trans)
 	_MMIO_TRANS(trans, _TRANS_DP2_VFREQLOW_A,
 _TRANS_DP2_VFREQLOW_B)
 
+#define _DP_MIN_HBLANK_CTL_A			0x600ac
+#define _DP_MIN_HBLANK_CTL_B			0x610ac
+#define DP_MIN_HBLANK_CTL(trans)		_MMIO_TRANS(trans,
 _DP_MIN_HBLANK_CTL_A, _DP_MIN_HBLANK_CTL_B)
+

/* SNB eDP training params */
/* SNB A-stepping */
#define EDP_LINK_TRAIN_400MV_0DB_SNB_A (0x38 << 22)

---
base-commit: 048d83e7f9dae81c058d31c371634c1c317b3013
change-id: 20250103-hblank-cd7e78cbe178

Best regards,
--
Arun R Murthy <[email protected]>

maintainer
#2 lore raw
Quoted 8 lines · Suraj
Quoted 8 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Arun R Murthy
Sent: Friday, January 3, 2025 10:43 AM
To: [email protected]; [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH v5] drm/i915/dp: Guarantee a minimum HBlank time

Quoted 7 lines
Quoted 3 lines

Mandate a minimum Hblank symbol cycle count between BS and BE in 8b/10b MST and 128b/132b mode.
Spec: DP2.1a

The spec is mentioned usually right before the Signed-off-by Spec:
Signed-off-by

They're called commit message trailers [1]. We just don't reference DP specs like this, there really isn't much point because it's all free form. Please put it in the commit message prose as proper sentences.

And what good does a "DP2.1a" spec reference bring us? It's 1500+ pages. Please cite a section.

(Bspec references we do use, and use "Bspec:" for them.)

[1] https://git-scm.com/docs/git-interpret-trailers

Quoted 91 lines
Quoted 47 lines

v2: Affine calculation/updation of min HBlank to dp_mst (Jani)
v3: moved min_hblank from struct intel_dp to intel_crtc_state (Jani)
v4: use max/min functions, change intel_xx *intel_xx to intel_xx *xx
(Jani)
Limit hblank to 511 and accommodate BS/BE in calculated value (Srikanth)
v5: Some spelling corrections (Suraj)

---
 .../gpu/drm/i915/display/intel_crtc_state_dump.c   |  1 +
 drivers/gpu/drm/i915/display/intel_display_types.h |  1 +
 drivers/gpu/drm/i915/display/intel_dp_mst.c        | 35
++++++++++++++++++++++
 drivers/gpu/drm/i915/i915_reg.h                    |  4 +++
 4 files changed, 41 insertions(+)
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +0 -0

index 1faef60be4728cd80a0a6b0151797ceda5c443ce..0e7e0b7803d9865177d6f 68e8afdef94a91d9697 100644

drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +0 -0
@@ -248,6 +248,7 @@ void intel_crtc_state_dump(const struct
 intel_crtc_state *pipe_config,
 			   str_enabled_disabled(pipe_config-
 >has_sel_update),
 			   str_enabled_disabled(pipe_config-
 >has_panel_replay),
 			   str_enabled_disabled(pipe_config-
Quoted 1 line

enable_psr2_sel_fetch));

drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +1 -0
+		drm_printf(&p, "minimum HBlank: %d\n", pipe_config-
Quoted 1 line

min_hblank);

drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +0 -1
 	}
 
 	drm_printf(&p, "framestart delay: %d, MSA timing delay: %d\n", diff -
-git a/drivers/gpu/drm/i915/display/intel_display_types.h

b/drivers/gpu/drm/i915/display/intel_display_types.h index eb9dd1125a4a09511936b81219e7f38fae106dfd..7d3a7700c44ef200d811 d9e90ea465c06104287e 100644

drivers/gpu/drm/i915/display/intel_display_types.h struct intel_crtc_state { · line 1098

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
@@ -1095,6 +1095,7 @@ struct intel_crtc_state {
 
 	int max_link_bpp_x16;	/* in 1/16 bpp units */
 	int pipe_bpp;		/* in 1 bpp units */
+	int min_hblank;		/* min HBlank for DP2.1 */

I think this comment should state min HBlank for MST and not DP2.1 since we use it For non uhbr cases too
With the above fixed

Quoted 34 lines
drivers/gpu/drm/i915/display/intel_display_types.h +0 -0
 	struct intel_link_m_n dp_m_n;
 
 	/* m2_n2 for eDP downclock */
drivers/gpu/drm/i915/display/intel_dp_mst.c +0 -0

index fffd199999e02eb66ea478ff872f72b277bd3970..bd561c08d945fcafa65af92 54a71cd66f17923d2 100644

drivers/gpu/drm/i915/display/intel_dp_mst.c +0 -0
@@ -211,6 +211,35 @@ static int intel_dp_mst_dsc_get_slice_count(const

struct intel_connector *connec

drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -0
 					    num_joined_pipes);
 }
 
+static void intel_dp_mst_compute_min_hblank(struct intel_crtc_state

*crtc_state,

drivers/gpu/drm/i915/display/intel_dp_mst.c +14 -0
+					    struct intel_connector *connector,
+					    int bpp_x16)
+{
+	struct intel_encoder *encoder = connector->encoder;
+	struct intel_display *display = to_intel_display(encoder);
+	const struct drm_display_mode *adjusted_mode =
+					&crtc_state->hw.adjusted_mode;
+	int symbol_size = intel_dp_is_uhbr(crtc_state) ? 32 : 8;
+	int hblank;
+
+	if (DISPLAY_VER(display) < 20)
+		return;
+
+	/* Calculate min Hblank Link Layer Symbol Cycle Count for 8b/10b

MST & 128b/132b */

drivers/gpu/drm/i915/display/intel_dp_mst.c +2 -0
+	hblank = DIV_ROUND_UP((DIV_ROUND_UP(adjusted_mode->htotal -
+adjusted_mode->hdisplay, 4) * bpp_x16), symbol_size);
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_dp_mst.c static int intel_dp_mst_dsc_get_slice_count(const struct intel_connector *connec · line 235

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_dp_mst.c +2 -0
+
+	/* bit 8:0 minimum hblank symbol cylce count, i.e maximum value

would be 511 */

drivers/gpu/drm/i915/display/intel_dp_mst.c +3 -0
+	hblank = min(511, hblank);
+
+	/* Software needs to adjust the BS/BE framing control from the

calculated value */

drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -0
+	hblank = hblank - 2;

Please reconsider your comments above. How does "Software needs to" in driver code help? But then "BS/BE" goes unexplained. Please try to actually help the reader instead of copy-pasting from bspec.

Also, spell check.

Quoted 5 lines

drivers/gpu/drm/i915/display/intel_dp_mst.c static int intel_dp_mst_dsc_get_slice_count(const struct intel_connector *connec · line 240

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dp_mst.c +5 -0
+
+	if (intel_dp_is_uhbr(crtc_state))
+		crtc_state->min_hblank = max(hblank, 5);
+	else
+		crtc_state->min_hblank = max(hblank, 3);

I'm not a huge fan of storing direct register values in crtc state.

The member name is "min_hblank", the comment and logging for it say "min hblank", but there's zero indication what the value actually is. I think it's surprising it's some direct register value instead of the logical value.

}

Quoted 59 lines
Quoted 58 lines
drivers/gpu/drm/i915/display/intel_dp_mst.c +2 -0
+
 static int mst_stream_find_vcpi_slots_for_bpp(struct intel_dp *intel_dp,
 					      struct intel_crtc_state *crtc_state,
 					      int max_bpp, int min_bpp,
@@ -284,6 +313,8 @@ static int mst_stream_find_vcpi_slots_for_bpp(struct
 intel_dp *intel_dp,
 		remote_bw_overhead =
 intel_dp_mst_bw_overhead(crtc_state, connector,
 							      true,
 dsc_slice_count, link_bpp_x16);
 
+		intel_dp_mst_compute_min_hblank(crtc_state, connector,

link_bpp_x16);

drivers/gpu/drm/i915/display/intel_dp_mst.c +5 -0
+
 		intel_dp_mst_compute_m_n(crtc_state, connector,
 					 local_bw_overhead,
 					 link_bpp_x16,
@@ -1267,6 +1298,10 @@ static void mst_stream_enable(struct
 intel_atomic_state *state,
 			       TRANS_DP2_VFREQ_PIXEL_CLOCK(crtc_clock_hz
 & 0xffffff));
 	}
 
+	if (DISPLAY_VER(display) >= 20)
+		intel_de_write(display, DP_MIN_HBLANK_CTL(trans),
+			       pipe_config->min_hblank);
+
 	enable_bs_jitter_was(pipe_config);

intel_ddi_enable_transcoder_func(encoder, pipe_config); diff --git
a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 765e6c0528fb0b5a894395b77a5edbf0b0c80009..7bd783931199e2e5c7e1 5358bb4d2c904f28176a 100644

drivers/gpu/drm/i915/i915_reg.h +4 -0
@@ -3197,6 +3197,10 @@
 #define _TRANS_DP2_VFREQLOW_D			0x630a8
 #define TRANS_DP2_VFREQLOW(trans)
 	_MMIO_TRANS(trans, _TRANS_DP2_VFREQLOW_A,
 _TRANS_DP2_VFREQLOW_B)
 
+#define _DP_MIN_HBLANK_CTL_A			0x600ac
+#define _DP_MIN_HBLANK_CTL_B			0x610ac
+#define DP_MIN_HBLANK_CTL(trans)		_MMIO_TRANS(trans,
 _DP_MIN_HBLANK_CTL_A, _DP_MIN_HBLANK_CTL_B)
+

/* SNB eDP training params */
/* SNB A-stepping */
#define EDP_LINK_TRAIN_400MV_0DB_SNB_A (0x38 << 22)

---
base-commit: 048d83e7f9dae81c058d31c371634c1c317b3013
change-id: 20250103-hblank-cd7e78cbe178

Best regards,
--
Arun R Murthy <[email protected]>

Signature · 1 line
Jani Nikula, Intel
#3 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Guarantee a minimum HBlank time (rev5)

In reply to Arun R Murthy
== Series Details ==

== Series Details ==

Series: drm/i915/dp: Guarantee a minimum HBlank time (rev5)
URL : https://patchwork.freedesktop.org/series/139267/
State : warning

== Summary ==

Error: dim checkpatch failed
6a6116420c7b drm/i915/dp: Guarantee a minimum HBlank time -:67: WARNING:LONG_LINE: line length of 121 exceeds 100 columns #67: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:229:
+ hblank = DIV_ROUND_UP((DIV_ROUND_UP(adjusted_mode->htotal - adjusted_mode->hdisplay, 4) * bpp_x16), symbol_size);

-:114: WARNING:LONG_LINE: line length of 110 exceeds 100 columns #114: FILE: drivers/gpu/drm/i915/i915_reg.h:3202:
+#define DP_MIN_HBLANK_CTL(trans) _MMIO_TRANS(trans, _DP_MIN_HBLANK_CTL_A, _DP_MIN_HBLANK_CTL_B)

total: 0 errors, 2 warnings, 0 checks, 77 lines checked

#4 lore raw

✓ i915.CI.BAT: success for drm/i915/dp: Guarantee a minimum HBlank time (rev5)

In reply to Arun R Murthy
== Series Details ==

== Series Details ==

Series: drm/i915/dp: Guarantee a minimum HBlank time (rev5)
URL : https://patchwork.freedesktop.org/series/139267/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_15896 -> Patchwork_139267v5
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139267v5/index.html

Participating hosts (40 -> 39)
------------------------------

Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_139267v5:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_module_load@load:
- {bat-mtlp-9}: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15896/bat-mtlp-9/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139267v5/bat-mtlp-9/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_139267v5 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_pm_rpm@module-reload:
- bat-rpls-4: [PASS][3] -> [FAIL][4] ([i915#13401])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15896/bat-rpls-4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139267v5/bat-rpls-4/igt@[email protected]

* igt@i915_selftest@live:
- bat-arlh-3: [PASS][5] -> [DMESG-FAIL][6] ([i915#12435] / [i915#13393])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15896/bat-arlh-3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139267v5/bat-arlh-3/igt@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-arlh-3: [PASS][7] -> [DMESG-FAIL][8] ([i915#13393])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15896/bat-arlh-3/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139267v5/bat-arlh-3/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: [PASS][9] -> [SKIP][10] ([i915#9197]) +3 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15896/bat-dg2-11/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139267v5/bat-dg2-11/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live:
- bat-mtlp-8: [DMESG-FAIL][11] ([i915#13393]) -> [PASS][12] +1 other test pass
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15896/bat-mtlp-8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139267v5/bat-mtlp-8/igt@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-arls-5: [DMESG-FAIL][13] ([i915#13393]) -> [PASS][14] +1 other test pass
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15896/bat-arls-5/igt@i915_selftest@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139267v5/bat-arls-5/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#12435]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12435
[i915#13393]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13393
[i915#13401]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13401
[i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197

Build changes
-------------

* Linux: CI_DRM_15896 -> Patchwork_139267v5

CI-20190529: 20190529
CI_DRM_15896: 048d83e7f9dae81c058d31c371634c1c317b3013 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8174: d2004b0623dbccd08502525849b4eef881aa199e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_139267v5: 048d83e7f9dae81c058d31c371634c1c317b3013 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139267v5/index.html