Skip to contentSkip to conversation

wireless: airo: remove ISA_DMA_API dependency

PATCH In review Arnd Bergmann 3 participants 4 messages Apr 17, 2023 – Apr 20, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wireless: airo: remove ISA_DMA_API dependency

From: Arnd Bergmann <[email protected]>

This driver does not actually use the ISA DMA API, it is purely PIO based, so remove the dependency.

---
 drivers/net/wireless/cisco/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/cisco/Kconfig +1 -1
index 681bfc2d740a..b40ee25aca99 100644
@@ -14,7 +14,7 @@ if WLAN_VENDOR_CISCO
 
 config AIRO
 	tristate "Cisco/Aironet 34X/35X/4500/4800 ISA and PCI cards"
-	depends on CFG80211 && ISA_DMA_API && (PCI || BROKEN)
+	depends on CFG80211 && (PCI || BROKEN)
 	select WIRELESS_EXT
 	select CRYPTO
 	select CRYPTO_SKCIPHER
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

This driver does not actually use the ISA DMA API, it is purely PIO based, so remove the dependency.

Hi Arnd,

I think that the subject prefix should probably be 'wifi: airo: '. That nit aside, FWIIW, this looks good to me.

Quoted 20 lines
---
 drivers/net/wireless/cisco/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/cisco/Kconfig +1 -1
index 681bfc2d740a..b40ee25aca99 100644
@@ -14,7 +14,7 @@ if WLAN_VENDOR_CISCO
 
 config AIRO
 	tristate "Cisco/Aironet 34X/35X/4500/4800 ISA and PCI cards"
-	depends on CFG80211 && ISA_DMA_API && (PCI || BROKEN)
+	depends on CFG80211 && (PCI || BROKEN)
 	select WIRELESS_EXT
 	select CRYPTO
 	select CRYPTO_SKCIPHER
Signature · 1 line
2.39.2
#2 lore raw
Quoted 6 lines · Simon Horman
Quoted 5 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

This driver does not actually use the ISA DMA API, it is purely PIO based, so remove the dependency.

Quoted 6 lines
Quoted 1 line

Hi Arnd,

I think that the subject prefix should probably be 'wifi: airo: '. That nit aside, FWIIW, this looks good to me.

I can fix that during commit.

Quoted 1 line

Thanks for the review!

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#3 lore raw

Re: wifi: airo: remove ISA_DMA_API dependency

In reply to Arnd Bergmann
Quoted 7 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

This driver does not actually use the ISA DMA API, it is purely PIO based, so remove the dependency.

Patch applied to wireless-next.git, thanks.

09be55585d27 wifi: airo: remove ISA_DMA_API dependency

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches