Skip to contentSkip to conversation

arm64: dts: marvell: armada-ap810: Fix GICv3 ITS node name

PATCH Applied Rob Herring 4 participants 8 messages Feb 7, 2023 – Apr 7, 2023

Subsystems (2)
Device tree bindings Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: marvell: armada-ap810: Fix GICv3 ITS node name

The GICv3 ITS is an MSI controller, therefore its node name should be 'msi-controller'.

Signed-off-by Rob Herring <[email protected]>
---
 arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi +1 -1
index 8107d120a8a7..2f9ab6b4a2c9 100644
@@ -54,7 +54,7 @@ gic: interrupt-controller@3000000 {
 				      <0x00d0000 0x1000>,	/* GICH */
 				      <0x00e0000 0x2000>;	/* GICV */
 
-				gic_its_ap0: interrupt-controller@3040000 {
+				gic_its_ap0: msi-controller@3040000 {
 					compatible = "arm,gic-v3-its";
 					msi-controller;
 					#msi-cells = <1>;
Signature · 1 line
2.39.1
author maintainer
#1 lore raw
Quoted 8 lines · Rob Herring

The GICv3 ITS is an MSI controller, therefore its node name should be 'msi-controller'.

Signed-off-by Rob Herring <[email protected]>
---
 arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Ping!

If not maintained, should I send a patch removing this platform instead?

Quoted 17 lines
arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi +1 -2
index 8107d120a8a7..2f9ab6b4a2c9 100644
@@ -54,7 +54,7 @@ gic: interrupt-controller@3000000 {
                                      <0x00d0000 0x1000>,       /* GICH */
                                      <0x00e0000 0x2000>;       /* GICV */
 
-                               gic_its_ap0: interrupt-controller@3040000 {
+                               gic_its_ap0: msi-controller@3040000 {
                                        compatible = "arm,gic-v3-its";
                                        msi-controller;
                                        #msi-cells = <1>;
--

2.39.1

#2 lore raw
Quoted 5 lines · Rob Herring
Quoted 4 lines · Rob Herring

The GICv3 ITS is an MSI controller, therefore its node name should be 'msi-controller'.

Quoted 8 lines
Quoted 4 lines
Signed-off-by Rob Herring <[email protected]>
---
 arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Ping!

If not maintained, should I send a patch removing this platform instead?

I am not the maintainer but I produce (and take) such stuff, so I can take this one.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#3 lore raw
In reply to Rob Herring
Quoted 5 lines · Rob Herring
Quoted 4 lines · Rob Herring

The GICv3 ITS is an MSI controller, therefore its node name should be 'msi-controller'.

Quoted 8 lines
Quoted 4 lines
Signed-off-by Rob Herring <[email protected]>
---
 arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Ping!

If not maintained, should I send a patch removing this platform instead?

Gregory usually picks these up around -rc6.

Andrew

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw
Quoted 11 lines · Andrew Lunn
Quoted 10 lines · Rob Herring
Quoted 8 lines · Rob Herring

The GICv3 ITS is an MSI controller, therefore its node name should be 'msi-controller'.

Signed-off-by Rob Herring <[email protected]>
---
 arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines
Quoted 3 lines

Ping!

If not maintained, should I send a patch removing this platform instead?

Gregory usually picks these up around -rc6.

Hm, so they stay in next for just one or two weeks before sending to arm-soc? Why? They should be in the next as fast as possible, why waiting?

Second question, shall I drop it?

Best regards,
Krzysztof

author maintainer
#5 lore raw
In reply to Andrew Lunn
Quoted 12 lines · Andrew Lunn
Quoted 10 lines · Rob Herring
Quoted 8 lines · Rob Herring

The GICv3 ITS is an MSI controller, therefore its node name should be 'msi-controller'.

Signed-off-by Rob Herring <[email protected]>
---
 arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines
Quoted 3 lines

Ping!

If not maintained, should I send a patch removing this platform instead?

Gregory usually picks these up around -rc6.

Ignoring patches for up to 2 months is not a great experience for submitters.

Rob

Applied
#6 lore raw
In reply to Rob Herring
Quoted 4 lines · Rob Herring

The GICv3 ITS is an MSI controller, therefore its node name should be 'msi-controller'.

Applied, thanks! Let me know if anyone else wants to take it instead.

[1/1] arm64: dts: marvell: armada-ap810: Fix GICv3 ITS node name

      https://git.kernel.org/krzk/linux-dt/c/fce7defb8a46c31cf9384fee6e4b1e4920c46ff7

Best regards,

Signature · 6 lines
Krzysztof Kozlowski <[email protected]>

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#7 lore raw
Quoted 10 lines · Krzysztof Kozlowski
Quoted 4 lines · Rob Herring

The GICv3 ITS is an MSI controller, therefore its node name should be 'msi-controller'.

Applied, thanks! Let me know if anyone else wants to take it instead.

[1/1] arm64: dts: marvell: armada-ap810: Fix GICv3 ITS node name

      https://git.kernel.org/krzk/linux-dt/c/fce7defb8a46c31cf9384fee6e4b1e4920c46ff7

Let's hope it won't cause merge issue.

Gregory

Quoted 4 lines

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>
Signature · 3 lines
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com