Skip to contentSkip to conversation

ACPI/processor: Remove unused function acpi_processor_get_limit_info()

PATCH Applied Riwen Lu 3 participants 3 messages Jun 17, 2022 – Jun 29, 2022 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Riwen Lu

author
#1 lore raw

PATCH v2 1/1 ACPI/processor: Remove unused function acpi_processor_get_limit_info()

From: Riwen Lu <[email protected]>

Commit 22e7551eb6fd ("ACPI / processor: Remove acpi_processor_get_limit_info()"), left behind this, remove it.

---
v1 -> v2:
- Make this patch base on ("ACPI: Split out processor thermal register from ACPI PSS").

---
 include/acpi/processor.h | 1 -
 1 file changed, 1 deletion(-)
include/acpi/processor.h +0 -1
index ba1e3ed98d3d..9fa49686957a 100644
@@ -441,7 +441,6 @@ static inline int acpi_processor_hotplug(struct acpi_processor *pr)
 #endif /* CONFIG_ACPI_PROCESSOR_IDLE */
 
 /* in processor_thermal.c */
-int acpi_processor_get_limit_info(struct acpi_processor *pr);
 int acpi_processor_thermal_init(struct acpi_processor *pr,
 				struct acpi_device *device);
 void acpi_processor_thermal_exit(struct acpi_processor *pr,
Signature · 1 line
2.25.1
Reviewed-by on v2 1/1
#2 lore raw
Quoted 11 lines · Riwen Lu

From: Riwen Lu <[email protected]>

Commit 22e7551eb6fd ("ACPI / processor: Remove acpi_processor_get_limit_info()"), left behind this, remove it.

---
v1 -> v2:
- Make this patch base on ("ACPI: Split out processor thermal register from ACPI PSS").

For such changes, it is better to send all the related patches as a series so it's easy to see the dependencies . In a series the easy / obvious fixes should be earlier so it's easier for them to be merged while the more significant changes are still being discussed.

Hopefully in this case Rafael too agrees with the dependency patch - otherwise, it's just extra churn on the lists.

But don't resend just yet - give some time for others to add their feedback.

Quoted 9 lines
---
 include/acpi/processor.h | 1 -
 1 file changed, 1 deletion(-)
include/acpi/processor.h +0 -0
index ba1e3ed98d3d..9fa49686957a 100644

include/acpi/processor.h static inline int acpi_processor_hotplug(struct acpi_processor *pr) · line 446

Quoted 7 lines
include/acpi/processor.h +0 -1
@@ -441,7 +441,6 @@ static inline int acpi_processor_hotplug(struct acpi_processor *pr)
 #endif /* CONFIG_ACPI_PROCESSOR_IDLE */
 
 /* in processor_thermal.c */
-int acpi_processor_get_limit_info(struct acpi_processor *pr);
 int acpi_processor_thermal_init(struct acpi_processor *pr,
 				struct acpi_device *device);
 void acpi_processor_thermal_exit(struct acpi_processor *pr,

Fwiw,

maintainer Applied
#3 lore raw
Quoted 45 lines · Punit Agrawal
Quoted 11 lines · Riwen Lu

From: Riwen Lu <luriwen(a)kylinos.cn>

Commit 22e7551eb6fd ("ACPI / processor: Remove acpi_processor_get_limit_info()"), left behind this, remove it.

Signed-off-by Riwen Lu <luriwen(a)kylinos.cn>

---
v1 -> v2:
- Make this patch base on ("ACPI: Split out processor thermal register from ACPI PSS").

For such changes, it is better to send all the related patches as a series so it's easy to see the dependencies . In a series the easy / obvious fixes should be earlier so it's easier for them to be merged while the more significant changes are still being discussed.

Hopefully in this case Rafael too agrees with the dependency patch - otherwise, it's just extra churn on the lists.

But don't resend just yet - give some time for others to add their feedback.

Quoted 9 lines
---
 include/acpi/processor.h | 1 -
 1 file changed, 1 deletion(-)
include/acpi/processor.h +0 -0
index ba1e3ed98d3d..9fa49686957a 100644

include/acpi/processor.h static inline int acpi_processor_hotplug(struct acpi_processor *pr) · line 446

Quoted 7 lines
include/acpi/processor.h +0 -1
@@ -441,7 +441,6 @@ static inline int acpi_processor_hotplug(struct acpi_processor *pr)
 #endif /* CONFIG_ACPI_PROCESSOR_IDLE */
 
 /* in processor_thermal.c */
-int acpi_processor_get_limit_info(struct acpi_processor *pr);
 int acpi_processor_thermal_init(struct acpi_processor *pr,
                              struct acpi_device *device);
 void acpi_processor_thermal_exit(struct acpi_processor *pr,

Fwiw,

Quoted 1 line
Reviewed-by Punit Agrawal <punit.agrawal(a)bytedance.com>

Applied as 5.20 material with some edits in the subject and changelog.

Thanks!