Skip to contentSkip to conversation

tlv_eeprom: Add missing CRC32 dependency

PATCH In review Pali Rohár 3 participants 4 messages May 30, 2022 – Jul 21, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tlv_eeprom: Add missing CRC32 dependency

tlv_eeprom uses crc32() function, so add dependency into Kconfig.

---
 cmd/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
cmd/Kconfig +2 -0
index 69c1814d24af..d513d808aa3d 100644
@@ -167,6 +167,7 @@ config CMD_REGINFO
 config CMD_TLV_EEPROM
 	bool "tlv_eeprom"
 	depends on I2C_EEPROM
+	select CRC32
 	help
 	  Display and program the system EEPROM data block in ONIE Tlvinfo
 	  format. TLV stands for Type-Length-Value.
@@ -175,6 +176,7 @@ config SPL_CMD_TLV_EEPROM
 	bool "tlv_eeprom for SPL"
 	depends on SPL_I2C_EEPROM
 	select SPL_DRIVERS_MISC
+	select SPL_CRC32
 	help
 	  Read system EEPROM data block in ONIE Tlvinfo format from SPL.
 
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Pali,

Quoted 3 lines · Pali Rohár

tlv_eeprom uses crc32() function, so add dependency into Kconfig.

Thanks,
baruch

Quoted 23 lines
---
 cmd/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
cmd/Kconfig +2 -0
index 69c1814d24af..d513d808aa3d 100644
@@ -167,6 +167,7 @@ config CMD_REGINFO
 config CMD_TLV_EEPROM
 	bool "tlv_eeprom"
 	depends on I2C_EEPROM
+	select CRC32
 	help
 	  Display and program the system EEPROM data block in ONIE Tlvinfo
 	  format. TLV stands for Type-Length-Value.
@@ -175,6 +176,7 @@ config SPL_CMD_TLV_EEPROM
 	bool "tlv_eeprom for SPL"
 	depends on SPL_I2C_EEPROM
 	select SPL_DRIVERS_MISC
+	select SPL_CRC32
 	help
 	  Read system EEPROM data block in ONIE Tlvinfo format from SPL.
Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
Reviewed-by on v1 1/1
#2 lore raw
In reply to Pali Rohár
Quoted 3 lines · Pali Rohár

tlv_eeprom uses crc32() function, so add dependency into Kconfig.

Thanks,
Stefan

Quoted 17 lines
---
  cmd/Kconfig | 2 ++
  1 file changed, 2 insertions(+)
cmd/Kconfig +1 -0
index 69c1814d24af..d513d808aa3d 100644
@@ -167,6 +167,7 @@ config CMD_REGINFO
  config CMD_TLV_EEPROM
  	bool "tlv_eeprom"
  	depends on I2C_EEPROM
+	select CRC32
  	help
  	  Display and program the system EEPROM data block in ONIE Tlvinfo
  	  format. TLV stands for Type-Length-Value.

cmd/Kconfig config SPL_CMD_TLV_EEPROM · line 182

Quoted 7 lines
cmd/Kconfig +1 -0
@@ -175,6 +176,7 @@ config SPL_CMD_TLV_EEPROM
  	bool "tlv_eeprom for SPL"
  	depends on SPL_I2C_EEPROM
  	select SPL_DRIVERS_MISC
+	select SPL_CRC32
  	help
  	  Read system EEPROM data block in ONIE Tlvinfo format from SPL.
 

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#3 lore raw
In reply to Pali Rohár
Quoted 3 lines · Pali Rohár

tlv_eeprom uses crc32() function, so add dependency into Kconfig.

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 17 lines
---
  cmd/Kconfig | 2 ++
  1 file changed, 2 insertions(+)
cmd/Kconfig +1 -0
index 69c1814d24af..d513d808aa3d 100644
@@ -167,6 +167,7 @@ config CMD_REGINFO
  config CMD_TLV_EEPROM
  	bool "tlv_eeprom"
  	depends on I2C_EEPROM
+	select CRC32
  	help
  	  Display and program the system EEPROM data block in ONIE Tlvinfo
  	  format. TLV stands for Type-Length-Value.

cmd/Kconfig config SPL_CMD_TLV_EEPROM · line 182

Quoted 7 lines
cmd/Kconfig +1 -0
@@ -175,6 +176,7 @@ config SPL_CMD_TLV_EEPROM
  	bool "tlv_eeprom for SPL"
  	depends on SPL_I2C_EEPROM
  	select SPL_DRIVERS_MISC
+	select SPL_CRC32
  	help
  	  Read system EEPROM data block in ONIE Tlvinfo format from SPL.
 

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]