package/apitrace: fix build failure on m68k architecture
PATCH 1/1 package/apitrace: fix build failure on m68k architecture
apitrace uses very big switch statements, which causes the build to fail on m68k, because the offsets there are only 16-bit.
We fix that by using -mlong-jump-table-offsets on m68k, to use 32-bit offsets for switch statements. That flag is available on gcc version >= 7 but apitrace package already depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7, so we can use it with no problem.
Fixes:
http://autobuild.buildroot.net/results/7306bf05962fec30fbe98b1eb8ee09b3162b8080/
--- package/apitrace/apitrace.mk | 5 +++++ 1 file changed, 5 insertions(+)
package/apitrace/apitrace.mk +5 -0
@@ -38,6 +38,11 @@ ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y) APITRACE_CXXFLAGS += -O0 endif +# m68k needs 32-bit offsets in switch tables to build +ifeq ($(BR2_m68k),y) +APITRACE_CXXFLAGS += -mlong-jump-table-offsets +endif + APITRACE_CONF_OPTS += \ -DCMAKE_C_FLAGS="$(APITRACE_CFLAGS)" \ -DCMAKE_CXX_FLAGS="$(APITRACE_CXXFLAGS)"
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedQuoted 8 lines · On Sat, 29 Jan 2022 19:34:26 +0100 Giulio Benetti…
apitrace uses very big switch statements, which causes the build to fail on m68k, because the offsets there are only 16-bit.
We fix that by using -mlong-jump-table-offsets on m68k, to use 32-bit offsets for switch statements. That flag is available on gcc version >= 7 but apitrace package already depends on
BR2_TOOLCHAIN_GCC_AT_LEAST_7, so we can use it with no problem.
Quoted 7 lines
Fixes:
http://autobuild.buildroot.net/results/7306bf05962fec30fbe98b1eb8ee09b3162b8080/Signed-off-by Giulio Benetti <[email protected]>--- package/apitrace/apitrace.mk | 5 +++++ 1 file changed, 5 insertions(+)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Giulio" == Giulio Benetti <[email protected]> writes:
apitrace uses very big switch statements, which causes the build to fail on m68k, because the offsets there are only 16-bit.
We fix that by using -mlong-jump-table-offsets on m68k, to use 32-bit offsets for switch statements. That flag is available on gcc version >= 7 but apitrace package already depends on
BR2_TOOLCHAIN_GCC_AT_LEAST_7, so we can use it with no problem.
Quoted 4 lines
Fixes:
http://autobuild.buildroot.net/results/7306bf05962fec30fbe98b1eb8ee09b3162b8080/Signed-off-by Giulio Benetti <[email protected]>
Committed to 2021.11.x, thanks.
Signature · 5 lines
Bye, Peter Korsgaard _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot