Skip to contentSkip to conversation

package/python-aiohttp: add aiosignal runtime dependency

PATCH Applied James Hilliard 3 participants 5 messages Jan 1, 2022 – Jan 26, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/python-aiohttp: add aiosignal runtime dependency

Fixes:
File "/usr/lib/python3.10/site-packages/aiohttp/__init__.py", line 6, in <module> File "/usr/lib/python3.10/site-packages/aiohttp/client.py", line 88, in <module> File "/usr/lib/python3.10/site-packages/aiohttp/tracing.py", line 5, in <module>
ModuleNotFoundError: No module named 'aiosignal'

---
 package/python-aiohttp/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/python-aiohttp/Config.in +1 -0
index 9ffea088e4..85a6862141 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_PYTHON_AIOHTTP
 	bool "python-aiohttp"
 	depends on BR2_PACKAGE_PYTHON3
 	select BR2_PACKAGE_PYTHON_AIODNS # runtime
+	select BR2_PACKAGE_PYTHON_AIOSIGNAL # runtime
 	select BR2_PACKAGE_PYTHON_ASYNC_TIMEOUT # runtime
 	select BR2_PACKAGE_PYTHON_ATTRS # runtime
 	select BR2_PACKAGE_PYTHON_CCHARDET if BR2_INSTALL_LIBSTDCPP # runtime
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

James, All,

On 2021-12-31 17:04 -0700, James Hilliard spake thusly:

Quoted 5 lines

Fixes:
File "/usr/lib/python3.10/site-packages/aiohttp/__init__.py", line 6, in <module> File "/usr/lib/python3.10/site-packages/aiohttp/client.py", line 88, in <module> File "/usr/lib/python3.10/site-packages/aiohttp/tracing.py", line 5, in <module>
ModuleNotFoundError: No module named 'aiosignal'

What about a small runtime test to ensure we no longer miss any such dependency in the future? ;-)

Quoted 1 line

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 23 lines
---
 package/python-aiohttp/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/python-aiohttp/Config.in +1 -0
index 9ffea088e4..85a6862141 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_PYTHON_AIOHTTP
 	bool "python-aiohttp"
 	depends on BR2_PACKAGE_PYTHON3
 	select BR2_PACKAGE_PYTHON_AIODNS # runtime
+	select BR2_PACKAGE_PYTHON_AIOSIGNAL # runtime
 	select BR2_PACKAGE_PYTHON_ASYNC_TIMEOUT # runtime
 	select BR2_PACKAGE_PYTHON_ATTRS # runtime
 	select BR2_PACKAGE_PYTHON_CCHARDET if BR2_INSTALL_LIBSTDCPP # runtime
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to James Hilliard
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"James" == James Hilliard <[email protected]> writes:

Fixes:
File "/usr/lib/python3.10/site-packages/aiohttp/__init__.py", line 6, in <module> File "/usr/lib/python3.10/site-packages/aiohttp/client.py", line 88, in <module> File "/usr/lib/python3.10/site-packages/aiohttp/tracing.py", line 5, in <module>
ModuleNotFoundError: No module named 'aiosignal'

When was this introduced? Do we need to backport this to 2021.02.x / 2021.11.x?

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw
Quoted 9 lines · Peter Korsgaard
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"James" == James Hilliard <[email protected]> writes:

Fixes:
File "/usr/lib/python3.10/site-packages/aiohttp/__init__.py", line 6, in <module> File "/usr/lib/python3.10/site-packages/aiohttp/client.py", line 88, in <module> File "/usr/lib/python3.10/site-packages/aiohttp/tracing.py", line 5, in <module>
ModuleNotFoundError: No module named 'aiosignal'

Quoted 4 lines
Quoted 1 line

When was this introduced? Do we need to backport this to 2021.02.x / 2021.11.x?

Looks like it's required for aiohttp v3.8.0 and newer, so we shouldn't need to backport.

Quoted 3 lines

--
Bye, Peter Korsgaard

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw
Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"James" == James Hilliard <[email protected]> writes:

Quoted 9 lines · Peter Korsgaard
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"James" == James Hilliard <[email protected]> writes:

Fixes:
File "/usr/lib/python3.10/site-packages/aiohttp/__init__.py", line 6, in <module> File "/usr/lib/python3.10/site-packages/aiohttp/client.py", line 88, in <module> File "/usr/lib/python3.10/site-packages/aiohttp/tracing.py", line 5, in <module>
ModuleNotFoundError: No module named 'aiosignal'

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

When was this introduced? Do we need to backport this to 2021.02.x / 2021.11.x?

Looks like it's required for aiohttp v3.8.0 and newer, so we shouldn't need to backport.

Ok, great. It is quite helpful to mention such things in the commit messages.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot