Change the order of g_free(info) and tracepoint
PATCH 1/1 Change the order of g_free(info) and tracepoint
Fixes Coverity issue:
CID 1436126: Memory - illegal accesses (USE_AFTER_FREE)
Fixes a9e271ec9b36 ("vfio: Add migration region initialization and finalize
function")
Signed-off-by Kirti Wankhede <[email protected]>
--- hw/vfio/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/vfio/migration.c +1 -1
@@ -897,8 +897,8 @@ int vfio_migration_probe(VFIODevice *vbasedev, Error **errp) goto add_blocker; } -g_free (info);trace_vfio_migration_probe (vbasedev->name, info->index); +g_free (info);return 0 ; add_blocker:
Signature · 1 line
2.7.0
Quoted 7 lines · Kirti Wankhede
Fixes Coverity issue:
CID 1436126: Memory - illegal accesses (USE_AFTER_FREE)Fixes a9e271ec9b36 ("vfio: Add migration region initialization and finalizefunction")
Signed-off-by Kirti Wankhede <[email protected]>
Maybe "fix use after free in vfio_migration_probe" as a summary?
Reviewed-by David Edmondson <[email protected]>
Quoted 20 lines
--- hw/vfio/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/vfio/migration.c +1
-1@@ -897,8 +897,8 @@ int vfio_migration_probe(VFIODevice *vbasedev, Error **errp) goto add_blocker; } -g_free (info);trace_vfio_migration_probe (vbasedev->name, info->index); +g_free (info);return 0 ; add_blocker:Signature · 1 line
2.7.0
dme.
Signature · 1 line
I think I waited too long, I'm moving into the dollhouse.
Philippe Mathieu-Daudé
Reviewed-byQuoted 11 lines · David Edmondson
Quoted 7 lines · Kirti Wankhede
Fixes Coverity issue:
CID 1436126: Memory - illegal accesses (USE_AFTER_FREE)Fixes a9e271ec9b36 ("vfio: Add migration region initialization and finalizefunction")
Signed-off-by Kirti Wankhede <[email protected]>Maybe "fix use after free in
vfio_migration_probe" as a summary?
Yes please :)
Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Quoted 26 lines
Reviewed-by David Edmondson <[email protected]>Quoted 20 lines
--- hw/vfio/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/vfio/migration.c +1
-1@@ -897,8 +897,8 @@ int vfio_migration_probe(VFIODevice *vbasedev, Error **errp) goto add_blocker; } -g_free (info);trace_vfio_migration_probe (vbasedev->name, info->index); +g_free (info);return 0 ; add_blocker:Signature · 1 line
2.7.0dme.
Quoted 7 lines · Kirti Wankhede
Fixes Coverity issue:
CID 1436126: Memory - illegal accesses (USE_AFTER_FREE)Fixes a9e271ec9b36 ("vfio: Add migration region initialization and finalizefunction")
Signed-off-by Kirti Wankhede <[email protected]>
Reviewed-by Alex Bennée <[email protected]>
Signature · 1 line
Alex Bennée