package/collectd: add config option for lua
PATCH 1/1 package/collectd: add config option for lua
--- package/collectd/Config.in | 7 +++++++ package/collectd/collectd.mk | 9 ++------- 2 files changed, 9 insertions(+), 7 deletions(-)
package/collectd/Config.in +7 -0
@@ -63,6 +63,13 @@ config BR2_PACKAGE_COLLECTD_LOGSTASH help Writes log messages formatted as logstash JSON events. +config BR2_PACKAGE_COLLECTD_LUA + bool "lua" + select BR2_PACKAGE_LUA + help + Embeds a Lua interpreter into collectd and provides an + interface to collectd's plugin system. + config BR2_PACKAGE_COLLECTD_NOTIFY_EMAIL bool "notify_email" depends on !BR2_STATIC_LIBS # libesmtp
package/collectd/collectd.mk +2 -7
@@ -89,6 +89,7 @@ COLLECTD_CONF_OPTS += \ $(if $(BR2_PACKAGE_COLLECTD_LOAD),--enable-load,--disable-load) \ $(if $(BR2_PACKAGE_COLLECTD_LOGFILE),--enable-logfile,--disable-logfile) \ $(if $(BR2_PACKAGE_COLLECTD_LOGSTASH),--enable-log_logstash,--disable-log_logstash) \ + $(if $(BR2_PACKAGE_COLLECTD_LUA),--enable-lua,--disable-lua) \ $(if $(BR2_PACKAGE_COLLECTD_LVM),--enable-lvm,--disable-lvm) \ $(if $(BR2_PACKAGE_COLLECTD_MD),--enable-md,--disable-md) \ $(if $(BR2_PACKAGE_COLLECTD_MEMCACHEC),--enable-memcachec,--disable-memcachec) \
@@ -162,6 +163,7 @@ COLLECTD_DEPENDENCIES = \ $(if $(BR2_PACKAGE_COLLECTD_GRPC),grpc) \ $(if $(BR2_PACKAGE_COLLECTD_IPTABLES),iptables) \ $(if $(BR2_PACKAGE_COLLECTD_LOGSTASH),yajl) \ + $(if $(BR2_PACKAGE_COLLECTD_LUA),lua) \ $(if $(BR2_PACKAGE_COLLECTD_LVM),lvm2) \ $(if $(BR2_PACKAGE_COLLECTD_MEMCACHEC),libmemcached) \ $(if $(BR2_PACKAGE_COLLECTD_MODBUS),libmodbus) \
@@ -213,13 +215,6 @@ else COLLECTD_CONF_OPTS += --with-libgcrypt=no endif -ifeq ($(BR2_PACKAGE_LUA),y) -COLLECTD_DEPENDENCIES += lua -COLLECTD_CONF_OPTS += --enable-lua -else -COLLECTD_CONF_OPTS += --disable-lua -endif - define COLLECTD_INSTALL_TARGET_CMDS $(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install rm -f $(TARGET_DIR)/usr/bin/collectd-nagios
Signature · 1 line
2.17.1
PATCH 1/1 package/collectd: add config option for lua
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Tom" == Tom Marcuzzi <[email protected]> writes:
Signed-off-by Tom Marcuzzi <[email protected]>
Why? What is wrong with the automatic dependency?
Quoted 64 lines
--- package/collectd/Config.in | 7 +++++++ package/collectd/collectd.mk | 9 ++------- 2 files changed, 9 insertions(+), 7 deletions(-)package/collectd/Config.in +7
-0@@ -63,6 +63,13 @@ config BR2_PACKAGE_COLLECTD_LOGSTASH help Writes log messages formatted as logstash JSON events. +config BR2_PACKAGE_COLLECTD_LUA + bool "lua" + select BR2_PACKAGE_LUA + help + Embeds a Lua interpreter into collectd and provides an + interface to collectd's plugin system. + config BR2_PACKAGE_COLLECTD_NOTIFY_EMAIL bool "notify_email" depends on !BR2_STATIC_LIBS # libesmtppackage/collectd/collectd.mk +2
-7@@ -89,6 +89,7 @@ COLLECTD_CONF_OPTS += \ $(if $(BR2_PACKAGE_COLLECTD_LOAD),--enable-load,--disable-load) \ $(if $(BR2_PACKAGE_COLLECTD_LOGFILE),--enable-logfile,--disable-logfile) \ $(if $(BR2_PACKAGE_COLLECTD_LOGSTASH),--enable-log_logstash,--disable-log_logstash) \ + $(if $(BR2_PACKAGE_COLLECTD_LUA),--enable-lua,--disable-lua) \ $(if $(BR2_PACKAGE_COLLECTD_LVM),--enable-lvm,--disable-lvm) \ $(if $(BR2_PACKAGE_COLLECTD_MD),--enable-md,--disable-md) \ $(if $(BR2_PACKAGE_COLLECTD_MEMCACHEC),--enable-memcachec,--disable-memcachec) \@@ -162,6 +163,7 @@ COLLECTD_DEPENDENCIES = \ $(if $(BR2_PACKAGE_COLLECTD_GRPC),grpc) \ $(if $(BR2_PACKAGE_COLLECTD_IPTABLES),iptables) \ $(if $(BR2_PACKAGE_COLLECTD_LOGSTASH),yajl) \ + $(if $(BR2_PACKAGE_COLLECTD_LUA),lua) \ $(if $(BR2_PACKAGE_COLLECTD_LVM),lvm2) \ $(if $(BR2_PACKAGE_COLLECTD_MEMCACHEC),libmemcached) \ $(if $(BR2_PACKAGE_COLLECTD_MODBUS),libmodbus) \@@ -213,13 +215,6 @@ else COLLECTD_CONF_OPTS += --with-libgcrypt=no endif -ifeq ($(BR2_PACKAGE_LUA),y) -COLLECTD_DEPENDENCIES += lua -COLLECTD_CONF_OPTS += --enable-lua -else -COLLECTD_CONF_OPTS += --disable-lua -endif - define COLLECTD_INSTALL_TARGET_CMDS $(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install rm -f $(TARGET_DIR)/usr/bin/collectd-nagiosSignature · 6 lines
2.17.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 package/collectd: add config option for lua
Hi Peter,
Quoted 6 lines · Peter Korsgaard
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Tom" == Tom Marcuzzi <[email protected]> writes:
Signed-off-by Tom Marcuzzi <[email protected]>Why? What is wrong with the automatic dependency?
It is not that there is anything wrong with the automatic dependency, but in my humble opinion adding the lua option may be a more logical way of doing in regards to the other collectd plugins, since every implemented plugin has a configuration option. This gives more flexibility and is more explicit since the user can choose himself whether he wants the plugin or not, which is not the case with the automatic dependency.
Quoted 65 lines
Quoted 60 lines
--- package/collectd/Config.in | 7 +++++++ package/collectd/collectd.mk | 9 ++------- 2 files changed, 9 insertions(+), 7 deletions(-)package/collectd/Config.in +7
-0@@ -63,6 +63,13 @@ config BR2_PACKAGE_COLLECTD_LOGSTASH help Writes log messages formatted as logstash JSON events. +config BR2_PACKAGE_COLLECTD_LUA + bool "lua" + select BR2_PACKAGE_LUA + help + Embeds a Lua interpreter into collectd and provides an + interface to collectd's plugin system. + config BR2_PACKAGE_COLLECTD_NOTIFY_EMAIL bool "notify_email" depends on !BR2_STATIC_LIBS # libesmtppackage/collectd/collectd.mk +2
-8@@ -89,6 +89,7 @@ COLLECTD_CONF_OPTS += \ $(if $(BR2_PACKAGE_COLLECTD_LOAD),--enable-load,--disable-load) \ $(if $(BR2_PACKAGE_COLLECTD_LOGFILE),--enable-logfile,--disable-logfile) \ $(if $(BR2_PACKAGE_COLLECTD_LOGSTASH),--enable-log_logstash,--disable-log_logstash) \ + $(if $(BR2_PACKAGE_COLLECTD_LUA),--enable-lua,--disable-lua) \ $(if $(BR2_PACKAGE_COLLECTD_LVM),--enable-lvm,--disable-lvm) \ $(if $(BR2_PACKAGE_COLLECTD_MD),--enable-md,--disable-md) \ $(if $(BR2_PACKAGE_COLLECTD_MEMCACHEC),--enable-memcachec,--disable-memcachec) \@@ -162,6 +163,7 @@ COLLECTD_DEPENDENCIES = \ $(if $(BR2_PACKAGE_COLLECTD_GRPC),grpc) \ $(if $(BR2_PACKAGE_COLLECTD_IPTABLES),iptables) \ $(if $(BR2_PACKAGE_COLLECTD_LOGSTASH),yajl) \ + $(if $(BR2_PACKAGE_COLLECTD_LUA),lua) \ $(if $(BR2_PACKAGE_COLLECTD_LVM),lvm2) \ $(if $(BR2_PACKAGE_COLLECTD_MEMCACHEC),libmemcached) \ $(if $(BR2_PACKAGE_COLLECTD_MODBUS),libmodbus) \@@ -213,13 +215,6 @@ else COLLECTD_CONF_OPTS += --with-libgcrypt=no endif -ifeq ($(BR2_PACKAGE_LUA),y) -COLLECTD_DEPENDENCIES += lua -COLLECTD_CONF_OPTS += --enable-lua -else -COLLECTD_CONF_OPTS += --disable-lua -endif - define COLLECTD_INSTALL_TARGET_CMDS $(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install rm -f $(TARGET_DIR)/usr/bin/collectd-nagios --2.17.1
Quoted 4 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Quoted 5 lines
--
Bye, Peter Korsgaard
ATTENTION: This email came from an external source.
Do not open attachments or click on links from unknown senders or unexpected emails.
Regards,
Tom Marcuzzi
PATCH 1/1 package/collectd: add config option for lua
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Tom" == Tom Marcuzzi <[email protected]> writes:
Hi Peter,
Quoted 6 lines · Peter Korsgaard
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Tom" == Tom Marcuzzi <[email protected]> writes:
Signed-off-by Tom Marcuzzi <[email protected]>Why? What is wrong with the automatic dependency?
Quoted 7 lines
It is not that there is anything wrong with the automatic dependency, but in my humble opinion adding the lua option may be a more logical way of doing in regards to the other collectd plugins, since every implemented plugin has a configuration option. This gives more flexibility and is more explicit since the user can choose himself whether he wants the plugin or not, which is not the case with the automatic dependency.
But if your system has collectd and lua enabled, what would the reason be to not enable lua support in collectd? How much extra size does this add to collectd?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 package/collectd: add config option for lua
Quoted 19 lines · Peter Korsgaard
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Tom" == Tom Marcuzzi <[email protected]> writes:
Hi Peter,
Quoted 6 lines · Peter Korsgaard
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Tom" == Tom Marcuzzi <[email protected]> writes:
Signed-off-by Tom Marcuzzi <[email protected]>Why? What is wrong with the automatic dependency?
Quoted 7 lines
It is not that there is anything wrong with the automatic dependency, but in my humble opinion adding the lua option may be a more logical way of doing in regards to the other collectd plugins, since every implemented plugin has a configuration option. This gives more flexibility and is more explicit since the user can choose himself whether he wants the plugin or not, which is not the case with the automatic dependency.
Quoted 3 lines
But if your system has collectd and lua enabled, what would the reason be to not enable lua support in collectd? How much extra size does this add to collectd?
It adds on my system around 18KB. I agree that the reason not to enable lua support may be unclear. My patch is more about consistency, in regard to what has been done before for the previous plugins, which are not enabled by default.
Regards,
Tom Marcuzzi
PATCH 1/1 package/collectd: add config option for lua
In reply to Tom MarcuzziQuoted 5 lines · On Mon, 27 Jan 2020 17:28:15 +0000 Tom Marcuzzi <[email protected]> wrote:
Signed-off-by Tom Marcuzzi <[email protected]>--- package/collectd/Config.in | 7 +++++++ package/collectd/collectd.mk | 9 ++------- 2 files changed, 9 insertions(+), 7 deletions(-)
I've applied, after extending the commit log. I discussed this with Peter Korsgaard, and while we normally prefer automatic dependencies, collected indeed has lots of sub-options for its different features, so it kind of made sense to do the same for Lua.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com