new builtin kernel with entropy for the test infra
cover new builtin kernel with entropy for the test infra
Hello,
This small series adds a new builtin kernel image to the test infra. It contains the VirtIORNG driver so the target will have enough entropy at startup, a requirement for more and more packages being tested.
It also uses this new builtin kernel to speed-up some test cases (atop, syslog-ng, python-crossbar, python-nacl) and fix others (python-txtorcon, python-treq).
The binaries I used can be found here [1] and have this version string:
Quoted 1 line
Linux version 4.19.16 (br-user at runner-ed2dce3a-project-3755559-concurrent-0) (gcc version 4.9.4 (Buildroot 2017.08-git-01078-g95b1dae)) #1 Fri Aug 2 23:05:09 UTC 2019
One can see a complete run of "-runtime-tests" before [2] and after [3] this series in the URLs below.
In order to provide a v1 of this series, I created a naming convention for the artifacts and also for the string passed to emulator.py in parameter "kernel". It was the first naming that came to mind, so of course it is open to suggestions/improvements.
[1] https://gitlab.com/RicardoMartincoski/buildroot/commit/2ed44c7471cf5db246b592e24e9b2cfd69702f0f
[2] https://gitlab.com/RicardoMartincoski/buildroot/pipelines/74501223
[3] https://gitlab.com/RicardoMartincoski/buildroot/pipelines/74516103
Regards,
Ricardo
---
Cc: Arnout Vandecappelle <[email protected]>
Cc: Peter Korsgaard <[email protected]>
Cc: Romain Naour <[email protected]>
Cc: Thomas Petazzoni <[email protected]>
Ricardo Martincoski (4):
support/testing: add builtin armv5 kernel 4.19 with entropy support/testing: test syslog-ng with builtin kernel support/testing: test python-* with builtin kernel support/testing: test atop with builtin kernel
.../conf/syslog-ng-kernel-fragment.config | 3 -- support/testing/infra/emulator.py | 10 ++++++ support/testing/tests/package/test_atop.py | 35 ++++++++++--------- support/testing/tests/package/test_python.py | 2 +- .../tests/package/test_python_crossbar.py | 2 -- .../tests/package/test_python_pynacl.py | 4 --- .../testing/tests/package/test_syslog_ng.py | 20 +++-------- 7 files changed, 33 insertions(+), 43 deletions(-) delete mode 100644 support/testing/conf/syslog-ng-kernel-fragment.config
Signature · 1 line
2.17.1
PATCH 1/4 support/testing: add builtin armv5 kernel 4.19 with entropy
More and more packages being tested by the test infra, e.g. syslog-ng, need entropy at startup, usually reading from /dev/random.
Some test cases can also depend on a kernel version newer than the builtin ones already provided by the test infra:
- 3.11.0 for armv5;
- 4.0.0 for armv7.
Add a new builtin kernel to be used by such test cases.
Add it for armv5 so most test cases that switch to use this kernel can keep using BASIC_TOOLCHAIN_CONFIG.
Use the same kernel version and kernel config as qemu_arm_versatile plus HW_RANDOM_VIRTIO for VirtIORNG to be usable.
Copy the actual binary file from the syslog-ng runtime test at current master @ 29e1cb8884.
Since there is already a 'kernel-versatile' file and we must keep it with this name for reproducibility purposes, create a simple naming convention for newer builtin kernel images and dtb files:
kernel-<defconfig>-<kernel_series_version> <dtb_name>-<kernel_series_version>.dtb
Pass '-device virtio-rng-pci' to qemu when this kernel is used.
--- support/testing/infra/emulator.py | 10 ++++++++++ 1 file changed, 10 insertions(+)
support/testing/infra/emulator.py +10 -0
@@ -63,6 +63,16 @@ class Emulator(object): kernel = infra.download(self.downloaddir, "kernel-versatile") qemu_cmd += ["-M", "versatilepb"] + elif kernel == "builtin-4.19": + if arch == "armv5": + kernel_cmdline.append("console=ttyAMA0") + kernel = infra.download(self.downloaddir, + "kernel-versatile-4.19") + dtb = infra.download(self.downloaddir, + "versatile-pb-4.19.dtb") + qemu_cmd += ["-dtb", dtb] + qemu_cmd += ["-M", "versatilepb"] + qemu_cmd += ["-device", "virtio-rng-pci"] qemu_cmd += ["-kernel", kernel]
Signature · 1 line
2.17.1
PATCH 1/4 support/testing: add builtin armv5 kernel 4.19 with entropy
Quoted 41 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Ricardo" == Ricardo Martincoski <[email protected]> writes:
More and more packages being tested by the test infra, e.g. syslog-ng, need entropy at startup, usually reading from
/dev/random.Some test cases can also depend on a kernel version newer than the builtin ones already provided by the test infra:
- 3.11.0 for armv5;
- 4.0.0 for armv7.Add a new builtin kernel to be used by such test cases.
Add it for armv5 so most test cases that switch to use this kernel can keep usingBASIC_TOOLCHAIN_CONFIG.
Use the same kernel version and kernel config asqemu_arm_versatileplusHW_RANDOM_VIRTIOfor VirtIORNG to be usable.
Copy the actual binary file from the syslog-ng runtime test at current master @29e1cb8884.
Since there is already a 'kernel-versatile' file and we must keep it with this name for reproducibility purposes, create a simple naming convention for newer builtin kernel images and dtb files:
kernel-<defconfig>-<kernel_series_version> <dtb_name>-<kernel_series_version>.dtb
Pass '-device virtio-rng-pci' to qemu when this kernel is used.Signed-off-by Ricardo Martincoski <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Peter Korsgaard <[email protected]>Cc Romain Naour <[email protected]>Cc Thomas Petazzoni <[email protected]>--- support/testing/infra/emulator.py | 10 ++++++++++ 1 file changed, 10 insertions(+)support/testing/infra/emulator.py +0
-0@@ -63,6 +63,16 @@ class Emulator(object): kernel = infra.download(self.downloaddir, "kernel-versatile") qemu_cmd += ["-M", "versatilepb"]
support/testing/infra/emulator.py class Emulator(object): · line 75
Quoted 10 lines
support/testing/infra/emulator.py +10
-0+ elif kernel == "builtin-4.19": + if arch == "armv5": + kernel_cmdline.append("console=ttyAMA0") + kernel = infra.download(self.downloaddir, + "kernel-versatile-4.19") + dtb = infra.download(self.downloaddir, + "versatile-pb-4.19.dtb") + qemu_cmd += ["-dtb", dtb] + qemu_cmd += ["-M", "versatilepb"] + qemu_cmd += ["-device", "virtio-rng-pci"]
Committed after changing the logic to use this for builtin/armv5 instead, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/4 support/testing: add builtin armv5 kernel 4.19 with entropy
Hi Peter,
Quoted 46 lines · Peter Korsgaard
Quoted 46 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Ricardo" == Ricardo Martincoski <[email protected]> writes:
More and more packages being tested by the test infra, e.g. syslog-ng, need entropy at startup, usually reading from
/dev/random.Some test cases can also depend on a kernel version newer than the builtin ones already provided by the test infra:
- 3.11.0 for armv5;
- 4.0.0 for armv7.Add a new builtin kernel to be used by such test cases.
Add it for armv5 so most test cases that switch to use this kernel can keep usingBASIC_TOOLCHAIN_CONFIG.
Use the same kernel version and kernel config asqemu_arm_versatileplusHW_RANDOM_VIRTIOfor VirtIORNG to be usable.
Copy the actual binary file from the syslog-ng runtime test at current master @29e1cb8884.
Since there is already a 'kernel-versatile' file and we must keep it with this name for reproducibility purposes, create a simple naming convention for newer builtin kernel images and dtb files:
kernel-<defconfig>-<kernel_series_version> <dtb_name>-<kernel_series_version>.dtb
Pass '-device virtio-rng-pci' to qemu when this kernel is used.Signed-off-by Ricardo Martincoski <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Peter Korsgaard <[email protected]>Cc Romain Naour <[email protected]>Cc Thomas Petazzoni <[email protected]>--- support/testing/infra/emulator.py | 10 ++++++++++ 1 file changed, 10 insertions(+)support/testing/infra/emulator.py +5
-0@@ -63,6 +63,16 @@ class Emulator(object): kernel = infra.download(self.downloaddir, "kernel-versatile") qemu_cmd += ["-M", "versatilepb"] + elif kernel == "builtin-4.19": + if arch == "armv5": + kernel_cmdline.append("console=ttyAMA0") + kernel = infra.download(self.downloaddir, + "kernel-versatile-4.19")
Quoted 8 lines
support/testing/infra/emulator.py class Emulator(object): · line 75
Quoted 5 lines
support/testing/infra/emulator.py +5
-0+ dtb = infra.download(self.downloaddir, + "versatile-pb-4.19.dtb") + qemu_cmd += ["-dtb", dtb] + qemu_cmd += ["-M", "versatilepb"] + qemu_cmd += ["-device", "virtio-rng-pci"]Committed after changing the logic to use this for builtin/armv5 instead, thanks.
Could you backport this to 2019.02.x? Lots of runtime tests are still failing
due to timeout in 2019.02.6 [1] and I think that would be fixed with this commit.
Regards,
Arnout
[1] https://gitlab.com/buildroot.org/buildroot/pipelines/86342478
(take a long time to load!)
PATCH 1/4 support/testing: add builtin armv5 kernel 4.19 with entropy
Quoted 55 lines · Arnout Vandecappelle
Hi Peter,
Quoted 52 lines · Peter Korsgaard
Quoted 51 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Ricardo" == Ricardo Martincoski <[email protected]> writes:
More and more packages being tested by the test infra, e.g. syslog-ng, need entropy at startup, usually reading from
/dev/random.Some test cases can also depend on a kernel version newer than the builtin ones already provided by the test infra:
- 3.11.0 for armv5;
- 4.0.0 for armv7.Add a new builtin kernel to be used by such test cases.
Add it for armv5 so most test cases that switch to use this kernel can keep usingBASIC_TOOLCHAIN_CONFIG.
Use the same kernel version and kernel config asqemu_arm_versatileplusHW_RANDOM_VIRTIOfor VirtIORNG to be usable.
Copy the actual binary file from the syslog-ng runtime test at current master @29e1cb8884.
Since there is already a 'kernel-versatile' file and we must keep it with this name for reproducibility purposes, create a simple naming convention for newer builtin kernel images and dtb files:
kernel-<defconfig>-<kernel_series_version> <dtb_name>-<kernel_series_version>.dtb
Pass '-device virtio-rng-pci' to qemu when this kernel is used.Signed-off-by Ricardo Martincoski <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Peter Korsgaard <[email protected]>Cc Romain Naour <[email protected]>Cc Thomas Petazzoni <[email protected]>--- support/testing/infra/emulator.py | 10 ++++++++++ 1 file changed, 10 insertions(+)support/testing/infra/emulator.py +10
-0@@ -63,6 +63,16 @@ class Emulator(object): kernel = infra.download(self.downloaddir, "kernel-versatile") qemu_cmd += ["-M", "versatilepb"] + elif kernel == "builtin-4.19": + if arch == "armv5": + kernel_cmdline.append("console=ttyAMA0") + kernel = infra.download(self.downloaddir, + "kernel-versatile-4.19") + dtb = infra.download(self.downloaddir, + "versatile-pb-4.19.dtb") + qemu_cmd += ["-dtb", dtb] + qemu_cmd += ["-M", "versatilepb"] + qemu_cmd += ["-device", "virtio-rng-pci"]
Quoted 5 lines
Quoted 2 lines
Committed after changing the logic to use this for builtin/armv5 instead, thanks.
Could you backport this to 2019.02.x? Lots of runtime tests are still failing
due to timeout in 2019.02.6 [1] and I think that would be fixed with this commit.
Sorry, my bad, those timeouts were actually due to agents that didn't work
properly. But still, 2019.02.5 [2] has some issues that I think would be fixed by this commit (e.g. [3]).
Regards,
Arnout
Quoted 7 lines
Regards,
Arnout[1] https://gitlab.com/buildroot.org/buildroot/pipelines/86342478
(take a long time to load!)
[2] https://gitlab.com/buildroot.org/buildroot/pipelines/79837452/failures
(failures only loads a lot quicker :-)
[3] https://gitlab.com/buildroot.org/buildroot/-/jobs/285867504
PATCH 2/4 support/testing: test syslog-ng with builtin kernel
In reply to Ricardo MartincoskiUse the new builtin kernel 4.19 with VirtIORNG to provide entropy to test syslog-ng.
--- .../conf/syslog-ng-kernel-fragment.config | 3 --- .../testing/tests/package/test_syslog_ng.py | 20 ++++--------------- 2 files changed, 4 insertions(+), 19 deletions(-) delete mode 100644 support/testing/conf/syslog-ng-kernel-fragment.config
support/testing/conf/syslog-ng-kernel-fragment.config deleted +0 -3
@@ -1,3 +0,0 @@ -CONFIG_HW_RANDOM=y -CONFIG_HW_RANDOM_VIRTIO=y -CONFIG_VIRTIO_PCI=y
support/testing/tests/package/test_syslog_ng.py +4 -16
@@ -6,29 +6,17 @@ import infra.basetest class TestSyslogNg(infra.basetest.BRTest): config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \ """ - BR2_LINUX_KERNEL=y - BR2_LINUX_KERNEL_CUSTOM_VERSION=y - BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16" - BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y - BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/arm-versatile/linux.config" - BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="{}" - BR2_LINUX_KERNEL_DTS_SUPPORT=y - BR2_LINUX_KERNEL_INTREE_DTS_NAME="versatile-pb" BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y BR2_PACKAGE_SYSLOG_NG=y BR2_TARGET_ROOTFS_CPIO=y # BR2_TARGET_ROOTFS_TAR is not set - """.format(infra.filepath("conf/syslog-ng-kernel-fragment.config")) + """ def test_run(self): - kernel = os.path.join(self.builddir, "images", "zImage") cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio") - dtb = os.path.join(self.builddir, "images", "versatile-pb.dtb") - options = ["-M", "versatilepb", - "-dtb", dtb, - "-initrd", cpio_file, - "-device", "virtio-rng-pci"] - self.emulator.boot(arch="armv5", kernel=kernel, options=options) + self.emulator.boot(arch="armv5", + kernel="builtin-4.19", + options=["-initrd", cpio_file]) self.emulator.login() cmd = "grep syslog-ng /var/log/messages | grep starting"
Signature · 1 line
2.17.1
PATCH 2/4 support/testing: test syslog-ng with builtin kernel
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Ricardo" == Ricardo Martincoski <[email protected]> writes:
Use the new builtin kernel 4.19 with VirtIORNG to provide entropy to test syslog-ng.
Signed-off-by Ricardo Martincoski <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 3/4 support/testing: test python-* with builtin kernel
In reply to Ricardo MartincoskiUse the new builtin kernel 4.19 with VirtIORNG to provide entropy to test all python packages by default.
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/264508536
https://gitlab.com/buildroot.org/buildroot/-/jobs/264508537
https://gitlab.com/buildroot.org/buildroot/-/jobs/264508542
https://gitlab.com/buildroot.org/buildroot/-/jobs/264508543
The workaround of adding haveged to the image is not needed anymore, so remove it from the python-crossbar and python-nacl test.
--- support/testing/tests/package/test_python.py | 2 +- support/testing/tests/package/test_python_crossbar.py | 2 -- support/testing/tests/package/test_python_pynacl.py | 4 ---- 3 files changed, 1 insertion(+), 7 deletions(-)
support/testing/tests/package/test_python.py +1 -1
@@ -14,7 +14,7 @@ class TestPythonBase(infra.basetest.BRTest): def login(self): cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio") self.emulator.boot(arch="armv5", - kernel="builtin", + kernel="builtin-4.19", options=["-initrd", cpio_file]) self.emulator.login()
support/testing/tests/package/test_python_crossbar.py +0 -2
@@ -3,12 +3,10 @@ from tests.package.test_python import TestPythonPackageBase class TestPythonPy3Crossbar(TestPythonPackageBase): __test__ = True - # use haveged to generate enough entropy so crossbar -> pynacl -> libsodium don't hang waiting for /dev/random config = TestPythonPackageBase.config + \ """ BR2_PACKAGE_PYTHON3=y BR2_PACKAGE_PYTHON_CROSSBAR=y - BR2_PACKAGE_HAVEGED=y """ sample_scripts = ["tests/package/sample_python_crossbar.py"] timeout = 60
support/testing/tests/package/test_python_pynacl.py +0 -4
@@ -3,12 +3,10 @@ from tests.package.test_python import TestPythonPackageBase class TestPythonPy2Pynacl(TestPythonPackageBase): __test__ = True - # use haveged to generate enough entropy so pynacl -> libsodium don't hang waiting for /dev/random config = TestPythonPackageBase.config + \ """ BR2_PACKAGE_PYTHON=y BR2_PACKAGE_PYTHON_PYNACL=y - BR2_PACKAGE_HAVEGED=y """ sample_scripts = ["tests/package/sample_python_pynacl.py"] timeout = 10
@@ -16,12 +14,10 @@ class TestPythonPy2Pynacl(TestPythonPackageBase): class TestPythonPy3Pynacl(TestPythonPackageBase): __test__ = True - # use haveged to generate enough entropy so pynacl -> libsodium don't hang waiting for /dev/random config = TestPythonPackageBase.config + \ """ BR2_PACKAGE_PYTHON3=y BR2_PACKAGE_PYTHON_PYNACL=y - BR2_PACKAGE_HAVEGED=y """ sample_scripts = ["tests/package/sample_python_pynacl.py"] timeout = 10
Signature · 1 line
2.17.1
PATCH 3/4 support/testing: test python-* with builtin kernel
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Ricardo" == Ricardo Martincoski <[email protected]> writes:
Use the new builtin kernel 4.19 with VirtIORNG to provide entropy to test all python packages by default.
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/264508536
https://gitlab.com/buildroot.org/buildroot/-/jobs/264508537
https://gitlab.com/buildroot.org/buildroot/-/jobs/264508542
https://gitlab.com/buildroot.org/buildroot/-/jobs/264508543
Quoted 5 lines
The workaround of adding haveged to the image is not needed anymore, so remove it from the python-crossbar and python-nacl test.
Signed-off-by Ricardo Martincoski <[email protected]>Cc Thomas Petazzoni <[email protected]>
Reworded somewhat now that we are still using "builtin" for the new kernel and committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 4/4 support/testing: test atop with builtin kernel
In reply to Ricardo MartincoskiUse the new builtin kernel 4.19 to test atop.
The atop package cannot be tested using BASIC_TOOLCHAIN_CONFIG because it needs kernel headers >= 3.14. So use an updated version of it, copying the config fragment from support/config-fragments/autobuild/br-arm-full.config
--- support/testing/tests/package/test_atop.py | 35 +++++++++++----------- 1 file changed, 18 insertions(+), 17 deletions(-)
support/testing/tests/package/test_atop.py +18 -17
@@ -2,33 +2,34 @@ import os import infra.basetest +BASIC_TOOLCHAIN_CONFIG_HEADERS_AT_LEAST_3_14 = \ + """ + BR2_arm=y + BR2_TOOLCHAIN_EXTERNAL=y + BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y + BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y + BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2019.05.1.tar.bz2" + BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y + BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_14=y + BR2_TOOLCHAIN_EXTERNAL_LOCALE=y + # BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set + BR2_TOOLCHAIN_EXTERNAL_CXX=y + """ + class TestAtop(infra.basetest.BRTest): - config = \ + config = BASIC_TOOLCHAIN_CONFIG_HEADERS_AT_LEAST_3_14 + \ """ - BR2_arm=y - BR2_cortex_a9=y - BR2_ARM_ENABLE_NEON=y - BR2_ARM_ENABLE_VFP=y - BR2_TOOLCHAIN_EXTERNAL=y - BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0" - BR2_SYSTEM_DHCP="eth0" - BR2_LINUX_KERNEL=y - BR2_LINUX_KERNEL_CUSTOM_VERSION=y - BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.16.7" - BR2_LINUX_KERNEL_DEFCONFIG="vexpress" - BR2_LINUX_KERNEL_DTS_SUPPORT=y - BR2_LINUX_KERNEL_INTREE_DTS_NAME="vexpress-v2p-ca9" BR2_PACKAGE_ATOP=y BR2_TARGET_ROOTFS_CPIO=y # BR2_TARGET_ROOTFS_TAR is not set """ def test_run(self): - kernel = os.path.join(self.builddir, "images", "zImage") cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio") - dtb = os.path.join(self.builddir, "images", "vexpress-v2p-ca9.dtb") - self.emulator.boot(arch="armv7", kernel=kernel, options=["-initrd", cpio_file, "-M", "vexpress-a9", "-dtb", dtb]) + self.emulator.boot(arch="armv5", + kernel="builtin-4.19", + options=["-initrd", cpio_file]) self.emulator.login() cmd = "atop -V | grep '^Version'"
Signature · 1 line
2.17.1
PATCH 4/4 support/testing: test atop with builtin kernel
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Ricardo" == Ricardo Martincoski <[email protected]> writes:
Use the new builtin kernel 4.19 to test atop.
The atop package cannot be tested usingBASIC_TOOLCHAIN_CONFIGbecause it needs kernel headers >= 3.14. So use an updated version of it, copying the config fragment fromsupport/config-fragments/autobuild/br-arm-full.configSigned-off-by Ricardo Martincoski <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
cover new builtin kernel with entropy for the test infra
In reply to Ricardo MartincoskiHello,
Quoted 14 lines · On Sat, 3 Aug 2019 02:22:12 -0300 Ricardo Martincoski…
This small series adds a new builtin kernel image to the test infra. It contains the VirtIORNG driver so the target will have enough entropy at startup, a requirement for more and more packages being tested.
It also uses this new builtin kernel to speed-up some test cases (atop, syslog-ng, python-crossbar, python-nacl) and fix others (python-txtorcon, python-treq).
The binaries I used can be found here [1] and have this version string:
Quoted 1 line
Linux version 4.19.16 (br-user at runner-ed2dce3a-project-3755559-concurrent-0) (gcc version 4.9.4 (Buildroot 2017.08-git-01078-g95b1dae)) #1 Fri Aug 2 23:05:09 UTC 2019
One can see a complete run of "-runtime-tests" before [2] and after [3] this series in the URLs below.
Quoted 8 lines
In order to provide a v1 of this series, I created a naming convention for the artifacts and also for the string passed to
emulator.pyin parameter "kernel". It was the first naming that came to mind, so of course it is open to suggestions/improvements.[1] https://gitlab.com/RicardoMartincoski/buildroot/commit/2ed44c7471cf5db246b592e24e9b2cfd69702f0f
[2] https://gitlab.com/RicardoMartincoski/buildroot/pipelines/74501223
[3] https://gitlab.com/RicardoMartincoski/buildroot/pipelines/74516103
Thanks a lot for working on this. However, instead of having this new kernel as a separate "version" from the current ARMv5 pre-built kernel, why don't we simply update the existing one ?
One issue is that downloads get cached, so if the filename is the same, it won't be redownloaded. Perhaps we need to store hashes of the download artifacts, so that we can detect if they need to be re-downloaded ?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
cover new builtin kernel with entropy for the test infra
Quoted 24 lines · Thomas Petazzoni
Hello,
Quoted 19 lines · On Sat, 3 Aug 2019 02:22:12 -0300 Ricardo Martincoski…
This small series adds a new builtin kernel image to the test infra. It contains the VirtIORNG driver so the target will have enough entropy at startup, a requirement for more and more packages being tested.
It also uses this new builtin kernel to speed-up some test cases (atop, syslog-ng, python-crossbar, python-nacl) and fix others (python-txtorcon, python-treq).
The binaries I used can be found here [1] and have this version string:
Quoted 1 line
Linux version 4.19.16 (br-user at runner-ed2dce3a-project-3755559-concurrent-0) (gcc version 4.9.4 (Buildroot 2017.08-git-01078-g95b1dae)) #1 Fri Aug 2 23:05:09 UTC 2019
One can see a complete run of "-runtime-tests" before [2] and after [3] this series in the URLs below.
In order to provide a v1 of this series, I created a naming convention for the artifacts and also for the string passed to
emulator.pyin parameter "kernel". It was the first naming that came to mind, so of course it is open to suggestions/improvements.
Quoted 7 lines
Quoted 3 lines
[1] https://gitlab.com/RicardoMartincoski/buildroot/commit/2ed44c7471cf5db246b592e24e9b2cfd69702f0f
[2] https://gitlab.com/RicardoMartincoski/buildroot/pipelines/74501223
[3] https://gitlab.com/RicardoMartincoski/buildroot/pipelines/74516103Thanks a lot for working on this. However, instead of having this new kernel as a separate "version" from the current ARMv5 pre-built kernel, why don't we simply update the existing one ?
IMO it's rarely a good idea to overwrite an existing file that can be
downloaded. So I'd apply Ricardo's patches as is.
Regards,
Arnout
Quoted 10 lines
One issue is that downloads get cached, so if the filename is the same, it won't be redownloaded. Perhaps we need to store hashes of the download artifacts, so that we can detect if they need to be re-downloaded ?
Best regards,
Thomas
cover new builtin kernel with entropy for the test infra
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle <[email protected]> writes:
Thanks a lot for working on this. However, instead of having this new kernel as a separate "version" from the current ARMv5 pre-built kernel, why don't we simply update the existing one ?
IMO it's rarely a good idea to overwrite an existing file that can be
downloaded. So I'd apply Ricardo's patches as is.
Still, it would be good to use this new kernel for builtin / armv5 - But Ok, that can be fixed when applying.
Signature · 1 line
Bye, Peter Korsgaard