Skip to contentSkip to conversation

ath10k: work around uninitialized vht_pfr variable

PATCH In review Arnd Bergmann 4 participants 6 messages Jul 8, 2019 – Jul 15, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: work around uninitialized vht_pfr variable

As clang points out, the vht_pfr is assigned to a struct member without being initialized in one case:

drivers/net/wireless/ath/ath10k/mac.c:7528:7: error: variable 'vht_pfr' is used uninitialized whenever 'if' condition
is false [-Werror,-Wsometimes-uninitialized]
if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/mac.c:7551:20: note: uninitialized use occurs here

                arvif->vht_pfr = vht_pfr;
                                 ^~~~~~~

drivers/net/wireless/ath/ath10k/mac.c:7528:3: note: remove the 'if' if its condition is always true
if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/mac.c:7483:12: note: initialize the variable 'vht_pfr' to silence this warning

        u8 vht_pfr;

Add an explicit but probably incorrect initialization here. I suspect we want a better fix here, but chose this approach to illustrate the issue.

Fixes 8b97b055dc9d ("ath10k: fix failure to set multiple fixed rate")
---
 drivers/net/wireless/ath/ath10k/mac.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/ath/ath10k/mac.c +2 -0
index e43a566eef77..0606416dc971 100644
@@ -7541,6 +7541,8 @@ static int ath10k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw,
 								&vht_nss,
 								true);
 			update_bitrate_mask = false;
+		} else {
+			vht_pfr = 0;
 		}
 
 		mutex_lock(&ar->conf_mutex);
Signature · 7 lines
2.20.0


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Arnd Bergmann

As clang points out, the vht_pfr is assigned to a struct member without being initialized in one case:

drivers/net/wireless/ath/ath10k/mac.c:7528:7: error: variable 'vht_pfr' is used uninitialized whenever 'if' condition
is false [-Werror,-Wsometimes-uninitialized]
if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/mac.c:7551:20: note: uninitialized use occurs here

                arvif->vht_pfr = vht_pfr;
                                 ^~~~~~~

drivers/net/wireless/ath/ath10k/mac.c:7528:3: note: remove the 'if' if its condition is always true
if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/mac.c:7483:12: note: initialize the variable 'vht_pfr' to silence this warning

Quoted 5 lines
        u8 vht_pfr;

Add an explicit but probably incorrect initialization here. I suspect we want a better fix here, but chose this approach to illustrate the issue.

Yup, I reached out to the maintainers when this issue first cropped up, should have taken your approach though.

https://lore.kernel.org/lkml/20190702181837.GA118849@archlinux-epyc/

Initializing to zero is better than uninitialized.

Quoted 3 lines
Fixes 8b97b055dc9d ("ath10k: fix failure to set multiple fixed rate")

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k

#2 lore raw
In reply to Arnd Bergmann

Hi Arnd,

Quoted 32 lines · Arnd Bergmann

As clang points out, the vht_pfr is assigned to a struct member without being initialized in one case:

drivers/net/wireless/ath/ath10k/mac.c:7528:7: error: variable 'vht_pfr' is used uninitialized whenever 'if' condition
is false [-Werror,-Wsometimes-uninitialized]
if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/mac.c:7551:20: note: uninitialized use occurs here

                arvif->vht_pfr = vht_pfr;
                                 ^~~~~~~

drivers/net/wireless/ath/ath10k/mac.c:7528:3: note: remove the 'if' if its condition is always true
if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/mac.c:7483:12: note: initialize the variable 'vht_pfr' to silence this warning

        u8 vht_pfr;

Add an explicit but probably incorrect initialization here. I suspect we want a better fix here, but chose this approach to illustrate the issue.

Fixes 8b97b055dc9d ("ath10k: fix failure to set multiple fixed rate")
---
 drivers/net/wireless/ath/ath10k/mac.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/ath/ath10k/mac.c +0 -0
index e43a566eef77..0606416dc971 100644

drivers/net/wireless/ath/ath10k/mac.c static int ath10k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw, · line 7542

Quoted 2 lines
drivers/net/wireless/ath/ath10k/mac.c +0 -0
@@ -7541,6 +7541,8 @@ static int ath10k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw,
                                                                &vht_nss,
                                                                true);

^^ Technically, this call to ath10k_mac_bitrate_mask_get_single_rate() can fail to assign 'vht_pfr' as well. I can't immediately tell whether it provably will never hit the -EINVAL case, but if we do, then you'd have another uninitialized case.

I *believe* it shouldn't fail, since we already pre-checked the VHT MCS lists for "exactly 1" rate. But it still seems like better code to pre-initialize and/or add error-handling, so we don't rely on that implicit proof.

I'm not quite sure yet what the "better" answer should be for resolving this, but at a minimum, I think the above could be improved.

Brian

Quoted 9 lines
drivers/net/wireless/ath/ath10k/mac.c +2 -1
                        update_bitrate_mask = false;
+               } else {
+                       vht_pfr = 0;
                }
 
                mutex_lock(&ar->conf_mutex);
--

2.20.0

#3 lore raw
In reply to Arnd Bergmann
Quoted 14 lines · Arnd Bergmann

As clang points out, the vht_pfr is assigned to a struct member without being initialized in one case:

drivers/net/wireless/ath/ath10k/mac.c:7528:7: error: variable 'vht_pfr' is used uninitialized whenever 'if' condition
is false [-Werror,-Wsometimes-uninitialized]
if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/mac.c:7551:20: note: uninitialized use occurs here

                arvif->vht_pfr = vht_pfr;
                                 ^~~~~~~

drivers/net/wireless/ath/ath10k/mac.c:7528:3: note: remove the 'if' if its condition is always true
if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/mac.c:7483:12: note: initialize the variable 'vht_pfr' to silence this warning

Quoted 8 lines
        u8 vht_pfr;

Add an explicit but probably incorrect initialization here. I suspect we want a better fix here, but chose this approach to illustrate the issue.

Fixes 8b97b055dc9d ("ath10k: fix failure to set multiple fixed rate")

I'll queue this for v5.3.

Signature · 6 lines
Kalle Valo

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#4 lore raw
In reply to Arnd Bergmann
Quoted 16 lines · Arnd Bergmann

As clang points out, the vht_pfr is assigned to a struct member without being initialized in one case:

drivers/net/wireless/ath/ath10k/mac.c:7528:7: error: variable 'vht_pfr' is used uninitialized whenever 'if' condition
is false [-Werror,-Wsometimes-uninitialized]
if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/mac.c:7551:20: note: uninitialized use occurs here

                arvif->vht_pfr = vht_pfr;
                                 ^~~~~~~

drivers/net/wireless/ath/ath10k/mac.c:7528:3: note: remove the 'if' if its condition is always true
if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/mac.c:7483:12: note: initialize the variable 'vht_pfr' to silence this warning

        u8 vht_pfr;
Quoted 7 lines

Add an explicit but probably incorrect initialization here. I suspect we want a better fix here, but chose this approach to illustrate the issue.

Fixes 8b97b055dc9d ("ath10k: fix failure to set multiple fixed rate")

Patch applied to wireless-drivers.git, thanks.

ff414f31ce37 ath10k: work around uninitialized vht_pfr variable

Signature · 9 lines
https://patchwork.kernel.org/patch/11034993/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#5 lore raw
In reply to Arnd Bergmann
Quoted 16 lines · Arnd Bergmann

As clang points out, the vht_pfr is assigned to a struct member without being initialized in one case:

drivers/net/wireless/ath/ath10k/mac.c:7528:7: error: variable 'vht_pfr' is used uninitialized whenever 'if' condition
is false [-Werror,-Wsometimes-uninitialized]
if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/mac.c:7551:20: note: uninitialized use occurs here

                arvif->vht_pfr = vht_pfr;
                                 ^~~~~~~

drivers/net/wireless/ath/ath10k/mac.c:7528:3: note: remove the 'if' if its condition is always true
if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/mac.c:7483:12: note: initialize the variable 'vht_pfr' to silence this warning

        u8 vht_pfr;
Quoted 7 lines

Add an explicit but probably incorrect initialization here. I suspect we want a better fix here, but chose this approach to illustrate the issue.

Fixes 8b97b055dc9d ("ath10k: fix failure to set multiple fixed rate")

Patch applied to wireless-drivers.git, thanks.

ff414f31ce37 ath10k: work around uninitialized vht_pfr variable

Signature · 3 lines
https://patchwork.kernel.org/patch/11034993/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches