Skip to contentSkip to conversation

dante: disable pam

PATCH New Fabrice Fontaine 3 participants 7 messages Nov 22, 2018 – Dec 3, 2018

lore
Share & tools
lore

Fabrice Fontaine

author
#0 lore raw

PATCH 1/2 dante: disable pam

Fixes:
- http://autobuild.buildroot.org/results/5222592f2052e18c184fae42214c112e7f39be6e

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/dante/dante.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/dante/dante.mk +1 -1
index 687567e100..a147aa36dc 100644
@@ -12,7 +12,7 @@ DANTE_LICENSE_FILES = LICENSE
 # Dante uses a *VERY* old configure.ac
 DANTE_LIBTOOL_PATCH = NO
 
-DANTE_CONF_OPTS += --disable-client --disable-preload
+DANTE_CONF_OPTS += --disable-client --disable-preload --without-pam
 
 define DANTE_INSTALL_CONFIG_FILE
 	$(INSTALL) -D -m 644 $(@D)/example/sockd.conf \
Signature · 1 line
2.14.1
author
#1 lore raw

PATCH 2/2 dante: add linux-pam optional dependency

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/dante/dante.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
package/dante/dante.mk +8 -1
index a147aa36dc..9666ec54fd 100644
@@ -12,7 +12,14 @@ DANTE_LICENSE_FILES = LICENSE
 # Dante uses a *VERY* old configure.ac
 DANTE_LIBTOOL_PATCH = NO
 
-DANTE_CONF_OPTS += --disable-client --disable-preload --without-pam
+DANTE_CONF_OPTS += --disable-client --disable-preload
+
+ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
+DANTE_DEPENDENCIES += linux-pam
+DANTE_CONF_OPTS += --with-pam
+else
+DANTE_CONF_OPTS += --without-pam
+endif
 
 define DANTE_INSTALL_CONFIG_FILE
 	$(INSTALL) -D -m 644 $(@D)/example/sockd.conf \
Signature · 1 line
2.14.1
Applied
#2 lore raw

PATCH 2/2 dante: add linux-pam optional dependency

Hello,

Quoted 4 lines · Fabrice Fontaine
Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/dante/dante.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Applied to next after cherry-picking PATCH 1/2 from master to next.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Applied
#3 lore raw

PATCH 1/2 dante: disable pam

In reply to Fabrice Fontaine

Hello,

Quoted 7 lines · Fabrice Fontaine

Fixes:
- http://autobuild.buildroot.org/results/5222592f2052e18c184fae42214c112e7f39be6e

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/dante/dante.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/2 dante: disable pam

In reply to Fabrice Fontaine

Hello Fabrice,

Quoted 2 lines · Fabrice Fontaine

Fixes:
- http://autobuild.buildroot.org/results/5222592f2052e18c184fae42214c112e7f39be6e

It seems like it doesn't fix the problem. The following build result:

http://autobuild.buildroot.net/results/e37e61bae1d81a7956e2843be70fea84b0bbb64b/

has been built from the master branch at commit d81870ae8129389a62df80c9c8c9165d334b6921, which includes your fix, and still the same libpam related failure happened.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#5 lore raw

PATCH 1/2 dante: disable pam

Dear Thomas,

Le lun. 26 nov. 2018 ? 08:49, Thomas Petazzoni <[email protected]> a ?crit :

Quoted 7 lines

Hello Fabrice,

Quoted 2 lines · Fabrice Fontaine

Fixes:
-

http://autobuild.buildroot.org/results/5222592f2052e18c184fae42214c112e7f39be6e

Quoted 9 lines

It seems like it doesn't fix the problem. The following build result:

http://autobuild.buildroot.net/results/e37e61bae1d81a7956e2843be70fea84b0bbb64b/

has been built from the master branch at commit d81870ae8129389a62df80c9c8c9165d334b6921, which includes your fix, and still the same libpam related failure happened.

Yes, I saw it.I have an other patch to fix this issue in one of the dante's m4 file but Yann's patch on autoreconf must be applied first.

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice

Quoted 2 lines

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181126/f2b8627b/attachment.html>