Skip to contentSkip to conversation

mt76x0: build driver only as module

PATCH In review Stanislaw Gruszka 2 participants 5 messages Aug 3, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mt76x0: build driver only as module

There are various symbols that conflicts with mt7601u. Due to that kernel will not build with allyesconfig. For now limit the driver to be build only as module.

---
 drivers/net/wireless/mediatek/mt76/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/mediatek/mt76/Kconfig +1 -1
index 850611ad347a..2f25af9a08df 100644
@@ -11,7 +11,7 @@ config MT76x2_COMMON
 
 config MT76x0U
 	tristate "MediaTek MT76x0U (USB) support"
-	depends on MAC80211
+	depends on MAC80211 && m
 	depends on USB
 	help
 	  This adds support for MT7610U-based wireless USB dongles.
Signature · 1 line
2.7.5
#1 lore raw
Quoted 5 lines · Stanislaw Gruszka

There are various symbols that conflicts with mt7601u. Due to that kernel will not build with allyesconfig. For now limit the driver to be build only as module.

Thanks for the quick patch!

drivers/net/wireless/mediatek/mt76/Kconfig config MT76x2_COMMON · line 14

Quoted 8 lines
drivers/net/wireless/mediatek/mt76/Kconfig +1 -1
@@ -11,7 +11,7 @@ config MT76x2_COMMON
 
 config MT76x0U
 	tristate "MediaTek MT76x0U (USB) support"
-	depends on MAC80211
+	depends on MAC80211 && m

But this feels like an ugly hack to me. Isn't there a better way to fix this? (I don't have time to investigate the error in detail right now.)

Signature · 1 line
Kalle Valo
#2 lore raw
Quoted 14 lines · Kalle Valo
Quoted 5 lines · Stanislaw Gruszka

There are various symbols that conflicts with mt7601u. Due to that kernel will not build with allyesconfig. For now limit the driver to be build only as module.

Thanks for the quick patch!

Quoted 4 lines
drivers/net/wireless/mediatek/mt76/Kconfig +0 -0
@@ -11,7 +11,7 @@ config MT76x2_COMMON
 
Quoted 7 lines

drivers/net/wireless/mediatek/mt76/Kconfig config MT76x2_COMMON · line 14

Quoted 4 lines
drivers/net/wireless/mediatek/mt76/Kconfig +1 -1
 config MT76x0U
 	tristate "MediaTek MT76x0U (USB) support"
-	depends on MAC80211
+	depends on MAC80211 && m

But this feels like an ugly hack to me. Isn't there a better way to fix this? (I don't have time to investigate the error in detail right now.)

Yes, rename symbols names. And I will do this, just wanted to provide quick fix for the problem.

Moreover seems the same thing should be done for mt7601u to avoid build errors and perhaps with mt76 :-(

So I'm going to rename functions.

Regards
Stanislaw

#3 lore raw
Quoted 10 lines · Stanislaw Gruszka
Quoted 2 lines

But this feels like an ugly hack to me. Isn't there a better way to fix this? (I don't have time to investigate the error in detail right now.)

Yes, rename symbols names. And I will do this, just wanted to provide quick fix for the problem.

Moreover seems the same thing should be done for mt7601u to avoid build errors and perhaps with mt76 :-(

So I'm going to rename functions.

I have the patches, I'm building kernel with allyesconfig now, it will take a while ...

Stanislaw

#4 lore raw
Quoted 7 lines · Stanislaw Gruszka
Quoted 6 lines · Stanislaw Gruszka
Quoted 2 lines

But this feels like an ugly hack to me. Isn't there a better way to fix this? (I don't have time to investigate the error in detail right now.)

Yes, rename symbols names. And I will do this, just wanted to provide quick fix for the problem.

Quoted 7 lines
Quoted 4 lines

Moreover seems the same thing should be done for mt7601u to avoid build errors and perhaps with mt76 :-(

So I'm going to rename functions.

I have the patches, I'm building kernel with allyesconfig now, it will take a while ...

I'm now hoping to send the pull request tomorrow, so if you can submit a proper patch some time today that would be good.

Signature · 1 line
Kalle Valo