Skip to contentSkip to conversation

wine: Drop glibc requirement

PATCH New André Hentschel 2 participants 3 messages Mar 9, 2018 – Mar 15, 2018

lore
Share & tools
lore

André Hentschel

author
#0 lore raw

PATCH 1/1 wine: Drop glibc requirement

I noticed it's not needed anymore, musl went upstream at some point and uClibc is now build with bessel functions:
https://git.buildroot.net/buildroot/commit/package/uclibc?id=de56d58e5d26d78161ca3b7a1a2a4decfe4e89db

Signed-off-by Andr? Hentschel <[email protected]>
---
 package/wine/Config.in | 6 ------
 1 file changed, 6 deletions(-)
package/wine/Config.in +0 -6
index c674288..627a9a7 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_WINE
 	bool "wine"
-	depends on BR2_TOOLCHAIN_USES_GLIBC
 	# Wine only builds on certain architectures
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" || \
 	           BR2_HOSTARCH = "powerpc" || BR2_HOSTARCH = "arm" || \

@@ -16,8 +15,3 @@ config BR2_PACKAGE_WINE
 	  methods.
 
 	  http://www.winehq.org
-
-comment "wine needs a glibc toolchain"
-	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
-	depends on BR2_i386
-	depends on !BR2_TOOLCHAIN_USES_GLIBC
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 wine: Drop glibc requirement

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Andr?" == Andr? Hentschel <[email protected]> writes:

I noticed it's not needed anymore, musl went upstream at some point and uClibc is now build with bessel functions:
https://git.buildroot.net/buildroot/commit/package/uclibc?id=de56d58e5d26d78161ca3b7a1a2a4decfe4e89db

Signed-off-by Andr? Hentschel <[email protected]>

Committed, thanks.

Have you verified that E.G. a static only uClibc configuration works? test-pkg is handy for such checks.

Signature · 1 line
Bye, Peter Korsgaard
author
#2 lore raw

PATCH 1/1 wine: Drop glibc requirement

Am 11.03.2018 um 22:25 schrieb Peter Korsgaard:

Quoted 5 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Andr?" == Andr? Hentschel <[email protected]> writes:

I noticed it's not needed anymore, musl went upstream at some point and uClibc is now build with bessel functions:
https://git.buildroot.net/buildroot/commit/package/uclibc?id=de56d58e5d26d78161ca3b7a1a2a4decfe4e89db

Quoted 7 lines
Quoted 1 line
Signed-off-by Andr? Hentschel <[email protected]>

Committed, thanks.

Have you verified that E.G. a static only uClibc configuration works? test-pkg is handy for such checks.

Hi,

Thanks!
In fact Wine has multiple issues with static only, I'll send a patch