mx6: wandboard: reenable SPL build

PATCH New Heinrich Schuchardt 4 participants 7 messages Dec 9, 2017 – Dec 17, 2017

lore

Share & tools

lore

Heinrich Schuchardt

author

2017-12-09 16:01 UTC #0 lore raw

PATCH 1/1 mx6: wandboard: reenable SPL build

The last merge from the u-boot-imx tree deleted a necessary line from wandboard_defconfig by mistake.

This caused an error when running

make wandboard_defconfig
make SPL

Fixes 6e6cf015e7cd Merge git://www.denx.de/git/u-boot-imx

Signed-off-by Heinrich Schuchardt <[email protected]>

---
 configs/wandboard_defconfig | 1 +
 1 file changed, 1 insertion(+)

configs/wandboard_defconfig +1 -0

index 4b6b9d9aaee..0e1f1f4a376 100644
@@ -11,6 +11,7 @@ CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_CMD_HDMIDETECT=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd"
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg"
 # CONFIG_CONSOLE_MUX is not set
 CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y

Signature · 1 line

2.11.0

Fabio Estevam

2017-12-09 16:04 UTC #1 lore raw

PATCH 1/1 mx6: wandboard: reenable SPL build

Quoted 10 lines · Heinrich Schuchardt

The last merge from the u-boot-imx tree deleted a necessary line from wandboard_defconfig by mistake.
This caused an error when running
make wandboard_defconfig
make SPL
Fixes 6e6cf015e7cd Merge git://www.denx.de/git/u-boot-imx
Signed-off-by Heinrich Schuchardt <[email protected]>

Thanks for the fix:

Reviewed-by Fabio Estevam <[email protected]>

Vagrant Cascadian

2017-12-11 22:01 UTC #2 lore raw

PATCH 1/1 mx6: wandboard: reenable SPL build

In reply to Heinrich Schuchardt

Quoted 11 lines · Heinrich Schuchardt

The last merge from the u-boot-imx tree deleted a necessary line from wandboard_defconfig by mistake.
This caused an error when running
make wandboard_defconfig
make SPL
Fixes 6e6cf015e7cd Merge git://www.denx.de/git/u-boot-imx
Signed-off-by Heinrich Schuchardt <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>

This is essentially identical to the patch I submitted a couple days ago, so:

Tested-by Vagrant Cascadian <[email protected]>

live well,
vagrant

Quoted 9 lines

---
 configs/wandboard_defconfig | 1 +
 1 file changed, 1 insertion(+)

configs/wandboard_defconfig +0 -0

index 4b6b9d9aaee..0e1f1f4a376 100644

configs/wandboard_defconfig CONFIG_SPL_WATCHDOG_SUPPORT=y · line 17

Quoted 7 lines

configs/wandboard_defconfig +1 -0

@@ -11,6 +11,7 @@ CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_CMD_HDMIDETECT=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd"
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg"
 # CONFIG_CONSOLE_MUX is not set
 CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171211/5fce671f/attachment.sig>

Heinrich Schuchardt

author

2017-12-17 08:45 UTC #3 lore raw

[U-Boot] Please, pull: [U-Boot, 1/1] mx6: wandboard: reenable SPL build

Quoted 6 lines · Vagrant Cascadian

Quoted 5 lines · Heinrich Schuchardt
The last merge from the u-boot-imx tree deleted a necessary line from wandboard_defconfig by mistake.
This caused an error when running

Quoted 8 lines

Quoted 6 lines
make wandboard_defconfig
make SPL
Fixes 6e6cf015e7cd Merge git://www.denx.de/git/u-boot-imx
Signed-off-by Heinrich Schuchardt <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>
This is essentially identical to the patch I submitted a couple days

https://patchwork.ozlabs.org/patch/845403/
https://lists.denx.de/pipermail/u-boot/2017-December/313851.html

Quoted 6 lines

ago, so:
Tested-by Vagrant Cascadian <[email protected]>
live well,
vagrant

Hello Tom, hello Stefano

could you, please, pull this correction of the Nov 27th imx merge into the next release candidate.

Best regards

Heinrich Schuchardt

Quoted 17 lines

---
 configs/wandboard_defconfig | 1 +
 1 file changed, 1 insertion(+)

configs/wandboard_defconfig +1 -0

index 4b6b9d9aaee..0e1f1f4a376 100644
@@ -11,6 +11,7 @@ CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_CMD_HDMIDETECT=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd"
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg"
 # CONFIG_CONSOLE_MUX is not set
 CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y

Stefano Babic

2017-12-17 10:07 UTC #4 lore raw

[U-Boot] Please, pull: [U-Boot, 1/1] mx6: wandboard: reenable SPL build

Hi Heinrich,

Quoted 23 lines · Heinrich Schuchardt

Quoted 6 lines · Vagrant Cascadian
Quoted 5 lines · Heinrich Schuchardt
The last merge from the u-boot-imx tree deleted a necessary line from wandboard_defconfig by mistake.
This caused an error when running
Quoted 8 lines
Quoted 6 lines
make wandboard_defconfig
make SPL
Fixes 6e6cf015e7cd Merge git://www.denx.de/git/u-boot-imx
Signed-off-by Heinrich Schuchardt <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>
This is essentially identical to the patch I submitted a couple days
https://patchwork.ozlabs.org/patch/845403/
https://lists.denx.de/pipermail/u-boot/2017-December/313851.html
Quoted 4 lines
ago, so:
Tested-by Vagrant Cascadian <[email protected]>

Quoted 8 lines

Quoted 2 lines
live well,
vagrant
Hello Tom, hello Stefano
could you, please, pull this correction of the Nov 27th imx merge into the next release candidate.

I have already pushed Vagrant's in my test branch. It will be part of next PR.

Regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Heinrich Schuchardt

author

2017-12-17 10:23 UTC #5 lore raw

[U-Boot] Please, pull: [U-Boot, 1/1] mx6: wandboard: reenable SPL build

Quoted 35 lines · Stefano Babic

Hi Heinrich,
Quoted 23 lines · Heinrich Schuchardt
Quoted 6 lines · Vagrant Cascadian
Quoted 5 lines · Heinrich Schuchardt
The last merge from the u-boot-imx tree deleted a necessary line from wandboard_defconfig by mistake.
This caused an error when running
Quoted 8 lines
Quoted 6 lines
make wandboard_defconfig
make SPL
Fixes 6e6cf015e7cd Merge git://www.denx.de/git/u-boot-imx
Signed-off-by Heinrich Schuchardt <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>
This is essentially identical to the patch I submitted a couple days
https://patchwork.ozlabs.org/patch/845403/
https://lists.denx.de/pipermail/u-boot/2017-December/313851.html
Quoted 4 lines
ago, so:
Tested-by Vagrant Cascadian <[email protected]>
Quoted 8 lines
Quoted 2 lines
live well,
vagrant
Hello Tom, hello Stefano
could you, please, pull this correction of the Nov 27th imx merge into the next release candidate.

Quoted 6 lines

I have already pushed Vagrant's in my test branch. It will be part of next PR.
Regards,
Stefano Babic

Thanks.

I thought git://git.denx.de/u-boot-imx.git was where you consolidate patches as mentioned in MAINTAINERS.

I couldn't find Vagrants patch in any of the branches.

Best regards

Heinrich

Fabio Estevam

2017-12-17 12:28 UTC #6 lore raw

[U-Boot] Please, pull: [U-Boot, 1/1] mx6: wandboard: reenable SPL build

Hi Heinrich,

Quoted 4 lines · Heinrich Schuchardt

I thought git://git.denx.de/u-boot-imx.git was where you consolidate patches as mentioned in MAINTAINERS.
I couldn't find Vagrants patch in any of the branches.

It is here:
http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=91db6710b10c2728c80d71c5481d824c7602a7d7;hp=374a6070941b86048f4fcc26e82f0911171abf75

Regards,

Fabio Estevam