Skip to contentSkip to conversation

drm/i915: Disable GEN9LP decoupled mmio

PATCH In review [email protected] 4 participants 4 messages May 23, 2017

Subsystems (2)
DRM drivers Intel i915
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 drm/i915: Disable GEN9LP decoupled mmio

From: Kai Chen <[email protected]>

This change is used as a backport fix from top of drm-intel ([PATCH] drm/i915: Disable decoupled mmio for GEN9LP) to disable decoupled mmio on GEN9LP for those shipped kernels as a quick fix.

V2:
- Add signed-off-by

Signed-off-by Kai Chen <[email protected]>
---
 drivers/gpu/drm/i915/i915_pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/i915_pci.c +0 -1
index f80db2c..cf43dc1 100644
@@ -385,7 +385,6 @@ static const struct intel_device_info intel_skylake_gt3_info = {
 	.has_gmbus_irq = 1, \
 	.has_logical_ring_contexts = 1, \
 	.has_guc = 1, \
-	.has_decoupled_mmio = 1, \
 	.has_aliasing_ppgtt = 1, \
 	.has_full_ppgtt = 1, \
 	.has_full_48bit_ppgtt = 1, \
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
CI
#1 lore raw

✓ Fi.CI.BAT: success for drm/i915: Disable GEN9LP decoupled mmio (rev2)

== Series Details ==

== Series Details ==

Series: drm/i915: Disable GEN9LP decoupled mmio (rev2)
URL : https://patchwork.freedesktop.org/series/24803/
State : success

== Summary ==

Series 24803v2 drm/i915: Disable GEN9LP decoupled mmio
https://patchwork.freedesktop.org/api/1.0/series/24803/revisions/2/mbox/

Test kms_flip:

        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-WARN (fi-skl-6700hq) fdo#101144
        Subgroup basic-flip-vs-wf_vblank:
                fail       -> PASS       (fi-skl-6770hq) fdo#99739

fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fdo#99739 https://bugs.freedesktop.org/show_bug.cgi?id=99739

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time:436s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time:433s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time:586s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:515s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time:490s
fi-byt-n2820     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:484s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:423s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:409s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time:422s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:492s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:467s
fi-kbl-7500u     total:278  pass:255  dwarn:5   dfail:0   fail:0   skip:18  time:461s
fi-kbl-7560u     total:278  pass:263  dwarn:5   dfail:0   fail:0   skip:10  time:576s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:458s
fi-skl-6700hq    total:278  pass:260  dwarn:1   dfail:0   fail:0   skip:17  time:576s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time:465s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:499s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time:438s
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29  time:408s

fi-snb-2520m failed to collect. IGT log at Patchwork_4780/fi-snb-2520m/igt.log

5c5ce2ab8183e4bd85a603169e260cc938837e2c drm-tip: 2017y-05m-22d-13h-42m-03s UTC integration manifest 51394d1 drm/i915: Disable GEN9LP decoupled mmio

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4780/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
In reply to [email protected]
Quoted 5 lines · On 23/05/2017 01:18, [email protected] wrote:

From: Kai Chen <[email protected]>

This change is used as a backport fix from top of drm-intel ([PATCH] drm/i915: Disable decoupled mmio for GEN9LP) to disable decoupled mmio on GEN9LP for those shipped kernels as a quick fix.

Should we have a more complete commit message for the backportable commit instead? Perhaps copy the one from the full patch, and change it there to refer to this one and explain that it is removing previously disabled code?

For example:

"""
The decoupled mmio feature doesn't work as intended by HW team. Enabling it with forcewake will only make debugging efforts more difficult, so let's disable it.
"""

Quoted 4 lines

V2:
- Add signed-off-by

Signed-off-by Kai Chen <[email protected]>

Adding the dim fixes blob:

Fixes 85ee17ebeedd ("drm/i915/bxt: Broxton decoupled MMIO")
Cc Zhe Wang <[email protected]>
Cc Praveen Paneri <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Jani Nikula <[email protected]>
Cc [email protected]

Regards,

Tvrtko

Quoted 10 lines
---
 drivers/gpu/drm/i915/i915_pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/i915_pci.c +0 -0
index f80db2c..cf43dc1 100644

drivers/gpu/drm/i915/i915_pci.c static const struct intel_device_info intel_skylake_gt3_info = { · line 390

Quoted 7 lines
drivers/gpu/drm/i915/i915_pci.c +0 -1
@@ -385,7 +385,6 @@ static const struct intel_device_info intel_skylake_gt3_info = {
 	.has_gmbus_irq = 1, \
 	.has_logical_ring_contexts = 1, \
 	.has_guc = 1, \
-	.has_decoupled_mmio = 1, \
 	.has_aliasing_ppgtt = 1, \
 	.has_full_ppgtt = 1, \
 	.has_full_48bit_ppgtt = 1, \

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#3 lore raw
Quoted 12 lines · Tvrtko Ursulin
Quoted 5 lines · On 23/05/2017 01:18, [email protected] wrote:

From: Kai Chen <[email protected]>

This change is used as a backport fix from top of drm-intel ([PATCH] drm/i915: Disable decoupled mmio for GEN9LP) to disable decoupled mmio on GEN9LP for those shipped kernels as a quick fix.

Should we have a more complete commit message for the backportable commit instead? Perhaps copy the one from the full patch, and change it there to refer to this one and explain that it is removing previously disabled code?

Quoted 7 lines

For example:

"""
The decoupled mmio feature doesn't work as intended by HW team. Enabling it with forcewake will only make debugging efforts more difficult, so let's disable it.
"""

I want a two-patch series, with this patch here as 1/2, with the dim fixes blob and cc: stable from below, and a proper commit message. Patch 2/2 is the other patch with the dead code removal, on top of this one.

BR,
Jani.

Quoted 9 lines
Quoted 6 lines

V2:
- Add signed-off-by

Signed-off-by Kai Chen <[email protected]>

Adding the dim fixes blob:

Quoted 7 lines
Fixes 85ee17ebeedd ("drm/i915/bxt: Broxton decoupled MMIO")
Cc Zhe Wang <[email protected]>
Cc Praveen Paneri <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Jani Nikula <[email protected]>
Cc [email protected]
Cc <[email protected]> # v4.10+
Quoted 22 lines

Regards,

Tvrtko

Quoted 17 lines
---
 drivers/gpu/drm/i915/i915_pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/i915_pci.c +0 -1
index f80db2c..cf43dc1 100644
@@ -385,7 +385,6 @@ static const struct intel_device_info intel_skylake_gt3_info = {
 	.has_gmbus_irq = 1, \
 	.has_logical_ring_contexts = 1, \
 	.has_guc = 1, \
-	.has_decoupled_mmio = 1, \
 	.has_aliasing_ppgtt = 1, \
 	.has_full_ppgtt = 1, \
 	.has_full_48bit_ppgtt = 1, \
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx