ARM: dts: armada388-clearfog: number LAN ports properly
PATCH 1/1 ARM: dts: armada388-clearfog: number LAN ports properly
Currently, the ports as seen from the rear number as:
eth0 sfp lan5 lan4 lan3 lan2 lan1 lan6
which is illogical - this came about because the rev 2.0 boards have the LEDs on the front for the DSA switch (lan5-1) reversed. Rev 2.1 boards fixed the LED issue, and the Clearfog case numbers the lan ports increasing from left to right.
Maintaining this illogical numbering causes confusion, with reports that "my link isn't coming up" and "my connection negotiates 10base-Half" both of which are due to people thinking that the port next to the SFP is lan1.
Fix this by renumbering the ports to match people's expectations.
--- arch/arm/boot/dts/armada-388-clearfog.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/armada-388-clearfog.dts +4 -4
@@ -386,12 +386,12 @@ port at 0 { reg = <0>; - label = "lan1"; + label = "lan5"; }; port at 1 { reg = <1>; - label = "lan2"; + label = "lan4"; }; port at 2 {
@@ -401,12 +401,12 @@ port at 3 { reg = <3>; - label = "lan4"; + label = "lan2"; }; port at 4 { reg = <4>; - label = "lan5"; + label = "lan1"; }; port at 5 {
Signature · 1 line
2.1.0
PATCH 1/1 ARM: dts: armada388-clearfog: number LAN ports properly
Quoted 9 lines · Russell King
Currently, the ports as seen from the rear number as:
eth0 sfp lan5 lan4 lan3 lan2 lan1 lan6
which is illogical - this came about because the rev 2.0 boards have the LEDs on the front for the DSA switch (lan5-1) reversed. Rev 2.1 boards fixed the LED issue, and the Clearfog case numbers the lan ports increasing from left to right.
Quoted 8 lines
Maintaining this illogical numbering causes confusion, with reports that "my link isn't coming up" and "my connection negotiates 10base-Half" both of which are due to people thinking that the port next to the SFP is lan1.
Fix this by renumbering the ports to match people's expectations.
Signed-off-by Russell King <[email protected]>
Andrew
PATCH 1/1 ARM: dts: armada388-clearfog: number LAN ports properly
Hi,
Quoted 15 lines · Andrew Lunn
Quoted 14 lines · Russell King
Currently, the ports as seen from the rear number as:
eth0 sfp lan5 lan4 lan3 lan2 lan1 lan6
which is illogical - this came about because the rev 2.0 boards have the LEDs on the front for the DSA switch (lan5-1) reversed. Rev 2.1 boards fixed the LED issue, and the Clearfog case numbers the lan ports increasing from left to right.
Maintaining this illogical numbering causes confusion, with reports that "my link isn't coming up" and "my connection negotiates 10base-Half" both of which are due to people thinking that the port next to the SFP is lan1.
Quoted 5 lines
Quoted 3 lines
Fix this by renumbering the ports to match people's expectations.
Signed-off-by Russell King <[email protected]>Reviewed-by Andrew Lunn <[email protected]>
I missed this patch, but I now applied it on mvebu/dt-4.9
Thanks,
Gregory
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 ARM: dts: armada388-clearfog: number LAN ports properly
Quoted 19 lines · Gregory CLEMENT
Hi,
Quoted 15 lines · Andrew Lunn
Quoted 14 lines · Russell King
Currently, the ports as seen from the rear number as:
eth0 sfp lan5 lan4 lan3 lan2 lan1 lan6
which is illogical - this came about because the rev 2.0 boards have the LEDs on the front for the DSA switch (lan5-1) reversed. Rev 2.1 boards fixed the LED issue, and the Clearfog case numbers the lan ports increasing from left to right.
Maintaining this illogical numbering causes confusion, with reports that "my link isn't coming up" and "my connection negotiates 10base-Half" both of which are due to people thinking that the port next to the SFP is lan1.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Fix this by renumbering the ports to match people's expectations.
Signed-off-by Russell King <[email protected]>Reviewed-by Andrew Lunn <[email protected]>I missed this patch, but I now applied it on mvebu/dt-4.9
It would be much better to get it into 4.8-rc so that we don't spread the port renumbering over a large range of kernels, as well as forcing vendors to carry patches like this to fix problems.
Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
PATCH 1/1 ARM: dts: armada388-clearfog: number LAN ports properly
Hi Russell King,
Quoted 24 lines · Russell King - ARM Linux
Quoted 23 lines · Gregory CLEMENT
Hi,
Quoted 19 lines · Andrew Lunn
Quoted 17 lines · Russell King
Currently, the ports as seen from the rear number as:
eth0 sfp lan5 lan4 lan3 lan2 lan1 lan6
which is illogical - this came about because the rev 2.0 boards have the LEDs on the front for the DSA switch (lan5-1) reversed. Rev 2.1 boards fixed the LED issue, and the Clearfog case numbers the lan ports increasing from left to right.
Maintaining this illogical numbering causes confusion, with reports that "my link isn't coming up" and "my connection negotiates 10base-Half" both of which are due to people thinking that the port next to the SFP is lan1.
Fix this by renumbering the ports to match people's expectations.
Signed-off-by Russell King <[email protected]>
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Reviewed-by Andrew Lunn <[email protected]>I missed this patch, but I now applied it on mvebu/dt-4.9
It would be much better to get it into 4.8-rc so that we don't spread the port renumbering over a large range of kernels, as well as forcing vendors to carry patches like this to fix problems.
I can move it to the mvebu/fixes branch, it is not too late. Also what about to apply it on the stable kernel?
Gregory
Quoted 5 lines
Signature · 4 lines
-- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 ARM: dts: armada388-clearfog: number LAN ports properly
Quoted 30 lines · Gregory CLEMENT
Hi Russell King,
Quoted 26 lines · Russell King - ARM Linux
Quoted 25 lines · Gregory CLEMENT
Hi,
Quoted 20 lines · Andrew Lunn
Quoted 9 lines · Russell King
Currently, the ports as seen from the rear number as:
eth0 sfp lan5 lan4 lan3 lan2 lan1 lan6
which is illogical - this came about because the rev 2.0 boards have the LEDs on the front for the DSA switch (lan5-1) reversed. Rev 2.1 boards fixed the LED issue, and the Clearfog case numbers the lan ports increasing from left to right.
Quoted 8 lines
Maintaining this illogical numbering causes confusion, with reports that "my link isn't coming up" and "my connection negotiates 10base-Half" both of which are due to people thinking that the port next to the SFP is lan1.
Fix this by renumbering the ports to match people's expectations.
Signed-off-by Russell King <[email protected]>Reviewed-by Andrew Lunn <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
I missed this patch, but I now applied it on mvebu/dt-4.9
It would be much better to get it into 4.8-rc so that we don't spread the port renumbering over a large range of kernels, as well as forcing vendors to carry patches like this to fix problems.
I can move it to the mvebu/fixes branch, it is not too late. Also what about to apply it on the stable kernel?
That'd probably be best.
As far as stable goes, I can't convince myself that it is really stable kernel material. I'm not aware what happened to the eth* renumber patch, was that applied to stable trees? My view would be that the lan* renumbering should be applied to the same trees which include the eth* renumbering and no further, iff the eth* renumber was even backported.
Talking to Jon Nettleton @ SR, he's in favour of it being applied to stable kernels.
Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.