Skip to contentSkip to conversation

mono: add patch to fix MIPS build issue

PATCH New Thomas Petazzoni 4 participants 5 messages Feb 6, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mono: add patch to fix MIPS build issue

Since the bump to version 3.12 of Mono, it fails to build on MIPS. The patch added by this commit fixes this build failure, simply caused by a missing include.

Fixes:

http://autobuild.buildroot.org/results/6f5/6f5e20a4a99eb0db650430bf6285c844fd940711/

Submitted upstream at https://github.com/mono/mono/pull/1550.

---
 .../0003-mono-context.h-fix-build-on-MIPS.patch    | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/mono/0003-mono-context.h-fix-build-on-MIPS.patch
package/mono/0003-mono-context.h-fix-build-on-MIPS.patch new file +33 -0
new file mode 100644
index 0000000..dab22ce
@@ -0,0 +1,33 @@
+From 8f489c24e1770c2852efcaff9419d54bfadf0854 Mon Sep 17 00:00:00 2001
+From: Thomas Petazzoni <[email protected]>
+Date: Fri, 6 Feb 2015 14:56:10 +0100
+Subject: [PATCH] mono-context.h: fix build on MIPS
+
+The mono-context.h file uses definitions such as mips_fp and mips_sp,
+which are defined in <mono/arch/mips/mips-codegen.h>, but this file is
+not included, leading to build failures.
+
+This fix is similar to 4437ecea91bab3fe68ba1c30521acf75052662cd (for
+ARM).
+
+Signed-off-by: Thomas Petazzoni <[email protected]>
+---
+ mono/utils/mono-context.h | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/mono/utils/mono-context.h b/mono/utils/mono-context.h
+index d96eb75..ad56e2c 100755
+--- a/mono/utils/mono-context.h
++++ b/mono/utils/mono-context.h
+@@ -464,6 +464,8 @@ mono_ia64_context_get_fp (MonoContext *ctx)
+ 
+ #elif ((defined(__mips__) && !defined(MONO_CROSS_COMPILE)) || (defined(TARGET_MIPS))) && SIZEOF_REGISTER == 4 /* defined(__ia64__) */
+ 
++#include <mono/arch/mips/mips-codegen.h>
++
+ typedef struct {
+ 	mgreg_t	    sc_pc;
+ 	mgreg_t		sc_regs [32];
+-- 
+2.1.0
+
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 mono: add patch to fix MIPS build issue

Dear Thomas Petazzoni,

I did a build test for MIPS and I confirm this patch fixes the problem.

$ file output/target/usr/bin/mono-sgen
output/target/usr/bin/mono-sgen: ELF 32-bit MSB executable, MIPS, MIPS32
rel2 version 1 (SYSV), dynamically linked (uses shared libs), for
GNU/Linux 2.6.32, with unknown capability 0x41000000 = 0xf676e75, with
unknown capability 0x10000 = 0x70403, stripped

Thanks.
--
Vincent

#2 lore raw

PATCH 1/1 mono: add patch to fix MIPS build issue

In reply to Thomas Petazzoni

Hello,

Quoted 9 lines · Thomas Petazzoni

Since the bump to version 3.12 of Mono, it fails to build on MIPS. The patch added by this commit fixes this build failure, simply caused by a missing include.

Fixes:

http://autobuild.buildroot.org/results/6f5/6f5e20a4a99eb0db650430bf6285c844fd940711/

Submitted upstream at https://github.com/mono/mono/pull/1550.

The patch has been merged upstream.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 mono: add patch to fix MIPS build issue

Hi Thomas,

Thank you very much for solving this, I had no time to look at the issue. A really big thanks!

Sincerely, Angelo

2015-02-06 16:21 GMT+01:00 Thomas Petazzoni
<[email protected]>:

Quoted 24 lines

Hello,

Quoted 9 lines · Thomas Petazzoni

Since the bump to version 3.12 of Mono, it fails to build on MIPS. The patch added by this commit fixes this build failure, simply caused by a missing include.

Fixes:

http://autobuild.buildroot.org/results/6f5/6f5e20a4a99eb0db650430bf6285c844fd940711/

Submitted upstream at https://github.com/mono/mono/pull/1550.

The patch has been merged upstream.

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
#4 lore raw

PATCH 1/1 mono: add patch to fix MIPS build issue

In reply to Thomas Petazzoni
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Since the bump to version 3.12 of Mono, it fails to build on MIPS. The patch added by this commit fixes this build failure, simply caused by a missing include.

Quoted 7 lines

Fixes:

http://autobuild.buildroot.org/results/6f5/6f5e20a4a99eb0db650430bf6285c844fd940711/

Submitted upstream at https://github.com/mono/mono/pull/1550.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard