Skip to contentSkip to conversation

ftrace: The set_graph_function and set_graph_notrace file mode should be 0644 instead of 0444

PATCH In review Chen LinX 2 participants 2 messages Sep 3, 2014 – Sep 4, 2014

Subsystems (2)
lore
Share & tools
lore

Chen LinX

author
#0 lore raw

PATCH 1/1 ftrace: The set_graph_function and set_graph_notrace file mode should be 0644 instead of 0444

---
 kernel/trace/ftrace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/trace/ftrace.c +2 -2
index 5916a8e..00e7b9a 100644
@@ -4406,10 +4406,10 @@ static __init int ftrace_init_dyn_debugfs(struct dentry *d_tracer)
 	ftrace_create_filter_files(&global_ops, d_tracer);
 
 #ifdef CONFIG_FUNCTION_GRAPH_TRACER
-	trace_create_file("set_graph_function", 0444, d_tracer,
+	trace_create_file("set_graph_function", 0644, d_tracer,
 				    NULL,
 				    &ftrace_graph_fops);
-	trace_create_file("set_graph_notrace", 0444, d_tracer,
+	trace_create_file("set_graph_notrace", 0644, d_tracer,
 				    NULL,
 				    &ftrace_graph_notrace_fops);
 #endif /* CONFIG_FUNCTION_GRAPH_TRACER */
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw

Hi Chen,

Quoted 1 line · Chen LinX

Thanks,
Namhyung

Quoted 21 lines
---
 kernel/trace/ftrace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/trace/ftrace.c +2 -2
index 5916a8e..00e7b9a 100644
@@ -4406,10 +4406,10 @@ static __init int ftrace_init_dyn_debugfs(struct dentry *d_tracer)
 	ftrace_create_filter_files(&global_ops, d_tracer);
 
 #ifdef CONFIG_FUNCTION_GRAPH_TRACER
-	trace_create_file("set_graph_function", 0444, d_tracer,
+	trace_create_file("set_graph_function", 0644, d_tracer,
 				    NULL,
 				    &ftrace_graph_fops);
-	trace_create_file("set_graph_notrace", 0444, d_tracer,
+	trace_create_file("set_graph_notrace", 0644, d_tracer,
 				    NULL,
 				    &ftrace_graph_notrace_fops);
 #endif /* CONFIG_FUNCTION_GRAPH_TRACER */