Skip to contentSkip to conversation

Add Swfdec Free flash library

PATCH New Emmanuel Riou 3 participants 6 messages Sep 25, 2009 – Sep 29, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add Swfdec Free flash library

---
 package/multimedia/Config.in        |    1 +
 package/multimedia/swfdec/Config.in |   27 +++++++++++++++++++++++++++
 package/multimedia/swfdec/swfdec.mk |   32 ++++++++++++++++++++++++++++++++
 3 files changed, 60 insertions(+), 0 deletions(-)
 create mode 100644 package/multimedia/swfdec/Config.in
 create mode 100644 package/multimedia/swfdec/swfdec.mk
package/multimedia/Config.in +1 -0
index c7160a6..49932d0 100644
@@ -21,6 +21,7 @@ source "package/multimedia/madplay/Config.in"
 source "package/multimedia/mpg123/Config.in"
 source "package/multimedia/mplayer/Config.in"
 source "package/multimedia/speex/Config.in"
+source "package/multimedia/swfdec/Config.in"
 source "package/multimedia/festival/Config.in"
 source "package/multimedia/taglib/Config.in"
 source "package/multimedia/vlc/Config.in"
package/multimedia/swfdec/Config.in new file +27 -0
new file mode 100644
index 0000000..e7f191f
@@ -0,0 +1,27 @@
+config BR2_PACKAGE_SWFDEC
+	bool "swfdec"
+	select BR2_PACKAGE_LIBSOUP
+	select BR2_PACKAGE_LIBOIL
+	select BR2_PACKAGE_ALSA_LIB
+	help
+	  Library to play Flash Files
+	  http://swfdec.freedesktop.org/
+
+config BR2_PACKAGE_SWFDEC_GTK
+        bool "swfdec gtk"
+	depends on BR2_PACKAGE_SWFDEC
+	depends on BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_LIBGTK2
+	select BR2_PACKAGE_CAIRO_PNG
+	help
+	  Enables swfdec-gtk  
+
+config BR2_PACKAGE_SWFDEC_GSTREAMER
+        bool "swfdec gstreamer"
+	default y
+	depends on BR2_PACKAGE_SWFDEC	
+	select BR2_PACKAGE_GSTREAMER
+	select BR2_PACKAGE_GST_PLUGINS_BASE
+	help
+	  Enables GStreamer support
+
package/multimedia/swfdec/swfdec.mk new file +32 -0
new file mode 100644
index 0000000..4a80c40
@@ -0,0 +1,32 @@
+#############################################################
+#
+# Swfdec
+#
+#############################################################
+SWFDEC_VERSION_MAJOR:=0.8
+SWFDEC_VERSION_MINOR:=4
+SWFDEC_VERSION = $(SWFDEC_VERSION_MAJOR).$(SWFDEC_VERSION_MINOR)
+
+SWFDEC_SOURCE:=swfdec-$(SWFDEC_VERSION).tar.gz
+SWFDEC_SITE:=http://swfdec.freedesktop.org/download/swfdec/$(SWFDEC_VERSION_MAJOR)
+SWFDEC_LIBTOOL_PATCH = NO
+SWFDEC_INSTALL_STAGING = YES
+SWFDEC_INSTALL_TARGET = YES
+
+SWFDEC_DEPENDENCIES = libsoup liboil alsa-lib ohost-pkgconfig
+
+ifeq ($(BR2_PACKAGE_SWFDEC_GSTREAMER),y)
+SWFDEC_DEPENDENCIES += gstreamer gst-plugins-base
+else
+SWFDEC_CONF_OPT += --disable-gstreamer
+endif
+
+ifeq ($(BR2_PACKAGE_SWFDEC_GTK),y)
+SWFDEC_DEPENDENCIES += libgtk2
+else
+SWFDEC_CONF_OPT += --disable-gtk
+endif
+
+
+
+$(eval $(call AUTOTARGETS,package/multimedia,swfdec))
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 Add Swfdec Free flash library

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Emmanuel" == Emmanuel Riou <[email protected]> writes:

Emmanuel> Signed-off-by: Emmanuel Riou <[email protected]> Emmanuel> ---

Thanks, a few remarks:

Emmanuel> +++ b/package/multimedia/swfdec/Config.in Emmanuel> @@ -0,0 +1,27 @@
Emmanuel> +config BR2_PACKAGE_SWFDEC
Emmanuel> + bool "swfdec"
Emmanuel> + select BR2_PACKAGE_LIBSOUP
Emmanuel> + select BR2_PACKAGE_LIBOIL
Emmanuel> + select BR2_PACKAGE_ALSA_LIB
Emmanuel> + help
Emmanuel> + Library to play Flash Files
Emmanuel> + http://swfdec.freedesktop.org/

We normally have an empty line before the URL.

Emmanuel> +
Emmanuel> +config BR2_PACKAGE_SWFDEC_GTK
Emmanuel> + bool "swfdec gtk"
Emmanuel> + depends on BR2_PACKAGE_SWFDEC
Emmanuel> + depends on BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7
Emmanuel> + select BR2_PACKAGE_LIBGTK2
Emmanuel> + select BR2_PACKAGE_CAIRO_PNG
Emmanuel> + help
Emmanuel> + Enables swfdec-gtk

Indentation is wrong for the depends/select lines (should be <tab>). We normally don't use select for stuff with complicated dependencies like gtk, so I think it would be nicer to simply depen on libgtk2 - Then you can also get rid of the directfb || xorg7 stuff.

You furthermore have trailing spaces in the help text. Maybe the config option and help text should say something like gtk support?

Emmanuel> +
Emmanuel> +config BR2_PACKAGE_SWFDEC_GSTREAMER
Emmanuel> + bool "swfdec gstreamer"
Emmanuel> + default y
Emmanuel> + depends on BR2_PACKAGE_SWFDEC
Emmanuel> + select BR2_PACKAGE_GSTREAMER
Emmanuel> + select BR2_PACKAGE_GST_PLUGINS_BASE
Emmanuel> + help
Emmanuel> + Enables GStreamer support

Same here (identation/trailing spaces). Why should this default to y? (I don't know much about flash) Is swfdec not very useful without gstreamer support?

Emmanuel> +############################################################# Emmanuel> +#
Emmanuel> +# Swfdec
Emmanuel> +#
Emmanuel> +############################################################# Emmanuel> +SWFDEC_VERSION_MAJOR:=0.8
Emmanuel> +SWFDEC_VERSION_MINOR:=4
Emmanuel> +SWFDEC_VERSION = $(SWFDEC_VERSION_MAJOR).$(SWFDEC_VERSION_MINOR) Emmanuel> +
Emmanuel> +SWFDEC_SOURCE:=swfdec-$(SWFDEC_VERSION).tar.gz
Emmanuel> +SWFDEC_SITE:=http://swfdec.freedesktop.org/download/swfdec/$(SWFDEC_VERSION_MAJOR) Emmanuel> +SWFDEC_LIBTOOL_PATCH = NO
Emmanuel> +SWFDEC_INSTALL_STAGING = YES
Emmanuel> +SWFDEC_INSTALL_TARGET = YES

You have a mix of styles here (:= vs =, spaces around =) - Is there any reason for that?

Otherwise it looks good. Care to fix those issues and resubmit?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 Add Swfdec Free flash library

Quoted 6 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Emmanuel" == Emmanuel Riou <[email protected]> writes:

Emmanuel> Signed-off-by: Emmanuel Riou <[email protected]> Emmanuel> ---

Thanks, a few remarks:

Hi! Thanks for your remarks and sorry for the slow reply...

Quoted 12 lines

Emmanuel> +++ b/package/multimedia/swfdec/Config.in Emmanuel> @@ -0,0 +1,27 @@
Emmanuel> +config BR2_PACKAGE_SWFDEC
Emmanuel> + bool "swfdec"
Emmanuel> + select BR2_PACKAGE_LIBSOUP
Emmanuel> + select BR2_PACKAGE_LIBOIL
Emmanuel> + select BR2_PACKAGE_ALSA_LIB
Emmanuel> + help
Emmanuel> + Library to play Flash Files
Emmanuel> + http://swfdec.freedesktop.org/

Quoted 1 line

We normally have an empty line before the URL.

Alright I fixed it.

Quoted 11 lines

Emmanuel> +
Emmanuel> +config BR2_PACKAGE_SWFDEC_GTK
Emmanuel> + bool "swfdec gtk"
Emmanuel> + depends on BR2_PACKAGE_SWFDEC
Emmanuel> + depends on BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7
Emmanuel> + select BR2_PACKAGE_LIBGTK2
Emmanuel> + select BR2_PACKAGE_CAIRO_PNG
Emmanuel> + help
Emmanuel> + Enables swfdec-gtk

Quoted 4 lines

Indentation is wrong for the depends/select lines (should be <tab>). We normally don't use select for stuff with complicated dependencies like gtk, so I think it would be nicer to simply depen on libgtk2 - Then you can also get rid of the directfb || xorg7 stuff.

OK fixed.

Quoted 3 lines

You furthermore have trailing spaces in the help text. Maybe the config option and help text should say something like gtk support?

You're right, it's a bit more verbose now.

Quoted 11 lines

Emmanuel> +
Emmanuel> +config BR2_PACKAGE_SWFDEC_GSTREAMER
Emmanuel> + bool "swfdec gstreamer"
Emmanuel> + default y
Emmanuel> + depends on BR2_PACKAGE_SWFDEC
Emmanuel> + select BR2_PACKAGE_GSTREAMER
Emmanuel> + select BR2_PACKAGE_GST_PLUGINS_BASE
Emmanuel> + help
Emmanuel> + Enables GStreamer support

Quoted 3 lines

Same here (identation/trailing spaces). Why should this default to y? (I don't know much about flash) Is swfdec not very useful without gstreamer support?

I removed the default line. I put it as "default y" because it was needed in my case (not a good reason, I know ;-)). Swfdec relies on Gstreamer for all the audio and video stuff, but it is not mandatory to have it since you can have Flash files without audio nor video.

Quoted 16 lines

Emmanuel> +############################################################# Emmanuel> +#
Emmanuel> +# Swfdec
Emmanuel> +#
Emmanuel> +############################################################# Emmanuel> +SWFDEC_VERSION_MAJOR:=0.8
Emmanuel> +SWFDEC_VERSION_MINOR:=4
Emmanuel> +SWFDEC_VERSION = $(SWFDEC_VERSION_MAJOR).$(SWFDEC_VERSION_MINOR) Emmanuel> +
Emmanuel> +SWFDEC_SOURCE:=swfdec-$(SWFDEC_VERSION).tar.gz
Emmanuel> +SWFDEC_SITE:=http://swfdec.freedesktop.org/download/swfdec/$(SWFDEC_VERSION_MAJOR) Emmanuel> +SWFDEC_LIBTOOL_PATCH = NO
Emmanuel> +SWFDEC_INSTALL_STAGING = YES
Emmanuel> +SWFDEC_INSTALL_TARGET = YES

Quoted 2 lines

You have a mix of styles here (:= vs =, spaces around =) - Is there any reason for that?

Sorry for this inconsistency, it's fixed as well!

Quoted 2 lines

Otherwise it looks good. Care to fix those issues and resubmit?

Thanks, I am resubmitting the patch.

Emmanuel.

Quoted 1 line
#3 lore raw

PATCH 1/1 Add Swfdec Free flash library

Hi,

There is a typo in the Swfdec patch I submitted yesterday. I have just resubmitted another one which fixes the typo (ohost-pkconfig instead of host-pkgconfig), please take this one into account and not the one I sent yesterday.

Kind regards,

Emmanuel.

Quoted 100 lines · Emmanuel Riou
Quoted 6 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Emmanuel" == Emmanuel Riou <[email protected]> writes:

Emmanuel> Signed-off-by: Emmanuel Riou <[email protected]> Emmanuel> ---

Thanks, a few remarks:

Hi! Thanks for your remarks and sorry for the slow reply...

Quoted 9 lines

Emmanuel> +++ b/package/multimedia/swfdec/Config.in Emmanuel> @@ -0,0 +1,27 @@
Emmanuel> +config BR2_PACKAGE_SWFDEC

 Emmanuel> +    bool "swfdec"
 Emmanuel> +    select BR2_PACKAGE_LIBSOUP
 Emmanuel> +    select BR2_PACKAGE_LIBOIL
 Emmanuel> +    select BR2_PACKAGE_ALSA_LIB
 Emmanuel> +    help
Quoted 4 lines

Emmanuel> + Library to play Flash Files
Emmanuel> + http://swfdec.freedesktop.org/

We normally have an empty line before the URL.

Alright I fixed it.

Quoted 9 lines

Emmanuel> +
Emmanuel> +config BR2_PACKAGE_SWFDEC_GTK
Emmanuel> + bool "swfdec gtk"

 Emmanuel> +    depends on BR2_PACKAGE_SWFDEC
 Emmanuel> +    depends on BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7
 Emmanuel> +    select BR2_PACKAGE_LIBGTK2
 Emmanuel> +    select BR2_PACKAGE_CAIRO_PNG
 Emmanuel> +    help
Quoted 5 lines

Emmanuel> + Enables swfdec-gtk
Indentation is wrong for the depends/select lines (should be <tab>). We normally don't use select for stuff with complicated dependencies like gtk, so I think it would be nicer to simply depen on libgtk2 - Then you can also get rid of the directfb || xorg7 stuff.

OK fixed.

Quoted 3 lines

You furthermore have trailing spaces in the help text. Maybe the config option and help text should say something like gtk support?

You're right, it's a bit more verbose now.

Quoted 9 lines

Emmanuel> +
Emmanuel> +config BR2_PACKAGE_SWFDEC_GSTREAMER
Emmanuel> + bool "swfdec gstreamer"

 Emmanuel> +    default y
 Emmanuel> +    depends on BR2_PACKAGE_SWFDEC   
 Emmanuel> +    select BR2_PACKAGE_GSTREAMER
 Emmanuel> +    select BR2_PACKAGE_GST_PLUGINS_BASE
 Emmanuel> +    help
Quoted 5 lines

Emmanuel> + Enables GStreamer support

Same here (identation/trailing spaces). Why should this default to y? (I don't know much about flash) Is swfdec not very useful without gstreamer support?

I removed the default line. I put it as "default y" because it was needed in my case (not a good reason, I know ;-)). Swfdec relies on Gstreamer for all the audio and video stuff, but it is not mandatory to have it since you can have Flash files without audio nor video.

Quoted 15 lines

Emmanuel> +############################################################# Emmanuel> +#
Emmanuel> +# Swfdec
Emmanuel> +#
Emmanuel> +############################################################# Emmanuel> +SWFDEC_VERSION_MAJOR:=0.8
Emmanuel> +SWFDEC_VERSION_MINOR:=4
Emmanuel> +SWFDEC_VERSION =
$(SWFDEC_VERSION_MAJOR).$(SWFDEC_VERSION_MINOR)
Emmanuel> +
Emmanuel> +SWFDEC_SOURCE:=swfdec-$(SWFDEC_VERSION).tar.gz
Emmanuel>
+SWFDEC_SITE:=http://swfdec.freedesktop.org/download/swfdec/$(SWFDEC_VERSION_MAJOR)

Quoted 6 lines

Emmanuel> +SWFDEC_LIBTOOL_PATCH = NO
Emmanuel> +SWFDEC_INSTALL_STAGING = YES
Emmanuel> +SWFDEC_INSTALL_TARGET = YES

You have a mix of styles here (:= vs =, spaces around =) - Is there any reason for that?

Sorry for this inconsistency, it's fixed as well!

Quoted 2 lines

Otherwise it looks good. Care to fix those issues and resubmit?

Thanks, I am resubmitting the patch.

Emmanuel.

Quoted 1 line

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#4 lore raw

PATCH 1/1 Add Swfdec Free flash library

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Emmanuel" == Emmanuel Riou <[email protected]> writes:

Emmanuel> Hi,
Emmanuel> There is a typo in the Swfdec patch I submitted yesterday. I have just Emmanuel> resubmitted another one which fixes the typo (ohost-pkconfig instead Emmanuel> of host-pkgconfig), please take this one into account and not the one Emmanuel> I sent yesterday.

Yes, I noticed ;) Don't worry, I fixed it up myself and committed your 2nd version.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 Add Swfdec Free flash library

Quoted 11 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Emmanuel" == Emmanuel Riou <[email protected]> writes:

Emmanuel> Hi,
Emmanuel> There is a typo in the Swfdec patch I submitted yesterday. I have just Emmanuel> resubmitted another one which fixes the typo (ohost-pkconfig instead Emmanuel> of host-pkgconfig), please take this one into account and not the one Emmanuel> I sent yesterday.

Yes, I noticed ;) Don't worry, I fixed it up myself and committed your 2nd version.

Thanks Peter!

Emmanuel.