Skip to contentSkip to conversation

N8x0 to mainline patches

DISCUSSION Kalle Valo 4 participants 12 messages Jul 13, 2009 – Aug 7, 2009

lore
Share & tools
lore

Kalle Valo

author
#0 lore raw

Hello,

I started working on adding N8x0 support to mainline, currently serial console works and I can mount initfs and rootfs on N800. The patches are available here:

http://www.valot.fi/kalle/n8x0/patches/n8x0-add/

To get all this coordinated, I created a wiki page for this:

http://elinux.org/N800

If there's something wrong or missing, please update it or send me an email so that I can update it.

Signature · 1 line
Kalle Valo
#1 lore raw

Hi,

Quoted 7 lines · ext Kalle Valo

Hello,

I started working on adding N8x0 support to mainline, currently serial console works and I can mount initfs and rootfs on N800. The patches are available here:

http://www.valot.fi/kalle/n8x0/patches/n8x0-add/

I'd say at least patch #2 should be sent for to l-o right now since it gets rid of another OMAP_TAG.

All the other patches (besides #1) look fine and I guess you could send all of them here for people to take a look at.

But patch #2 clearly doesn't belong to that series and should be integrated

Signature · 1 line
balbi
author
#2 lore raw
Quoted 5 lines · Felipe Balbi

Hi,

Quoted 2 lines · ext Kalle Valo

Hello,

Quoted 8 lines
Quoted 5 lines

I started working on adding N8x0 support to mainline, currently serial console works and I can mount initfs and rootfs on N800. The patches are available here:

http://www.valot.fi/kalle/n8x0/patches/n8x0-add/

I'd say at least patch #2 should be sent for to l-o right now since it gets rid of another OMAP_TAG.

I didn't implement omap1 part yet. As soon as I have done that, I'll send it.

Quoted 1 line

All the other patches (besides #1)

Yeah, patch #1 is some weird linker magic which I need to look at more. The patch is in the set just to get things started and I'll remove it from the final patchset.

Quoted 2 lines

look fine and I guess you could send all of them here for people to take a look at.

Ok, I'll do that soon but I'll try to implement a bit more to the board file first.

Quoted 2 lines

But patch #2 clearly doesn't belong to that series and should be integrated

I agree. But isn't Tony on vacation the whole July and there is nobody to push it to linux-omap?

Thanks for looking at the patches!

Signature · 1 line
Kalle Valo
#3 lore raw

Hi,

Quoted 5 lines · ext Kalle Valo
Quoted 2 lines

I'd say at least patch #2 should be sent for to l-o right now since it gets rid of another OMAP_TAG.

I didn't implement omap1 part yet. As soon as I have done that, I'll send it.

ok, good :-)

Quoted 4 lines

I agree. But isn't Tony on vacation the whole July and there is nobody to push it to linux-omap?

Thanks for looking at the patches!

Yes, he is indeed. Good to see we are really getting rid of omap tags :-)

Signature · 1 line
balbi
#4 lore raw
Quoted 11 lines · Felipe Balbi

Hi,

Quoted 5 lines · ext Kalle Valo
Quoted 2 lines

I'd say at least patch #2 should be sent for to l-o right now since it gets rid of another OMAP_TAG.

I didn't implement omap1 part yet. As soon as I have done that, I'll send it.

ok, good :-)

Quoted 7 lines
Quoted 4 lines

I agree. But isn't Tony on vacation the whole July and there is nobody to push it to linux-omap?

Thanks for looking at the patches!

Yes, he is indeed. Good to see we are really getting rid of omap tags :-)

Hey, nice job cleaning up the n8x0 board support! Let's get those into l-o master and queued up for the next merge window. (Except for the hacks that is).

Tony

author
#5 lore raw
Quoted 3 lines · Tony Lindgren

Hey, nice job cleaning up the n8x0 board support! Let's get those into l-o master and queued up for the next merge window. (Except for the hacks that is).

What did you think of the file layout? I decided to go with one file approach (against your advice, sorry) because I didn't see any benefit from having separate files.

My plan is this:

1. first finish OMAP_TAG_UART removal patch and send it for review

2. finins and send tusb6010 patch

+ omap2-add-usb-tusb6010-c

2. fold these n8x0 board file patches into one and send it for review:

+ n8x0-add-board-file
+ n8x0-onenand-support
+ n8x0-add-spi-support
+ n8x0-add-usb-support

Because the merge window is getting close, I'll do this ASAP.

There's a lot of to do still, but it's to get basic support to mainline already now, makes it easier for us to implement the missing pieces.

Signature · 1 line
Kalle Valo
author
#6 lore raw
Quoted 6 lines · Kalle Valo

My plan is this:

1. first finish OMAP_TAG_UART removal patch and send it for review

2. finins and send tusb6010 patch

Quoted 8 lines

+ omap2-add-usb-tusb6010-c

2. fold these n8x0 board file patches into one and send it for review:

+ n8x0-add-board-file
+ n8x0-onenand-support
+ n8x0-add-spi-support
+ n8x0-add-usb-support

This was item 3, of course. And I forget n8x0_defconfig, I'll send that as a separate patch.

Tony, does this look ok to you?

Kalle

#7 lore raw
Quoted 4 lines · Kalle Valo
Quoted 3 lines · Kalle Valo

My plan is this:

1. first finish OMAP_TAG_UART removal patch and send it for review

This would be great.

Quoted 3 lines
Quoted 3 lines

2. finins and send tusb6010 patch

+ omap2-add-usb-tusb6010-c

The tusb6010 could be added later on as a fix too if you want to cut down dependencies.

Quoted 6 lines
Quoted 6 lines

2. fold these n8x0 board file patches into one and send it for review:

+ n8x0-add-board-file
+ n8x0-onenand-support
+ n8x0-add-spi-support
+ n8x0-add-usb-support

Yeh one patch for the board file.

Quoted 2 lines

This was item 3, of course. And I forget n8x0_defconfig, I'll send that as a separate patch.

Yeah it's easier to read the series that way.

Quoted 1 line

Tony, does this look ok to you?

Looks good to me!

Tony

author
#8 lore raw
Quoted 6 lines · Tony Lindgren
Quoted 3 lines
Quoted 3 lines

2. finins and send tusb6010 patch

+ omap2-add-usb-tusb6010-c

The tusb6010 could be added later on as a fix too if you want to cut down dependencies.

Good point, I'll send that separately.

Current n8x0 patches are here:

http://www.valot.fi/kalle/n8x0/patches/n8x0-add/2009-08-06-19:21/

They are just pending final testing and I'll send them after I have done that, hopefully tonight.

Tony, on which tree should I base the patches? They are now against linus's tree.

Signature · 1 line
Kalle Valo
#9 lore raw
Quoted 13 lines · Kalle Valo
Quoted 6 lines · Tony Lindgren
Quoted 3 lines
Quoted 3 lines

2. finins and send tusb6010 patch

+ omap2-add-usb-tusb6010-c

The tusb6010 could be added later on as a fix too if you want to cut down dependencies.

Good point, I'll send that separately.

Current n8x0 patches are here:

Quoted 7 lines

http://www.valot.fi/kalle/n8x0/patches/n8x0-add/2009-08-06-19:21/

They are just pending final testing and I'll send them after I have done that, hopefully tonight.

Tony, on which tree should I base the patches? They are now against linus's tree.

Great, yeah it's best to base all the patches against Linus' tree where possible.

I'll start piling up the omap-upstream queue for the merge window and will add your serial patch there. So we still have few more days to deal with the board file patch.

Tony

#10 lore raw
In reply to Kalle Valo
Quoted 9 lines · Kalle Valo
Quoted 3 lines · Tony Lindgren

Hey, nice job cleaning up the n8x0 board support! Let's get those into l-o master and queued up for the next merge window. (Except for the hacks that is).

What did you think of the file layout? I decided to go with one file approach (against your advice, sorry) because I didn't see any benefit from having separate files.

Your one file approach looks good to me.

Tony

#11 lore raw
In reply to Kalle Valo

Kalle Valo wrote at 2009-07-13 00:51 -0500:

Quoted 5 lines

I started working on adding N8x0 support to mainline, currently serial console works and I can mount initfs and rootfs on N800. The patches are available here:

http://www.valot.fi/kalle/n8x0/patches/n8x0-add/

Thanks for your work.

Quoted 3 lines

To get all this coordinated, I created a wiki page for this:

http://elinux.org/N800

I have added a links section and will probably be doing more there.