Skip to contentSkip to conversation

i386: also limit NODES_HIGH_SHIFT here

PATCH RESEND In review Jan Beulich 2 participants 3 messages Mar 12, 2009 – Mar 13, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 i386: also limit NODES_HIGH_SHIFT here

Impact: configuration bug fix

Just like for x86-64, the range of widths valid for NODE_SHIFT is not unbounded. The upper bound 64-bit uses is definitely also an upper bound for 32-bit.

---
 arch/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/Kconfig +1 -1
@@ -1087,7 +1087,7 @@ config NUMA_EMU
 
 config NODES_SHIFT
 	int "Maximum NUMA Nodes (as a power of 2)" if !MAXSMP
-	range 1 9   if X86_64
+	range 1 9
 	default "9" if MAXSMP
 	default "6" if X86_64
 	default "4" if X86_NUMAQ
#1 lore raw
Quoted 5 lines · Jan Beulich

Impact: configuration bug fix

Just like for x86-64, the range of widths valid for NODE_SHIFT is not unbounded. The upper bound 64-bit uses is definitely also an upper bound for 32-bit.

I think that's actually obsolete, there's no real 128 nodes limit.

The only limit used to be 256 nodes because you can't have more nodes than CPUs, but that's obsolete with x2apic.

-Andi

Signature · 1 line
[email protected] -- Speaking for myself only.
#2 lore raw

[tip:x86/mm] x86, 32-bit: also limit NODES_HIGH_SHIFT here

In reply to Jan Beulich
Commit-ID:  46d50c98d90cd7feaa5977a09c574063e5c99b3d
Gitweb:     http://git.kernel.org/tip/46d50c98d90cd7feaa5977a09c574063e5c99b3d
Author:     Jan Beulich <[email protected]>
AuthorDate: Thu, 12 Mar 2009 12:33:06 +0000
Commit:     Ingo Molnar <[email protected]>
CommitDate: Fri, 13 Mar 2009 02:37:17 +0100

x86, 32-bit: also limit NODES_HIGH_SHIFT here

Impact: configuration bug fix

Just like for x86-64, the range of widths valid for NODE_SHIFT is not unbounded. The upper bound 64-bit uses is definitely also an upper bound for 32-bit.

LKML-Reference: <[email protected]>

---
 arch/x86/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/Kconfig +1 -1
index 87717f3..076f4f8 100644
@@ -1123,7 +1123,7 @@ config NUMA_EMU
 
 config NODES_SHIFT
 	int "Maximum NUMA Nodes (as a power of 2)" if !MAXSMP
-	range 1 9   if X86_64
+	range 1 9
 	default "9" if MAXSMP
 	default "6" if X86_64
 	default "4" if X86_NUMAQ