mplayer: add -fomit-frame-pointer for i386
PATCH 2/2 mplayer: add -fomit-frame-pointer for i386
This seems to be required to compile some of the inline asm.
This solves the following compiler errors:h264.c: In function 'decode_cabac_residual':
h264.c:6158: warning: passing argument 4 of 'decode_significance_8x8_x86' discards qualifiers from pointer target type cabac.h: In function 'get_cabac_noinline':
cabac.h:513: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' cabac.h:513: error: 'asm' operand has impossible constraints
While searching several weeks ago, I hit the following URL, which unfortunately currently doesn't seem to work anymore and I can't remember what the bug was about.
Also see http://bugs.uclibc.org/view.php?id=4604
--- package/multimedia/mplayer/mplayer.mk | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
package/multimedia/mplayer/mplayer.mk +6 -1
@@ -25,6 +25,11 @@ else MPLAYER_LARGEFILE:=--disable-largefiles endif +ifeq ($(BR2_i386),y) +# This seems to be required to compile some of the inline asm +MPLAYER_CFLAGS:=-fomit-frame-pointer +endif + $(DL_DIR)/$(MPLAYER_SOURCE): $(call DOWNLOAD,$(MPLAYER_SITE),$(MPLAYER_SOURCE))
@@ -38,7 +43,7 @@ $(MPLAYER_DIR)/.configured: $(MPLAYER_DIR)/.unpacked (cd $(MPLAYER_DIR); rm -rf config.cache; \ $(TARGET_CONFIGURE_OPTS) \ $(TARGET_CONFIGURE_ARGS) \ - CFLAGS="$(TARGET_CFLAGS)" \ + CFLAGS="$(TARGET_CFLAGS) $(MPLAYER_CFLAGS)" \ LDFLAGS="$(TARGET_LDFLAGS)" \ ./configure \ --prefix=/usr \
Signature · 1 line
1.6.1.1.227.g86702
PATCH 2/2 mplayer: add -fomit-frame-pointer for i386
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Markus" == Markus Heidelberg <[email protected]> writes:
Markus> This seems to be required to compile some of the inline asm.
Thanks, committed.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 2/2 mplayer: add -fomit-frame-pointer for i386
In reply to Markus HeidelbergQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Markus" == Markus Heidelberg <[email protected]> writes:
Markus> While searching several weeks ago, I hit the following URL, which Markus> unfortunately currently doesn't seem to work anymore and I can't Markus> remember what the bug was about.
Markus> Also see http://bugs.uclibc.org/view.php?id=4604
That's unfortunately a link to the old (removed because of security breach) mantis tracker.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 2/2 mplayer: add -fomit-frame-pointer for i386
Peter Korsgaard, 26.01.2009:
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Markus" == Markus Heidelberg <[email protected]> writes:
Markus> While searching several weeks ago, I hit the following URL, which Markus> unfortunately currently doesn't seem to work anymore and I can't Markus> remember what the bug was about.
Markus> Also see http://bugs.uclibc.org/view.php?id=4604
That's unfortunately a link to the old (removed because of security breach) mantis tracker.
I thought so yes, is the new bugtracker already working? When entering bug id 4604 on bugs.busybox.net, I got the error "Bug #4604 does not exist.", so I kept this dead URL in the commit message for the sake of completeness.
Markus
PATCH 2/2 mplayer: add -fomit-frame-pointer for i386
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Markus" == Markus Heidelberg <[email protected]> writes:
That's unfortunately a link to the old (removed because of security breach) mantis tracker.
Markus> I thought so yes, is the new bugtracker already working?
It is, but the old issues have not been migrated (and I'm afraid they never will).
Markus> When entering bug id 4604 on bugs.busybox.net, I got the Markus> error "Bug #4604 does not exist.", so I kept this dead URL in Markus> the commit message for the sake of completeness.
Ok - Thanks.
Signature · 1 line
Bye, Peter Korsgaard