Skip to contentSkip to conversation

dfu: Correct dependencies for DFU_TFTP

PATCH In review Tom Rini 2 participants 3 messages Mar 17 – Apr 8

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 dfu: Correct dependencies for DFU_TFTP

As exposed by "make randconfig", we have an issue with the dependencies for DFU_TFTP. This really depends on the legacy networking stack being enabled, not just lwIP not being enabled (as it will fail in the NO_NET case).

---
Cc: Mattijs Korpershoek <[email protected]>

---
 drivers/dfu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dfu/Kconfig +1 -1
index 962bda40ad2d..1d5d8caa7daa 100644
@@ -20,7 +20,7 @@ if DFU
 config DFU_TFTP
 	bool "DFU via TFTP"
 	depends on NETDEVICES
-	depends on !NET_LWIP
+	depends on NET # Legacy stack only
 	select UPDATE_COMMON
 	select DFU_OVER_TFTP
 	help
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw

Hi Tom,

Thank you for the patch.

Quoted 6 lines · Tom Rini

As exposed by "make randconfig", we have an issue with the dependencies for DFU_TFTP. This really depends on the legacy networking stack being enabled, not just lwIP not being enabled (as it will fail in the NO_NET case).

Quoted 21 lines

---
Cc: Mattijs Korpershoek <[email protected]>

---
 drivers/dfu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dfu/Kconfig +1 -1
index 962bda40ad2d..1d5d8caa7daa 100644
@@ -20,7 +20,7 @@ if DFU
 config DFU_TFTP
 	bool "DFU via TFTP"
 	depends on NETDEVICES
-	depends on !NET_LWIP
+	depends on NET # Legacy stack only
 	select UPDATE_COMMON
 	select DFU_OVER_TFTP
 	help
Signature · 1 line
2.43.0
#2 lore raw
In reply to Tom Rini

Hi,

Quoted 6 lines · Tom Rini

As exposed by "make randconfig", we have an issue with the dependencies for DFU_TFTP. This really depends on the legacy networking stack being enabled, not just lwIP not being enabled (as it will fail in the NO_NET case).

Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu)

[1/1] dfu: Correct dependencies for DFU_TFTP

      https://source.denx.de/u-boot/custodians/u-boot-dfu/-/commit/93a362d9f29227b94927ae1534e765a45cefc807

--
Mattijs