Skip to contentSkip to conversation

ALSA: gus: Fix errors in gus_mem.c

PATCH In review [email protected] 2 participants 2 messages Jul 18, 2023 1 message not in the archive Sound

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 ALSA: gus: Fix errors in gus_mem.c

The following checkpatch errors are removed:
ERROR: trailing whitespace
ERROR: "foo * bar" should be "foo *bar"

---
 sound/isa/gus/gus_mem.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
sound/isa/gus/gus_mem.c +7 -7
index 3e56c01c4544..00c73c0b068f 100644
@@ -11,11 +11,11 @@
 #include <sound/info.h>
 
 #ifdef CONFIG_SND_DEBUG
-static void snd_gf1_mem_info_read(struct snd_info_entry *entry,
+static void snd_gf1_mem_info_read(struct snd_info_entry *entry,
                   struct snd_info_buffer *buffer);
 #endif
 
-void snd_gf1_mem_lock(struct snd_gf1_mem * alloc, int xup)
+void snd_gf1_mem_lock(struct snd_gf1_mem *alloc, int xup)
 {
     if (!xup) {
         mutex_lock(&alloc->memory_mutex);
@@ -67,7 +67,7 @@ snd_gf1_mem_xalloc(struct snd_gf1_mem *alloc, struct snd_gf1_mem_block *block,
     return nblock;
 }
 
-int snd_gf1_mem_xfree(struct snd_gf1_mem * alloc, struct snd_gf1_mem_block * block)
+int snd_gf1_mem_xfree(struct snd_gf1_mem *alloc, struct snd_gf1_mem_block *block)
 {
     if (block->share) {    /* ok.. shared block */
         block->share--;
@@ -97,7 +97,7 @@ int snd_gf1_mem_xfree(struct snd_gf1_mem * alloc, struct snd_gf1_mem_block * blo
     return 0;
 }
 
-static struct snd_gf1_mem_block *snd_gf1_mem_look(struct snd_gf1_mem * alloc,
+static struct snd_gf1_mem_block *snd_gf1_mem_look(struct snd_gf1_mem *alloc,
                          unsigned int address)
 {
     struct snd_gf1_mem_block *block;
@@ -110,7 +110,7 @@ static struct snd_gf1_mem_block *snd_gf1_mem_look(struct snd_gf1_mem * alloc,
     return NULL;
 }
 
-static struct snd_gf1_mem_block *snd_gf1_mem_share(struct snd_gf1_mem * alloc,
+static struct snd_gf1_mem_block *snd_gf1_mem_share(struct snd_gf1_mem *alloc,
                           unsigned int *share_id)
 {
     struct snd_gf1_mem_block *block;
@@ -125,8 +125,8 @@ static struct snd_gf1_mem_block *snd_gf1_mem_share(struct snd_gf1_mem * alloc,
     return NULL;
 }
 
-static int snd_gf1_mem_find(struct snd_gf1_mem * alloc,
-                struct snd_gf1_mem_block * block,
+static int snd_gf1_mem_find(struct snd_gf1_mem *alloc,
+                struct snd_gf1_mem_block *block,
                 unsigned int size, int w_16, int align)
 {
     struct snd_gf1_bank_info *info = w_16 ? alloc->banks_16 : 

alloc->banks_8;
@@ -177,7 +177,7 @@ static int snd_gf1_mem_find(struct snd_gf1_mem * alloc,

     return -ENOMEM;

}

-struct snd_gf1_mem_block *snd_gf1_mem_alloc(struct snd_gf1_mem * alloc, int owner, +struct snd_gf1_mem_block *snd_gf1_mem_alloc(struct snd_gf1_mem *alloc, int owner,
char *name, int size, int w_16, int align,
unsigned int *share_id)
{
@@ -210,7 +210,7 @@ struct snd_gf1_mem_block *snd_gf1_mem_alloc(struct snd_gf1_mem * alloc, int owne

     return nblock;

}

-int snd_gf1_mem_free(struct snd_gf1_mem * alloc, unsigned int address) +int snd_gf1_mem_free(struct snd_gf1_mem *alloc, unsigned int address)

 {
     int result;
     struct snd_gf1_mem_block *block;
@@ -226,7 +226,7 @@ int snd_gf1_mem_free(struct snd_gf1_mem * alloc, unsigned int address)
     return -EINVAL;

}

-int snd_gf1_mem_init(struct snd_gus_card * gus)
+int snd_gf1_mem_init(struct snd_gus_card *gus)

 {
     struct snd_gf1_mem *alloc;
     struct snd_gf1_mem_block block;
@@ -255,7 +255,7 @@ int snd_gf1_mem_init(struct snd_gus_card * gus)
     return 0;

}

-int snd_gf1_mem_done(struct snd_gus_card * gus)
+int snd_gf1_mem_done(struct snd_gus_card *gus)

 {
     struct snd_gf1_mem *alloc;
     struct snd_gf1_mem_block *block, *nblock;

@@ -271,7 +271,7 @@ int snd_gf1_mem_done(struct snd_gus_card * gus)
}

#ifdef CONFIG_SND_DEBUG
-static void snd_gf1_mem_info_read(struct snd_info_entry *entry, +static void snd_gf1_mem_info_read(struct snd_info_entry *entry,
struct snd_info_buffer *buffer)

 {
     struct snd_gus_card *gus;
#2 lore raw
Quoted 6 lines · On Tue, 18 Jul 2023 03:02:11 +0200, [email protected] wrote:

The following checkpatch errors are removed:
ERROR: trailing whitespace
ERROR: "foo * bar" should be "foo *bar"

Thanks for the patch. But we don't take such a white-space only change unless you work on further to fix any real bugs or more fundamental improvements.

Ditto for ps3 driver.

Takashi