tests/qtest/migration-test: Fix unlink error and memory leaks
PATCH 1/1 tests/qtest/migration-test: Fix unlink error and memory leaks
When running the migration test compiled with Clang from Fedora 37 and sanitizers enabled, there is an error complaining about unlink():
../tests/qtest/migration-test.c:1072:12: runtime error: null pointer
passed as argument 1, which is declared to never be null
/usr/include/unistd.h:858:48: note: nonnull attribute specified here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../tests/qtest/migration-test.c:1072:12 in
(test program exited with status code 1)
TAP parsing error: Too few tests run (expected 33, got 20)
The data->clientcert and data->clientkey pointers can indeed be unset in some tests, so we have to check them before calling unlink() with those.
While we're at it, I also noticed that the code is only freeing some but not all of the allocated strings in this function, and indeed, valgrind is also complaining about memory leaks here. So let's call g_free() on all allocated strings to avoid leaking memory here.
--- tests/qtest/migration-test.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-)
tests/qtest/migration-test.c +16 -4
@@ -1066,15 +1066,27 @@ test_migrate_tls_x509_finish(QTestState *from,TestMigrateTLSX509Data *data = opaque;test_tls_cleanup (data->keyfile); +g_free (data->keyfile); +unlink (data->cacert); +g_free (data->cacert);unlink (data->servercert); +g_free (data->servercert);unlink (data->serverkey); -unlink (data->clientcert); -unlink (data->clientkey); -rmdir (data->workdir); +g_free (data->serverkey); +if (data->clientcert) { +unlink (data->clientcert); +g_free (data->clientcert); + } +if (data->clientkey) { +unlink (data->clientkey); +g_free (data->clientkey); + } + +rmdir (data->workdir);g_free (data->workdir); -g_free (data->keyfile); + g_free(data); }#endif /* CONFIG_TASN1 */
Signature · 1 line
2.31.1
Quoted 21 lines · Thomas Huth
When running the migration test compiled with Clang from Fedora 37 and sanitizers enabled, there is an error complaining about
unlink():
../tests/qtest/migration-test.c:1072:12: runtime error: null pointer
passed as argument 1, which is declared to never be null
/usr/include/unistd.h:858:48: note: nonnull attribute specified here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../tests/qtest/migration-test.c:1072:12in
(test program exited with status code 1)
TAP parsing error: Too few tests run (expected 33, got 20)The
data->clientcertanddata->clientkeypointers can indeed be unset in some tests, so we have to check them before callingunlink()with those.While we're at it, I also noticed that the code is only freeing some but not all of the allocated strings in this function, and indeed, valgrind is also complaining about memory leaks here. So let's call
g_free()on all allocated strings to avoid leaking memory here.
Quoted 4 lines
Signed-off-by Thomas Huth <[email protected]>--- tests/qtest/migration-test.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-)
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Juan Quintela
Reviewed-byQuoted 16 lines · Daniel P. Berrangé
Quoted 15 lines · Thomas Huth
When running the migration test compiled with Clang from Fedora 37 and sanitizers enabled, there is an error complaining about
unlink():
../tests/qtest/migration-test.c:1072:12: runtime error: null pointer
passed as argument 1, which is declared to never be null
/usr/include/unistd.h:858:48: note: nonnull attribute specified here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../tests/qtest/migration-test.c:1072:12in
(test program exited with status code 1)
TAP parsing error: Too few tests run (expected 33, got 20)The
data->clientcertanddata->clientkeypointers can indeed be unset in some tests, so we have to check them before callingunlink()with those.
Quoted 7 lines
Quoted 7 lines
While we're at it, I also noticed that the code is only freeing some but not all of the allocated strings in this function, and indeed, valgrind is also complaining about memory leaks here. So let's call
g_free()on all allocated strings to avoid leaking memory here.Signed-off-by Thomas Huth <[email protected]>
Quoted 15 lines · Thomas Huth
When running the migration test compiled with Clang from Fedora 37 and sanitizers enabled, there is an error complaining about
unlink():
../tests/qtest/migration-test.c:1072:12: runtime error: null pointer
passed as argument 1, which is declared to never be null
/usr/include/unistd.h:858:48: note: nonnull attribute specified here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../tests/qtest/migration-test.c:1072:12in
(test program exited with status code 1)
TAP parsing error: Too few tests run (expected 33, got 20)The
data->clientcertanddata->clientkeypointers can indeed be unset in some tests, so we have to check them before callingunlink()with those.
Quoted 7 lines
While we're at it, I also noticed that the code is only freeing some but not all of the allocated strings in this function, and indeed, valgrind is also complaining about memory leaks here. So let's call
g_free()on all allocated strings to avoid leaking memory here.Signed-off-by Thomas Huth <[email protected]>
Quoted 22 lines · Thomas Huth
When running the migration test compiled with Clang from Fedora 37 and sanitizers enabled, there is an error complaining about
unlink():
../tests/qtest/migration-test.c:1072:12: runtime error: null pointer
passed as argument 1, which is declared to never be null
/usr/include/unistd.h:858:48: note: nonnull attribute specified here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../tests/qtest/migration-test.c:1072:12in
(test program exited with status code 1)
TAP parsing error: Too few tests run (expected 33, got 20)The
data->clientcertanddata->clientkeypointers can indeed be unset in some tests, so we have to check them before callingunlink()with those.While we're at it, I also noticed that the code is only freeing some but not all of the allocated strings in this function, and indeed, valgrind is also complaining about memory leaks here. So let's call
g_free()on all allocated strings to avoid leaking memory here.
Quoted 5 lines
Signed-off-by Thomas Huth <[email protected]>--- tests/qtest/migration-test.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-)