Skip to contentSkip to conversation

selftests: forwarding: add shebang for sch_red.sh

PATCH Applied Hangbin Liu 3 participants 3 messages Sep 22, 2022

Subsystems (4)
Networking Network drivers Kselftest IPv4/IPv6
lore
Share & tools
lore

Hangbin Liu

author
#0 lore raw

PATCH 1/1 selftests: forwarding: add shebang for sch_red.sh

RHEL/Fedora RPM build checks are stricter, and complain when executable files don't have a shebang line, e.g.

*** WARNING: ./kselftests/net/forwarding/sch_red.sh is executable but has no shebang, removing executable bit

Fix it by adding shebang line.

Fixes 6cf0291f9517 ("selftests: forwarding: Add a RED test for SW datapath")
Signed-off-by Hangbin Liu <[email protected]>
---
 tools/testing/selftests/net/forwarding/sch_red.sh | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/net/forwarding/sch_red.sh +1 -0
index e714bae473fb..81f31179ac88 100755
@@ -1,3 +1,4 @@
+#!/bin/bash
 # SPDX-License-Identifier: GPL-2.0
 
 # This test sends one stream of traffic from H1 through a TBF shaper, to a RED
Signature · 1 line
2.37.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Hangbin Liu

RHEL/Fedora RPM build checks are stricter, and complain when executable files don't have a shebang line, e.g.

*** WARNING: ./kselftests/net/forwarding/sch_red.sh is executable but has no shebang, removing executable bit

Fix it by adding shebang line.

Fixes 6cf0291f9517 ("selftests: forwarding: Add a RED test for SW datapath")
Signed-off-by Hangbin Liu <[email protected]>
Reviewed-by Petr Machata <[email protected]>
CI Applied
#2 lore raw
In reply to Hangbin Liu
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Thu, 22 Sep 2022 10:44:53 +0800 you wrote:

RHEL/Fedora RPM build checks are stricter, and complain when executable files don't have a shebang line, e.g.

*** WARNING: ./kselftests/net/forwarding/sch_red.sh is executable but has no shebang, removing executable bit

Fix it by adding shebang line.

[...]

Here is the summary with links:
- [net] selftests: forwarding: add shebang for sch_red.sh

    https://git.kernel.org/netdev/net/c/83e4b196838d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html