drm/i915/pxp: fix sparse warning for not declared symbol
Subsystems (2)
PATCH 1/1 drm/i915/pxp: fix sparse warning for not declared symbol
Fix:
drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c:61:6: warning: symbol 'intel_pxp_debugfs_register' was not declared. Should it be static?
Sort and remove the redundant pxp prefixes from the includes while at it.
--- drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c +3 -2
@@ -9,9 +9,10 @@#include <drm/drm_print.h> #include "gt/intel_gt_debugfs.h" -#include "pxp/intel_pxp.h" -#include "pxp/intel_pxp_irq.h" #include "i915_drv.h" +#include "intel_pxp.h" +#include "intel_pxp_debugfs.h" +#include "intel_pxp_irq.h" static int pxp_info_show (struct seq_file *m,void *data) {
Signature · 1 line
2.30.2
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: fix sparse warning for not declared symbol
== Series Details ==
== Series Details ==
Series: drm/i915/pxp: fix sparse warning for not declared symbol
URL : https://patchwork.freedesktop.org/series/103673/
State : warning
== Summary ==
Error: dim checkpatch failed151a8d341bdd drm/i915/pxp: fix sparse warning for not declared symbol
-:4: WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it #4:
Subject: [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol
total: 0 errors, 1 warnings, 0 checks, 12 lines checked
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: fix sparse warning for not declared symbol
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/pxp: fix sparse warning for not declared symbol
URL : https://patchwork.freedesktop.org/series/103673/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11617 -> Patchwork_103673v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/index.html
Participating hosts (45 -> 34)
------------------------------
Additional (1): fi-snb-2520m
Missing (12): bat-adls-5 bat-dg1-6 bat-dg2-8 fi-skl-guc bat-adlm-1 bat-dg2-9 fi-bsw-cyan bat-adlp-6 bat-adln-1 bat-rpls-2 bat-jsl-2 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_103673v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@basic:
- fi-snb-2520m: NOTRUN -> [SKIP][1] ([fdo#109271]) +24 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/fi-snb-2520m/igt@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-snb-2600: NOTRUN -> [SKIP][2] ([fdo#109271] / [fdo#111827])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/fi-snb-2600/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-snb-2520m: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827]) +8 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/fi-snb-2520m/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][4] ([i915#3921]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/fi-snb-2600/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/fi-snb-2600/igt@i915_selftest@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
Build changes
-------------
* Linux: CI_DRM_11617 -> Patchwork_103673v1
CI-20190529: 20190529
CI_DRM_11617: d96cea3d7ffb524248fcc8db433c579cf262eaea @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6468: cffa5fffe9acddf49565b4caeeb5e3355ff2ea44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103673v1: d96cea3d7ffb524248fcc8db433c579cf262eaea @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
5ddacc70a7f9 drm/i915/pxp: fix sparse warning for not declared symbol
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pxp: fix sparse warning for not declared symbol
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/pxp: fix sparse warning for not declared symbol
URL : https://patchwork.freedesktop.org/series/103673/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11617_full -> Patchwork_103673v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/index.html
Participating hosts (11 -> 7)
------------------------------
Missing (4): pig-skl-6260u pig-kbl-iris shard-tglu pig-glk-j5005
Known issues
------------
Here are the changes found in Patchwork_103673v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_big_fb@linear-64bpp-rotate-0:
- shard-snb: [PASS][1] -> [SKIP][2] ([fdo#109271]) +5 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/shard-snb4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/shard-snb7/igt@[email protected]
#### Possible fixes ####
* igt@gem_mmap_gtt@coherency:
- shard-snb: [SKIP][3] ([fdo#109271]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/shard-snb6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/shard-snb4/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
Build changes
-------------
* Linux: CI_DRM_11617 -> Patchwork_103673v1
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_11617: d96cea3d7ffb524248fcc8db433c579cf262eaea @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6468: cffa5fffe9acddf49565b4caeeb5e3355ff2ea44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103673v1: d96cea3d7ffb524248fcc8db433c579cf262eaea @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/index.html
Quoted 20 lines · Jani Nikula
Fix:
drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c:61:6: warning: symbol 'intel_pxp_debugfs_register' was not declared. Should it be static?Sort and remove the redundant pxp prefixes from the includes while at it.
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c +0
-0@@ -9,9 +9,10 @@#include <drm/drm_print.h>
drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c line 18
Quoted 10 lines
drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c +3
-2#include "gt/intel_gt_debugfs.h" -#include "pxp/intel_pxp.h" -#include "pxp/intel_pxp_irq.h" #include "i915_drv.h" +#include "intel_pxp.h" +#include "intel_pxp_debugfs.h" +#include "intel_pxp_irq.h" static int pxp_info_show (struct seq_file *m,void *data) {
Lets try to copy domain owners when doing cleanups to lessen the maintainer load, since it appears people are not really scanning the upstream mailing list these days. :(
Regards,
Tvrtko
Quoted 29 lines · Tvrtko Ursulin
Quoted 28 lines · Jani Nikula
Fix:
drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c:61:6: warning: symbol 'intel_pxp_debugfs_register' was not declared. Should it be static?Sort and remove the redundant pxp prefixes from the includes while at it.
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c +3
-2@@ -9,9 +9,10 @@#include <drm/drm_print.h> #include "gt/intel_gt_debugfs.h" -#include "pxp/intel_pxp.h" -#include "pxp/intel_pxp_irq.h" #include "i915_drv.h" +#include "intel_pxp.h" +#include "intel_pxp_debugfs.h" +#include "intel_pxp_irq.h"
Quoted 4 lines
drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c line 18
Quoted 2 lines
drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c +0
-0static int pxp_info_show (struct seq_file *m,void *data) {Reviewed-by Tvrtko Ursulin <[email protected]>
Thanks, pushed to din.
BR,
Jani.
Quoted 8 lines
Lets try to copy domain owners when doing cleanups to lessen the maintainer load, since it appears people are not really scanning the upstream mailing list these days. :(
Regards,
Tvrtko
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center