Skip to contentSkip to conversation

package/tcpdump: remove duplicated binary

PATCH New Thomas De Schampheleire 3 participants 3 messages Feb 16, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/tcpdump: remove duplicated binary

From: Thomas De Schampheleire <[email protected]>

Since tcpdump 4.99.0, the 'tcpdump' binary is no longer installed in /usr/sbin but in /usr/bin. This change invalidates the Buildroot hook 'TCPDUMP_REMOVE_DUPLICATED_BINARY', causing a fairly large rootfs size increase as a result.

Update the path inside this hook.

---
 package/tcpdump/tcpdump.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/tcpdump/tcpdump.mk +1 -1
index f8ea6576ee..c562034a4e 100644
@@ -22,7 +22,7 @@ TCPDUMP_SELINUX_MODULES = netutils
 
 # make install installs an unneeded extra copy of the tcpdump binary
 define TCPDUMP_REMOVE_DUPLICATED_BINARY
-	rm -f $(TARGET_DIR)/usr/sbin/tcpdump.$(TCPDUMP_VERSION)
+	rm -f $(TARGET_DIR)/usr/bin/tcpdump.$(TCPDUMP_VERSION)
 endef
 
 TCPDUMP_POST_INSTALL_TARGET_HOOKS += TCPDUMP_REMOVE_DUPLICATED_BINARY
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 package/tcpdump: remove duplicated binary

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

From: Thomas De Schampheleire <[email protected]> Since tcpdump 4.99.0, the 'tcpdump' binary is no longer installed in /usr/sbin but in /usr/bin. This change invalidates the Buildroot hook 'TCPDUMP_REMOVE_DUPLICATED_BINARY', causing a fairly large rootfs size increase as a result.

Update the path inside this hook.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/tcpdump: remove duplicated binary

In reply to Thomas De Schampheleire

Hi Thomas,

Quoted 10 lines · Thomas De Schampheleire

From: Thomas De Schampheleire <[email protected]>

Since tcpdump 4.99.0, the 'tcpdump' binary is no longer installed in /usr/sbin but in /usr/bin. This change invalidates the Buildroot hook 'TCPDUMP_REMOVE_DUPLICATED_BINARY', causing a fairly large rootfs size increase as a result.

Update the path inside this hook.

Thanks,
baruch

Quoted 17 lines
---
 package/tcpdump/tcpdump.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/tcpdump/tcpdump.mk +1 -1
index f8ea6576ee..c562034a4e 100644
@@ -22,7 +22,7 @@ TCPDUMP_SELINUX_MODULES = netutils
 
 # make install installs an unneeded extra copy of the tcpdump binary
 define TCPDUMP_REMOVE_DUPLICATED_BINARY
-	rm -f $(TARGET_DIR)/usr/sbin/tcpdump.$(TCPDUMP_VERSION)
+	rm -f $(TARGET_DIR)/usr/bin/tcpdump.$(TCPDUMP_VERSION)
 endef
 
 TCPDUMP_POST_INSTALL_TARGET_HOOKS += TCPDUMP_REMOVE_DUPLICATED_BINARY
Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -