package/libpam-tacplus: remove duplicate LIBPAM_TACPLUS_AUTORECONF
PATCH 1/1 package/libpam-tacplus: remove duplicate LIBPAM_TACPLUS_AUTORECONF
The commit [1] added a second LIBPAM_TACPLUS_AUTORECONF because we are now patching configure.ac.
But LIBPAM_TACPLUS_AUTORECONF was already used because the package is fetched from github.
[1] bd85d82f61af0578a64e74e1cfb56c3c1bf46fe1
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/849509860
--- package/libpam-tacplus/libpam-tacplus.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
package/libpam-tacplus/libpam-tacplus.mk +1 -2
@@ -12,10 +12,9 @@ LIBPAM_TACPLUS_DEPENDENCIES = \ linux-pam \ $(if $(BR2_PACKAGE_OPENSSL),openssl) # Fetching from github, we need to generate the configure script +# 0001-Add-an-option-to-disable-Werror.patch LIBPAM_TACPLUS_AUTORECONF = YES LIBPAM_TACPLUS_INSTALL_STAGING = YES -# We're patching configure.ac -LIBPAM_TACPLUS_AUTORECONF = YES LIBPAM_TACPLUS_CONF_ENV = \ ax_cv_check_cflags___fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no) LIBPAM_TACPLUS_CONF_OPTS = --disable-werror
Signature · 1 line
2.25.4
PATCH 1/1 package/libpam-tacplus: remove duplicate LIBPAM_TACPLUS_AUTORECONF
Hi Romain,
Le sam. 14 nov. 2020 ? 15:52, Romain Naour <[email protected]> a ?crit :
Quoted 22 lines
The commit [1] added a second
LIBPAM_TACPLUS_AUTORECONFbecause we are now patching configure.ac.
ButLIBPAM_TACPLUS_AUTORECONFwas already used because the package is fetched from github.[1]
bd85d82f61af0578a64e74e1cfb56c3c1bf46fe1Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/849509860Signed-off-by Romain Naour <[email protected]>Cc Fabrice Fontaine <[email protected]>--- package/libpam-tacplus/libpam-tacplus.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)package/libpam-tacplus/libpam-tacplus.mk +0
-0
package/libpam-tacplus/libpam-tacplus.mk LIBPAM_TACPLUS_DEPENDENCIES = \ · line 18
Quoted 8 lines
package/libpam-tacplus/libpam-tacplus.mk +1
-2@@ -12,10 +12,9 @@ LIBPAM_TACPLUS_DEPENDENCIES = \ linux-pam \ $(if $(BR2_PACKAGE_OPENSSL),openssl) # Fetching from github, we need to generate the configure script +# 0001-Add-an-option-to-disable-Werror.patch LIBPAM_TACPLUS_AUTORECONF = YES LIBPAM_TACPLUS_INSTALL_STAGING = YES -# We're patching configure.ac -LIBPAM_TACPLUS_AUTORECONF = YES
Thanks again
Quoted 6 lines
package/libpam-tacplus/libpam-tacplus.mk +0
-1LIBPAM_TACPLUS_CONF_ENV = \ ax_cv_check_cflags___fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no) LIBPAM_TACPLUS_CONF_OPTS = --disable-werror --2.25.4
Best Regards,
Fabrice
PATCH 1/1 package/libpam-tacplus: remove duplicate LIBPAM_TACPLUS_AUTORECONF
Hello Fabrice,
Le 14/11/2020 ? 15:54, Fabrice Fontaine a ?crit?:
Quoted 20 lines
Hi Romain,
Le sam. 14 nov. 2020 ? 15:52, Romain Naour <[email protected]> a ?crit :
Quoted 17 lines
The commit [1] added a second
LIBPAM_TACPLUS_AUTORECONFbecause we are now patching configure.ac.
ButLIBPAM_TACPLUS_AUTORECONFwas already used because the package is fetched from github.[1]
bd85d82f61af0578a64e74e1cfb56c3c1bf46fe1Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/849509860Signed-off-by Romain Naour <[email protected]>Cc Fabrice Fontaine <[email protected]>--- package/libpam-tacplus/libpam-tacplus.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Quoted 14 lines
package/libpam-tacplus/libpam-tacplus.mk LIBPAM_TACPLUS_DEPENDENCIES = \ · line 18
Quoted 13 lines
package/libpam-tacplus/libpam-tacplus.mk +1
-2@@ -12,10 +12,9 @@ LIBPAM_TACPLUS_DEPENDENCIES = \ linux-pam \ $(if $(BR2_PACKAGE_OPENSSL),openssl) # Fetching from github, we need to generate the configure script +# 0001-Add-an-option-to-disable-Werror.patch LIBPAM_TACPLUS_AUTORECONF = YES LIBPAM_TACPLUS_INSTALL_STAGING = YES -# We're patching configure.ac -LIBPAM_TACPLUS_AUTORECONF = YESThanks again
No problem at all, you're welcome :)
Best regards,
Romain
Quoted 11 lines
Reviewed-by Fabrice Fontaine <[email protected]>Quoted 6 lines
package/libpam-tacplus/libpam-tacplus.mk +0
-1LIBPAM_TACPLUS_CONF_ENV = \ ax_cv_check_cflags___fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no) LIBPAM_TACPLUS_CONF_OPTS = --disable-werror --2.25.4
Best Regards,
Fabrice
PATCH 1/1 package/libpam-tacplus: remove duplicate LIBPAM_TACPLUS_AUTORECONF
In reply to Romain NaourQuoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Romain" == Romain Naour <[email protected]> writes:
The commit [1] added a second
LIBPAM_TACPLUS_AUTORECONFbecause we are now patching configure.ac.
ButLIBPAM_TACPLUS_AUTORECONFwas already used because the package is fetched from github.
Quoted 7 lines
[1]
bd85d82f61af0578a64e74e1cfb56c3c1bf46fe1Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/849509860Signed-off-by Romain Naour <[email protected]>Cc Fabrice Fontaine <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard