r8169: fix issue with forced threading in combination with shared interrupts
Heiner Kallweit
maintainerPATCH 1/1 r8169: fix issue with forced threading in combination with shared interrupts
As reported by Serge flag IRQF_NO_THREAD causes an error if the interrupt is actually shared and the other driver(s) don't have this flag set. This situation can occur if a PCI(e) legacy interrupt is used in combination with forced threading.
There's no good way to deal with this properly, therefore we have to remove flag IRQF_NO_THREAD. For fixing the original forced threading issue switch to napi_schedule().
--- drivers/net/ethernet/realtek/r8169_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/realtek/r8169_main.c +2 -2
@@ -4573,7 +4573,7 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance) }rtl_irq_disable (tp); -napi_schedule_irqoff (&tp->napi); +napi_schedule (&tp->napi); out:rtl_ack_events (tp, status);
@@ -4746,7 +4746,7 @@ static int rtl_open(struct net_device *dev)rtl_request_firmware (tp); retval =request_irq (pci_irq_vector (pdev,0 ), rtl8169_interrupt, -IRQF_NO_THREAD |IRQF_SHARED , dev->name, tp); +IRQF_SHARED , dev->name, tp);if (retval <0 ) goto err_release_fw_2;
Signature · 1 line
2.29.1
Quoted 8 lines
As reported by Serge flag
IRQF_NO_THREADcauses an error if the interrupt is actually shared and the other driver(s) don't have this flag set. This situation can occur if a PCI(e) legacy interrupt is used in combination with forced threading.
There's no good way to deal with this properly, therefore we have to remove flagIRQF_NO_THREAD. For fixing the original forced threading issue switch tonapi_schedule().
Quoted 5 lines
Fixes 424a646e072a ("r8169: fix operation under forced interrupt threading")Reported-by Serge Belyshev <[email protected]>Signed-off-by Heiner Kallweit <[email protected]>---
Thanks, that works for me.
Quoted 8 lines · On Thu, 29 Oct 2020 14:37:35 +0300 Serge Belyshev wrote:
Quoted 8 lines
As reported by Serge flag
IRQF_NO_THREADcauses an error if the interrupt is actually shared and the other driver(s) don't have this flag set. This situation can occur if a PCI(e) legacy interrupt is used in combination with forced threading.
There's no good way to deal with this properly, therefore we have to remove flagIRQF_NO_THREAD. For fixing the original forced threading issue switch tonapi_schedule().
Quoted 6 lines
Quoted 4 lines
Fixes 424a646e072a ("r8169: fix operation under forced interrupt threading")Reported-by Serge Belyshev <[email protected]>Signed-off-by Heiner Kallweit <[email protected]>Tested-by Serge Belyshev <[email protected]>
Applied, thanks!