Skip to contentSkip to conversation

package/mender: Fix incorrectly named service file

PATCH New aduskett at gmail.com 2 participants 2 messages Aug 28, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mender: Fix incorrectly named service file

From: Adam Duskett <[email protected]>

Many of the mender CLI commands use systemctl commands to get information about the daemon, such as the PID (IE: systemctl show -p MainPID mender-client). As seen above, these commands expect the service file to be named "mender-client" instead of "mender."

As such, in the current state, running a forced update check in the CLI will result in the following error:
failed to force updateCheck: could not find the PID of the mender daemon.

Changing the name of mender.service to mender-client.service fixes the issue.

---
 package/mender/{mender.service => mender-client.service} | 0
 package/mender/mender.mk                                 | 4 ++--
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename package/mender/{mender.service => mender-client.service} (100%)
package/mender/mender-client.service renamed from package/mender/mender.service +0 -0
similarity index 100%
rename from package/mender/mender.service
rename to package/mender/mender-client.service
package/mender/mender.mk +2 -2
index 325141787e..ca24b853b5 100644
@@ -77,8 +77,8 @@ endef
 MENDER_POST_INSTALL_TARGET_HOOKS += MENDER_INSTALL_CONFIG_FILES
 
 define MENDER_INSTALL_INIT_SYSTEMD
-	$(INSTALL) -D -m 0644 $(MENDER_PKGDIR)/mender.service \
-		$(TARGET_DIR)/usr/lib/systemd/system/mender.service
+	$(INSTALL) -D -m 0644 $(MENDER_PKGDIR)/mender-client.service \
+		$(TARGET_DIR)/usr/lib/systemd/system/mender-client.service
 endef
 
 define MENDER_INSTALL_INIT_SYSV
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 package/mender: Fix incorrectly named service file

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"aduskett" == aduskett <[email protected]> writes:

From: Adam Duskett <[email protected]>
Many of the mender CLI commands use systemctl commands to get information about the daemon, such as the PID (IE: systemctl show -p MainPID mender-client). As seen above, these commands expect the service file to be named "mender-client" instead of "mender."

Quoted 7 lines

As such, in the current state, running a forced update check in the CLI will result in the following error:
failed to force updateCheck: could not find the PID of the mender daemon.

Changing the name of mender.service to mender-client.service fixes the issue.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard