Skip to contentSkip to conversation

initramfs: drop comment against multiple formats

PATCH New Vivien Didelot 3 participants 5 messages Jan 26, 2019 – Jun 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 initramfs: drop comment against multiple formats

This patch removes an old comment against having multiple filesystem formats which doesn't bring any value.

It is also wrong per-se: one may want to use Buildroot to prepare a custom distribution containing a kernel+initramfs and a persistent default rootfs to pivot to.

---
 fs/initramfs/Config.in | 5 -----
 1 file changed, 5 deletions(-)
fs/initramfs/Config.in +0 -5
index 9d5a3f92e6..42a9d60524 100644
@@ -13,10 +13,5 @@ config BR2_TARGET_ROOTFS_INITRAMFS
 	  is used, regardless of how buildroot's cpio archive is
 	  configured.
 
-	  Note that enabling initramfs together with another filesystem
-	  formats doesn't make sense: you would end up having two
-	  identical root filesystems, one embedded inside the kernel
-	  image, and one separately.
-
 comment "initramfs needs a Linux kernel to be built"
 	depends on !BR2_LINUX_KERNEL
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 initramfs: drop comment against multiple formats

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vivien" == Vivien Didelot <[email protected]> writes:

This patch removes an old comment against having multiple filesystem formats which doesn't bring any value.

It is also wrong per-se: one may want to use Buildroot to prepare a custom distribution containing a kernel+initramfs and a persistent default rootfs to pivot to.

Yes, but in that case the final persistent rootfs would contain different files than the initramfs, right?

E.G. I handle such a use case by two different defconfigs, one building the Linux kernel + initramfs and another for the final persistent rootfs.

Quoted 28 lines
---
 fs/initramfs/Config.in | 5 -----
 1 file changed, 5 deletions(-)
fs/initramfs/Config.in +0 -5
index 9d5a3f92e6..42a9d60524 100644
@@ -13,10 +13,5 @@ config BR2_TARGET_ROOTFS_INITRAMFS
 	  is used, regardless of how buildroot's cpio archive is
 	  configured.
 
-	  Note that enabling initramfs together with another filesystem
-	  formats doesn't make sense: you would end up having two
-	  identical root filesystems, one embedded inside the kernel
-	  image, and one separately.
-
 comment "initramfs needs a Linux kernel to be built"
 	depends on !BR2_LINUX_KERNEL
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 initramfs: drop comment against multiple formats

Hi Peter,

Quoted 11 lines · Peter Korsgaard
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vivien" == Vivien Didelot <[email protected]> writes:

This patch removes an old comment against having multiple filesystem formats which doesn't bring any value.

It is also wrong per-se: one may want to use Buildroot to prepare a custom distribution containing a kernel+initramfs and a persistent default rootfs to pivot to.

Yes, but in that case the final persistent rootfs would contain different files than the initramfs, right?

Not necessarily. You can prepare one rootfs base containing an init logic which detects the initrd and eventually formats a partition, extracts a persistent version, pivots root etc.

The persistent storage can evolve from there by the mean of a package manager or whatever the board is meant to do with the persistent storage.

Quoted 3 lines

E.G. I handle such a use case by two different defconfigs, one building the Linux kernel + initramfs and another for the final persistent rootfs.

My point is that it is actually possible to do so, and Buildroot allows that, so this message has currently no value. So I suggest either we prevent one to have a built-in initramfs enabled as well as other rootfs formats (which seems to be a subjective limitation to me) or we get rid of this message and let the user generate all formats she wants.

Best,

Vivien

#3 lore raw

PATCH 1/1 initramfs: drop comment against multiple formats

In reply to Vivien Didelot

Hello Vivien,

Quoted 8 lines · On Fri, 25 Jan 2019 19:19:01 -0500 Vivien Didelot <[email protected]>…

This patch removes an old comment against having multiple filesystem formats which doesn't bring any value.

It is also wrong per-se: one may want to use Buildroot to prepare a custom distribution containing a kernel+initramfs and a persistent default rootfs to pivot to.

I understand your point, but I think we need to keep a comment. Indeed, the use-cases for generating both an initramfs and another rootfs image are very specific, and users (especially newcomers!) should still understand that when building an initramfs with Buildroot, it's the entire root filesystem that goes in the initramfs.

Perhaps we should reword it like this:

Note that enabling this initramfs option together with another filesystem format may not make sense: you would end up having two identical root filesystems, one embedded inside the kernel image (initramfs) and one separately. Indeed, Buildroot is unable to generate an initramfs with different contents than the root filesystem. However, we still allow generating both an initramfs and a normal rootfs image in the same configuration as they are some specific use-cases for it.

Would that work for you ?

Best regards,

Thomas Petazzoni

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 initramfs: drop comment against multiple formats

Hi Thomas,

Quoted 31 lines · Thomas Petazzoni

Hello Vivien,

Quoted 8 lines · On Fri, 25 Jan 2019 19:19:01 -0500 Vivien Didelot <[email protected]>…

This patch removes an old comment against having multiple filesystem formats which doesn't bring any value.

It is also wrong per-se: one may want to use Buildroot to prepare a custom distribution containing a kernel+initramfs and a persistent default rootfs to pivot to.

I understand your point, but I think we need to keep a comment. Indeed, the use-cases for generating both an initramfs and another rootfs image are very specific, and users (especially newcomers!) should still understand that when building an initramfs with Buildroot, it's the entire root filesystem that goes in the initramfs.

Perhaps we should reword it like this:

Note that enabling this initramfs option together with another filesystem format may not make sense: you would end up having two identical root filesystems, one embedded inside the kernel image (initramfs) and one separately. Indeed, Buildroot is unable to generate an initramfs with different contents than the root filesystem. However, we still allow generating both an initramfs and a normal rootfs image in the same configuration as they are some specific use-cases for it.

Quoted 1 line

Would that work for you ?

Yes, that would work.

Thanks,
Vivien