Skip to contentSkip to conversation

libftdi1: fix python build with cmake < 3.7

PATCH New Fabrice Fontaine 2 participants 3 messages Jan 20, 2019 – Jan 29, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 libftdi1: fix python build with cmake < 3.7

Fixes:
- http://autobuild.buildroot.org/results/1091872e2b77d789e361d1ddefd235c738933c55

---
Changes v1 -> v2 (after review of Baruch Siach):
- Move fix to existing fourth patch

 package/libftdi1/0004-cmake-find-swig.patch | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/libftdi1/0004-cmake-find-swig.patch +4 -1
index 25922cca53..cf787a6806 100644
@@ -10,6 +10,9 @@ Signed-off-by: Eneas U de Queiroz <[email protected]>
 [Mark: patch retrieved and updated from
 http://developer.intra2net.com/git/?p=libftdi;a=commit;h=fcda9c6a208d3a7fe651ef661b2eb6e462a89c17]
 Signed-off-by: Mark Corbin <[email protected]>
+[Update patch to make it work with cmake < 3.7:
+http://developer.intra2net.com/mailarchive/html/libftdi/2019/msg00009.html]
+Signed-off-by: Fabrice Fontaine <[email protected]>
 ---
 diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
 index 31ef1c6..eefc344 100644
@@ -20,7 +23,7 @@ index 31ef1c6..eefc344 100644
  if ( PYTHON_BINDINGS )
    # workaround for cmake bug #0013449
 -  if ( NOT DEFINED CMAKE_FIND_ROOT_PATH )
-+  if ( NOT DEFINED CMAKE_FIND_ROOT_PATH OR CMAKE_VERSION VERSION_GREATER_EQUAL 3.0.0 )
++  if ( NOT DEFINED CMAKE_FIND_ROOT_PATH OR NOT CMAKE_VERSION VERSION_LESS 3.0.0 )
      find_package ( SWIG )
    else ()
      find_program ( SWIG_EXECUTABLE NAMES swig2.0 swig )
Signature · 1 line
2.14.1
#1 lore raw

PATCH v2 1/1 libftdi1: fix python build with cmake < 3.7

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Fixes:
- http://autobuild.buildroot.org/results/1091872e2b77d789e361d1ddefd235c738933c55

---
Changes v1 -> v2 (after review of Baruch Siach):
- Move fix to existing fourth patch

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH v2 1/1 libftdi1: fix python build with cmake < 3.7

In reply to Fabrice Fontaine
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Fixes:
- http://autobuild.buildroot.org/results/1091872e2b77d789e361d1ddefd235c738933c55

---
Changes v1 -> v2 (after review of Baruch Siach):
- Move fix to existing fourth patch

Committed to 2018.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard