configs/chiliboard: remove explicit getty port
PATCH 1/1 configs/chiliboard: remove explicit getty port
Using default value (console) works well, so there is no reason to set tty explicitly. Additionally after selecting newer kernels (tested with 4.19 and 4.20-rc3) ttyO0 no longer works due to missing device node.
--- configs/grinn_chiliboard_defconfig | 1 - 1 file changed, 1 deletion(-)
configs/grinn_chiliboard_defconfig +0 -1
@@ -1,7 +1,6 @@ BR2_arm=y BR2_cortex_a8=y BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_16=y -BR2_TARGET_GENERIC_GETTY_PORT="ttyO0" BR2_SYSTEM_DHCP="eth0" BR2_ROOTFS_POST_IMAGE_SCRIPT="board/grinn/chiliboard/post-image.sh" BR2_LINUX_KERNEL=y
Signature · 1 line
2.19.1
PATCH 1/1 configs/chiliboard: remove explicit getty port
Quoted 4 lines · Marcin Niestroj
Using default value (console) works well, so there is no reason to set tty explicitly. Additionally after selecting newer kernels (tested with 4.19 and 4.20-rc3) ttyO0 no longer works due to missing device node.
Actually, does it still work with the 4.16 kernel? IIRC the ttyO were replaced
by the standard ttyS ages ago (like, 3.18 or something like that). If it doesn't work with the 4.16 kernel, it should be applied to master.
Anyway,
Regards,
Arnout
Quoted 19 lines
Signed-off-by Marcin Niestroj <[email protected]>--- configs/grinn_chiliboard_defconfig | 1 - 1 file changed, 1 deletion(-)configs/grinn_chiliboard_defconfig +0
-1@@ -1,7 +1,6 @@ BR2_arm=y BR2_cortex_a8=y BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_16=y -BR2_TARGET_GENERIC_GETTY_PORT="ttyO0" BR2_SYSTEM_DHCP="eth0" BR2_ROOTFS_POST_IMAGE_SCRIPT="board/grinn/chiliboard/post-image.sh" BR2_LINUX_KERNEL=y
PATCH 1/1 configs/chiliboard: remove explicit getty port
Hi Arnout,
Quoted 10 lines · Arnout Vandecappelle
Quoted 4 lines · Marcin Niestroj
Using default value (console) works well, so there is no reason to set tty explicitly. Additionally after selecting newer kernels (tested with 4.19 and 4.20-rc3) ttyO0 no longer works due to missing device node.
Actually, does it still work with the 4.16 kernel? IIRC the ttyO were replaced
by the standard ttyS ages ago (like, 3.18 or something like that). If it doesn't work with the 4.16 kernel, it should be applied to master.
Yes, it still works with 4.16. There are /dev/ttyS[0-5] and /dev/ttyO0 nodes. In case of 4.19 and 4.20 there is no /dev/ttyO0 anymore, but I did not get into the exact reason what changed. I just checked how other boards configure getty in Buildroot and it turns out most of them leave the default value.
Quoted 3 lines
Anyway,
Thanks!
Regards,
Marcin
Quoted 23 lines
Regards,
ArnoutQuoted 19 lines
Signed-off-by Marcin Niestroj <[email protected]>--- configs/grinn_chiliboard_defconfig | 1 - 1 file changed, 1 deletion(-)configs/grinn_chiliboard_defconfig +0
-1@@ -1,7 +1,6 @@ BR2_arm=y BR2_cortex_a8=y BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_16=y -BR2_TARGET_GENERIC_GETTY_PORT="ttyO0" BR2_SYSTEM_DHCP="eth0" BR2_ROOTFS_POST_IMAGE_SCRIPT="board/grinn/chiliboard/post-image.sh" BR2_LINUX_KERNEL=y
PATCH 1/1 configs/chiliboard: remove explicit getty port
In reply to Marcin NiestrojQuoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Marcin" == Marcin Niestroj <[email protected]> writes:
Using default value (console) works well, so there is no reason to set tty explicitly. Additionally after selecting newer kernels (tested with 4.19 and 4.20-rc3) ttyO0 no longer works due to missing device node.
Do you know why this is so? Did ttyO0 get renamed?
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 configs/chiliboard: remove explicit getty port
Quoted 8 lines · Peter Korsgaard
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Marcin" == Marcin Niestroj <[email protected]> writes:
Using default value (console) works well, so there is no reason to set tty explicitly. Additionally after selecting newer kernels (tested with 4.19 and 4.20-rc3) ttyO0 no longer works due to missing device node.
Do you know why this is so? Did ttyO0 get renamed?
I don't know what exactly has changed, as I have not investigated it deeply. I think that CONFIG_SERIAL_8250_OMAP_TTYO_FIXUP changed the behavior a little bit, so now there are only ttySx devices, with no ttyOx anymore. Another possibility is that ttyO0 was created in older kernel versions, because it was passed by u-boot directly as boot argument to kernel.
Quoted 2 lines
Committed, thanks.
Thanks!
--
Marcin Niestr?j