Skip to contentSkip to conversation

samba4: ensure that copied cache.txt is writable

PATCH New Danomi Manchego 3 participants 3 messages Nov 29, 2017 – Dec 20, 2017

lore
Share & tools
lore

Danomi Manchego

author
#0 lore raw

PATCH 1/1 samba4: ensure that copied cache.txt is writable

If the Buildroot tree is read-only, then cache.txt is copied read-only into the build directory, and the configuration step fails. Fix this in the same way we do in other places, by opening permissions as we copy the file using $(INSTALL).

Signed-off-by Danomi Manchego <[email protected]>
---
 package/samba4/samba4.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/samba4/samba4.mk +1 -1
index 7836df5..ade9add 100644
@@ -86,7 +86,7 @@ endef
 SAMBA4_POST_INSTALL_TARGET_HOOKS += SAMBA4_REMOVE_CTDB_TESTS
 
 define SAMBA4_CONFIGURE_CMDS
-	cp package/samba4/samba4-cache.txt $(@D)/cache.txt;
+	$(INSTALL) -m 0644 package/samba4/samba4-cache.txt $(@D)/cache.txt;
 	echo 'Checking uname machine type: $(BR2_ARCH)' >>$(@D)/cache.txt;
 	(cd $(@D); \
 		PYTHON_CONFIG="$(STAGING_DIR)/usr/bin/python-config" \
Signature · 1 line
2.7.4
Applied
#1 lore raw

PATCH 1/1 samba4: ensure that copied cache.txt is writable

Hello,

Quoted 9 lines · Danomi Manchego

If the Buildroot tree is read-only, then cache.txt is copied read-only into the build directory, and the configuration step fails. Fix this in the same way we do in other places, by opening permissions as we copy the file using $(INSTALL).

Signed-off-by Danomi Manchego <[email protected]>
---
 package/samba4/samba4.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 samba4: ensure that copied cache.txt is writable

In reply to Danomi Manchego
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Danomi" == Danomi Manchego <[email protected]> writes:

If the Buildroot tree is read-only, then cache.txt is copied read-only into the build directory, and the configuration step fails. Fix this in the same way we do in other places, by opening permissions as we copy the file using $(INSTALL).

Signed-off-by Danomi Manchego <[email protected]>

Committed to 2017.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard