Set ramdisk_addr_r to a higher address location on meson-gxbb.

PATCH New Vagrant Cascadian 3 participants 6 messages Apr 12, 2017 – Apr 16, 2017 Arm/Amlogic Meson SoC support

Share & tools

Vagrant Cascadian

author

2017-04-12 21:28 UTC #0 lore raw

PATCH 1/1 Set ramdisk_addr_r to a higher address location on meson-gxbb.

Set ramdisk_addr_r to 0x20000000, otherwise it may conflict with kernel_addr_r location (0x01080000) with a moderately large kernel.

Signed-off-by Vagrant Cascadian <[email protected]>

---

 include/configs/meson-gxbb-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/configs/meson-gxbb-common.h +1 -1

index cc2b5b61d4..32602cb7c2 100644
@@ -48,7 +48,7 @@
 	"scriptaddr=0x1f000000\0" \
 	"kernel_addr_r=0x01080000\0" \
 	"pxefile_addr_r=0x01080000\0" \
-	"ramdisk_addr_r=0x10000000\0" \
+	"ramdisk_addr_r=0x20000000\0" \
 	MESON_FDTFILE_SETTING \
 	BOOTENV

Signature · 1 line

2.11.0

Tom Rini

2017-04-12 21:35 UTC #1 lore raw

PATCH 1/1 Set ramdisk_addr_r to a higher address location on meson-gxbb.

Quoted 14 lines · Vagrant Cascadian

Set ramdisk_addr_r to 0x20000000, otherwise it may conflict with kernel_addr_r location (0x01080000) with a moderately large kernel.
Signed-off-by Vagrant Cascadian <[email protected]>
---
 include/configs/meson-gxbb-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/meson-gxbb-common.h +0 -0
index cc2b5b61d4..32602cb7c2 100644

include/configs/meson-gxbb-common.h line 51

Quoted 5 lines

include/configs/meson-gxbb-common.h +1 -1

@@ -48,7 +48,7 @@
 	"scriptaddr=0x1f000000\0" \
 	"kernel_addr_r=0x01080000\0" \
 	"pxefile_addr_r=0x01080000\0" \
-	"ramdisk_addr_r=0x10000000\0" \
+	"ramdisk_addr_r=0x20000000\0" \

We also need to start setting bootm_size. Quoting myself from include/configs/ti_armv7_common.h:
/*
* We setup defaults based on constraints from the Linux kernel, which should
* also be safe elsewhere. We have the default load at 32MB into DDR (for
* the kernel), FDT above 128MB (the maximum location for the end of the
* kernel), and the ramdisk 512KB above that (allowing for hopefully never
* seen large trees). We say all of this must be within the first 256MB
* as that will normally be within the kernel lowmem and thus visible via
* bootm_size and we only run on platforms with 256MB or more of memory. */
...

        "bootm_size=0x10000000\0" \

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170412/961fb2fa/attachment.sig>

Vagrant Cascadian

author

2017-04-14 20:49 UTC #2 lore raw

PATCH 1/1 Set ramdisk_addr_r to a higher address location on meson-gxbb.

Quoted 12 lines · Tom Rini

We also need to start setting bootm_size. Quoting myself from include/configs/ti_armv7_common.h:
/*
* We setup defaults based on constraints from the Linux kernel, which should
* also be safe elsewhere. We have the default load at 32MB into DDR (for
* the kernel), FDT above 128MB (the maximum location for the end of the
* kernel), and the ramdisk 512KB above that (allowing for hopefully never
* seen large trees). We say all of this must be within the first 256MB
* as that will normally be within the kernel lowmem and thus visible via
* bootm_size and we only run on platforms with 256MB or more of memory. */
...

Quoted 1 line

        "bootm_size=0x10000000\0" \

I mostly add the variables defined in doc/README.distro for boards I'm adding distro_bootcmd support to, and there's no mention of bootm_size there.

Are there other places that it would make more sense to document or add documentation for this variable setting?

Does bootm_size impact bootz/booti as well, or is it just used with bootm?

live well,
vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170414/b8412291/attachment.sig>

Andreas Färber

2017-04-12 21:35 UTC #3 lore raw

PATCH 1/1 Set ramdisk_addr_r to a higher address location on meson-gxbb.

In reply to Vagrant Cascadian

Am 12.04.2017 um 23:28 schrieb Vagrant Cascadian:

Quoted 14 lines

Set ramdisk_addr_r to 0x20000000, otherwise it may conflict with kernel_addr_r location (0x01080000) with a moderately large kernel.
Signed-off-by Vagrant Cascadian <[email protected]>
---
 include/configs/meson-gxbb-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/meson-gxbb-common.h +0 -0
index cc2b5b61d4..32602cb7c2 100644

include/configs/meson-gxbb-common.h line 51

Quoted 5 lines

include/configs/meson-gxbb-common.h +1 -1

@@ -48,7 +48,7 @@
 	"scriptaddr=0x1f000000\0" \
 	"kernel_addr_r=0x01080000\0" \
 	"pxefile_addr_r=0x01080000\0" \
-	"ramdisk_addr_r=0x10000000\0" \
+	"ramdisk_addr_r=0x20000000\0" \

So that's at 512 MiB. Have you checked for any S905 devices (e.g., TV boxes) with little RAM?

No objection here, I'm not using $ram_addr_r on S905 due to GRUB.

include/configs/meson-gxbb-common.h line 54

Quoted 3 lines

include/configs/meson-gxbb-common.h +0 -0
 	MESON_FDTFILE_SETTING \
 	BOOTENV
 

Regards,
Andreas

Signature · 3 lines

SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

Vagrant Cascadian

author

2017-04-12 23:59 UTC #4 lore raw

PATCH 1/1 Set ramdisk_addr_r to a higher address location on meson-gxbb.

Quoted 3 lines · Andreas FÃ¤rber

Am 12.04.2017 um 23:28 schrieb Vagrant Cascadian:
Quoted 2 lines
Set ramdisk_addr_r to 0x20000000, otherwise it may conflict with kernel_addr_r location (0x01080000) with a moderately large kernel.

...

Quoted 5 lines

Quoted 5 lines
include/configs/meson-gxbb-common.h +0 -0
index cc2b5b61d4..32602cb7c2 100644
@@ -48,7 +48,7 @@

Quoted 8 lines

include/configs/meson-gxbb-common.h line 51
Quoted 5 lines
include/configs/meson-gxbb-common.h +1 -1
 	"scriptaddr=0x1f000000\0" \
 	"kernel_addr_r=0x01080000\0" \
 	"pxefile_addr_r=0x01080000\0" \
-	"ramdisk_addr_r=0x10000000\0" \
+	"ramdisk_addr_r=0x20000000\0" \
So that's at 512 MiB. Have you checked for any S905 devices (e.g., TV boxes) with little RAM?

I didn't. I just picked a value out of the air and tried it. :)

I just now tested with 0x12000000 and it worked, where 0x10000000 consistantly failed.

Debian ships a largely modular multiplatform kernel, so should be on the small side, and the current value (0x10000000) conflicted.

Not sure how much of a buffer 0x12000000 gives for the kernel to grow, but that's considerably less than 0x20000000 (at 512MiB), and still works for me so far...

Vagrant Cascadian

author

2017-04-16 21:27 UTC #5 lore raw

PATCH 1/1 Set ramdisk_addr_r to a higher address location on meson-gxbb.

Quoted 19 lines · Vagrant Cascadian

Quoted 3 lines · Andreas FÃ¤rber
Am 12.04.2017 um 23:28 schrieb Vagrant Cascadian:
Quoted 2 lines
Set ramdisk_addr_r to 0x20000000, otherwise it may conflict with kernel_addr_r location (0x01080000) with a moderately large kernel.
...
Quoted 5 lines
Quoted 5 lines
include/configs/meson-gxbb-common.h +0 -0
index cc2b5b61d4..32602cb7c2 100644
@@ -48,7 +48,7 @@
Quoted 8 lines
include/configs/meson-gxbb-common.h line 51
Quoted 5 lines
include/configs/meson-gxbb-common.h +1 -1
 	"scriptaddr=0x1f000000\0" \
 	"kernel_addr_r=0x01080000\0" \
 	"pxefile_addr_r=0x01080000\0" \
-	"ramdisk_addr_r=0x10000000\0" \
+	"ramdisk_addr_r=0x20000000\0" \
So that's at 512 MiB. Have you checked for any S905 devices (e.g., TV boxes) with little RAM?

Quoted 1 line

I didn't. I just picked a value out of the air and tried it. :)

The other option is to lower the kernel_addr_r and fdt_addr_r locations, but I'm not sure how much lower they can get, if at all.

Quoted 2 lines

I just now tested with 0x12000000 and it worked, where 0x10000000 consistantly failed.

After some more experimenting, with ramdisk_addr_r=0x10100000 it still fails to load, with ramdisk_addr_r=0x10200000 it works, at least with the current kernel I'm testing with:

=> setenv ramdisk_addr_r 0x10100000
=> boot
switch to partitions #0, OK
mmc0 is current device
Scanning mmc 0:1...
Found U-Boot script /boot.scr
2177 bytes read in 16 ms (132.8 KiB/s)
## Executing script at 1f000000
14819840 bytes read in 737 ms (19.2 MiB/s)
16119 bytes read in 38 ms (414.1 KiB/s)
17551127 bytes read in 873 ms (19.2 MiB/s)
Booting Debian 4.11.0-rc6+ from mmc 0:1...
## Flattened Device Tree blob at 01000000
Booting using the fdt blob at 0x1000000
Loading Ramdisk to 7ce9c000, end 7df58f17 ... OK
Loading Device Tree to 000000007ce95000, end 000000007ce9bef6 ... OK

Starting kernel ...

And then it just hangs.

The kernel image I'm booting is almost 15MB, uncompressed. I'm guessing if "booti" would support compressed kernels, this would allieviate the problem, but it will take some time before that's common (on Debian, at least).