Skip to contentSkip to conversation

ncurses: Add libcurses symlink to libncurses

PATCH New Vicente Olivert Riera 3 participants 5 messages Sep 23, 2014 – Sep 25, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ncurses: Add libcurses symlink to libncurses

Some packages use -lcurses when they are linking, so they try to link to a library called libcurses. The library provided by our ncurses package is called libncurses, so those packages fail to link with a message like this one:

/bin/ld: cannot find -lcurses

Installing a libcurses symlink to libncurses fixes the problem.

Fixes:
http://autobuild.buildroot.net/results/466/466995f9534447a4f54327a14c44ef9e16dd1123/

---
 package/ncurses/ncurses.mk |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
package/ncurses/ncurses.mk +6 -0
index 81a3998..3f57407 100644
@@ -46,6 +46,8 @@ define NCURSES_LINK_LIBS
 		ln -sf $${lib}$(NCURSES_LIB_SUFFIX).a \
 			$(1)/usr/lib/$${lib}.a; \
 	done
+	ln -sf libncurses$(NCURSES_LIB_SUFFIX).a \
+		$(1)/usr/lib/libcurses.a
 endef
 else
 define NCURSES_LINK_LIBS
@@ -55,6 +57,10 @@ define NCURSES_LINK_LIBS
 		ln -sf $${lib}$(NCURSES_LIB_SUFFIX).so \
 			$(1)/usr/lib/$${lib}.so; \
 	done
+	ln -sf libncurses$(NCURSES_LIB_SUFFIX).a \
+		$(1)/usr/lib/libcurses.a
+	ln -sf libncurses$(NCURSES_LIB_SUFFIX).so \
+		$(1)/usr/lib/libcurses.so
 endef
 endif
 
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 ncurses: Add libcurses symlink to libncurses

Dear Vicente Olivert Riera,

Quoted 4 lines · Vicente Olivert Riera

Some packages use -lcurses when they are linking, so they try to link to a library called libcurses. The library provided by our ncurses package is called libncurses, so those packages fail to link with a message like this one:

Can you define "some" in "Some packages" ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 ncurses: Add libcurses symlink to libncurses

Quoted 8 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 4 lines · Vicente Olivert Riera

Some packages use -lcurses when they are linking, so they try to link to a library called libcurses. The library provided by our ncurses package is called libncurses, so those packages fail to link with a message like this one:

Quoted 5 lines

Can you define "some" in "Some packages" ?

Thanks!

Thomas

Hi Thomas,

there is an autobuild report at the bottom of the commit message where you can see a package which is failing due to that problem.

Signature · 1 line
Vincent
#3 lore raw

PATCH 1/1 ncurses: Add libcurses symlink to libncurses

Dear Vicente Olivert Riera,

Quoted 2 lines · Vicente Olivert Riera

there is an autobuild report at the bottom of the commit message where you can see a package which is failing due to that problem.

Indeed, I missed it. Sorry for the silly comment. Patch looks good to me.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 ncurses: Add libcurses symlink to libncurses

In reply to Vicente Olivert Riera
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

Some packages use -lcurses when they are linking, so they try to link to a library called libcurses. The library provided by our ncurses package is called libncurses, so those packages fail to link with a message like this one:

/bin/ld: cannot find -lcurses

Quoted 7 lines

Installing a libcurses symlink to libncurses fixes the problem.

Fixes:
http://autobuild.buildroot.net/results/466/466995f9534447a4f54327a14c44ef9e16dd1123/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard