libtirpc: requires toolchain with threads support
PATCH 1/1 libtirpc: requires toolchain with threads support
Fixes:
http://autobuild.buildroot.org/results/8ba720f47f74df94b8c70ac4befd47c47ce65f2f
--- package/libtirpc/Config.in | 4 ++++ 1 file changed, 4 insertions(+)
package/libtirpc/Config.in +4 -0
@@ -1,7 +1,11 @@ config BR2_PACKAGE_LIBTIRPC bool "libtirpc" + depends on BR2_TOOLCHAIN_HAS_THREADS help Libtirpc is a port of Sun's Transport-Independent RPC library to Linux. http://sourceforge.net/projects/libtirpc/ + +comment "libtirpc requires a toolchain with threads support" + depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.7.10.4
PATCH 1/1 libtirpc: requires toolchain with threads support
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gilles" == Gilles Talis <[email protected]> writes:
Gilles> Fixes:
Gilles> http://autobuild.buildroot.org/results/8ba720f47f74df94b8c70ac4befd47c47ce65f2f
Gilles> Signed-off-by: Gilles Talis <[email protected]> Gilles> ---
Gilles> package/libtirpc/Config.in | 4 ++++
Gilles> 1 file changed, 4 insertions(+)
Gilles> diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in Gilles> index 7e891b4..f2a6f83 100644
Gilles> --- a/package/libtirpc/Config.in
Gilles> +++ b/package/libtirpc/Config.in
Gilles> @@ -1,7 +1,11 @@
Gilles> config BR2_PACKAGE_LIBTIRPC
Gilles> bool "libtirpc"
Gilles> + depends on BR2_TOOLCHAIN_HAS_THREADS
Thanks, but you also need to propagate this dependency to libtirpc's reverse dependencies:
git grep -l 'select BR2_PACKAGE_LIBTIRPC'
package/conntrack-tools/Config.in
package/lmbench/Config.in
package/nfs-utils/Config.in
package/quota/Config.in
package/rpcbind/Config.in
Care to fix that up and resend?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 libtirpc: requires toolchain with threads support
Good point.
Will fix and resend.
Gilles.
2013/2/10 Peter Korsgaard <[email protected]>
Quoted 31 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gilles" == Gilles Talis <[email protected]> writes:
Gilles> Fixes:
Gilles>
http://autobuild.buildroot.org/results/8ba720f47f74df94b8c70ac4befd47c47ce65f2fGilles> Signed-off-by: Gilles Talis <[email protected]> Gilles> ---
Gilles> package/libtirpc/Config.in | 4 ++++Gilles> 1 file changed, 4 insertions(+)
Gilles> diff --git a/package/libtirpc/Config.in
b/package/libtirpc/Config.in
Gilles> index 7e891b4..f2a6f83 100644
Gilles> --- a/package/libtirpc/Config.in
Gilles> +++ b/package/libtirpc/Config.in
Gilles> @@ -1,7 +1,11 @@
Gilles> configBR2_PACKAGE_LIBTIRPC
Gilles> bool "libtirpc"
Gilles> + depends onBR2_TOOLCHAIN_HAS_THREADSThanks, but you also need to propagate this dependency to libtirpc's reverse dependencies:
git grep -l 'select
BR2_PACKAGE_LIBTIRPC'
package/conntrack-tools/Config.in
package/lmbench/Config.in
package/nfs-utils/Config.in
package/quota/Config.in
package/rpcbind/Config.in
Quoted 5 lines
Care to fix that up and resend?
--
Bye, Peter Korsgaard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130210/50a1720c/attachment-0001.html>
PATCH 1/1 libtirpc: requires toolchain with threads support
In reply to Gilles TalisDear Gilles Talis,
Quoted 4 lines · Gilles Talis
Fixes:
http://autobuild.buildroot.org/results/8ba720f47f74df94b8c70ac4befd47c47ce65f2fSigned-off-by Gilles Talis <[email protected]>
I believe libtirpc pthread usage could be made optional, and that would probably be an useful contribution upstream, and avoid us from having to add this toolchain dependency.
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 libtirpc: requires toolchain with threads support
Hi Thomas, all,
2013/2/11 Thomas Petazzoni <[email protected]>:
Quoted 11 lines
Dear Gilles Talis,
Quoted 4 lines · Gilles Talis
Fixes:
http://autobuild.buildroot.org/results/8ba720f47f74df94b8c70ac4befd47c47ce65f2fSigned-off-by Gilles Talis <[email protected]>I believe libtirpc pthread usage could be made optional, and that would probably be an useful contribution upstream, and avoid us from having to add this toolchain dependency.
Some of the recent libtirpc build failures are also caused by this.
Looking at the source, it seems that's a bug the AC_CHECK_LIB call that does not do anything when pthead is not found; though it unconditionally include pthread.h
in many source files, and does not use at all the HAVE_LIBPTHREAD symbol.
Regards,
Signature · 1 line
Samuel
PATCH 1/1 libtirpc: requires toolchain with threads support
Ping?
This patch should fix the following autobuilder failures:
arm | libtirpc-0.2.2 | NOK |
http://autobuild.buildroot.net/results/446d49bcf2b139ccc495d867d898673969823148/
arm | libtirpc-0.2.2 | NOK |
http://autobuild.buildroot.net/results/4d84dfd309d313c8d0248d33bdee43bc7bbfa187/
Regards,
Signature · 4 lines
Samuel -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130830/03347403/attachment.html>