gettext: fix static build failure
PATCH 1/1 gettext: fix static build failure
When static libraries are preferred we don't build dynamic libraries so it fails on the install phase. So don't try to do it for those cases. Fixes:
http://autobuild.buildroot.net/results/651537ae1909b039e0cfc5c104ee87f93a9e5792/
--- package/gettext/gettext.mk | 3 +++ 1 file changed, 3 insertions(+)
package/gettext/gettext.mk +3 -0
@@ -35,9 +35,12 @@ endif # When the gettext tools are not enabled in the configuration, we only # install libintl to the target. ifeq ($(BR2_PACKAGE_GETTEXT_TOOLS),) +# When static libs are preferred the .so files aren't created +ifeq ($(BR2_PREFER_STATIC_LIB),) define GETTEXT_INSTALL_TARGET_CMDS cp -dpf $(STAGING_DIR)/usr/lib/libintl*.so* $(TARGET_DIR)/usr/lib/ endef +endif # Ditch the tools since they're off and pull other dependencies define GETTEXT_DISABLE_TOOLS $(SED) 's/runtime gettext-tools/runtime/' $(@D)/Makefile.in
Signature · 1 line
1.7.12.4
PATCH 1/1 gettext: fix static build failure
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gustavo" == Gustavo Zacarias <[email protected]> writes:
Gustavo> When static libraries are preferred we don't build dynamic libraries so Gustavo> it fails on the install phase. So don't try to do it for those cases. Gustavo> Fixes:
Gustavo> http://autobuild.buildroot.net/results/651537ae1909b039e0cfc5c104ee87f93a9e5792/
Committed, thanks.
We arguably should install the .a file to the target then, but as target-gcc is going away ..
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 gettext: fix static build failure
Quoted 4 lines · Peter Korsgaard
Committed, thanks.
We arguably should install the .a file to the target then, but as target-gcc is going away ..
Yes, completely on purpose.
There are probably other packages that don't do it either, so there's not much point in looking around and fixing it for an option that's going away.
Regards.