Skip to contentSkip to conversation

libfreefare: add missing openssl dependency

PATCH New spdawson at gmail.com 3 participants 4 messages Jun 17, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libfreefare: add missing openssl dependency

From: Simon Dawson <[email protected]>

If openssl is not selected, configuration fails for the libfreefare package as follows.

configure: error: Cannot find libcrypto.

This patch adds the missing dependency on openssl.

---
 package/libfreefare/Config.in      |    4 ++++
 package/libfreefare/libfreefare.mk |    2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
package/libfreefare/Config.in +4 -0
index 2e11f7e..438bcbf 100644
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_LIBFREEFARE
 	bool "libfreefare"
+	depends on BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_LIBNFC
 	help
 	  Library for high level manipulation of MIFARE cards.
 
 	  http://code.google.com/p/nfc-tools/wiki/libfreefare
+
+comment "libfreefare requires openssl"
+	depends on !BR2_PACKAGE_OPENSSL
package/libfreefare/libfreefare.mk +1 -1
index 0499999..16ef8fb 100644
@@ -5,6 +5,6 @@
 #############################################################
 LIBFREEFARE_VERSION = 0.3.2
 LIBFREEFARE_SITE = http://nfc-tools.googlecode.com/files
-LIBFREEFARE_DEPENDENCIES = libnfc
+LIBFREEFARE_DEPENDENCIES = libnfc openssl
 
 $(eval $(call AUTOTARGETS))
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 libfreefare: add missing openssl dependency

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"spdawson" == spdawson <[email protected]> writes:

spdawson> From: Simon Dawson <[email protected]>
spdawson> If openssl is not selected, configuration fails for the libfreefare package spdawson> as follows.

spdawson> configure: error: Cannot find libcrypto.

spdawson> This patch adds the missing dependency on openssl.

spdawson> Signed-off-by: Simon Dawson <[email protected]> spdawson> ---

 spdawson>  package/libfreefare/Config.in      |    4 ++++
 spdawson>  package/libfreefare/libfreefare.mk |    2 +-

spdawson> 2 files changed, 5 insertions(+), 1 deletion(-)

spdawson> diff --git a/package/libfreefare/Config.in b/package/libfreefare/Config.in spdawson> index 2e11f7e..438bcbf 100644
spdawson> --- a/package/libfreefare/Config.in
spdawson> +++ b/package/libfreefare/Config.in
spdawson> @@ -1,7 +1,11 @@
spdawson> config BR2_PACKAGE_LIBFREEFARE
spdawson> bool "libfreefare"
spdawson> + depends on BR2_PACKAGE_OPENSSL

We normally use 'depends on' for library dependencies (like libnfc), so I've changed that and committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 libfreefare: add missing openssl dependency

Hi Peter,

Quoted 25 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"spdawson" == spdawson <[email protected]> writes:

spdawson> From: Simon Dawson <[email protected]>
spdawson> If openssl is not selected, configuration fails for the libfreefare package spdawson> as follows.

spdawson> configure: error: Cannot find libcrypto.

spdawson> This patch adds the missing dependency on openssl.

spdawson> Signed-off-by: Simon Dawson <[email protected]> spdawson> ---

 spdawson>  package/libfreefare/Config.in      |    4 ++++
 spdawson>  package/libfreefare/libfreefare.mk |    2 +-

spdawson> 2 files changed, 5 insertions(+), 1 deletion(-)

spdawson> diff --git a/package/libfreefare/Config.in b/package/libfreefare/Config.in spdawson> index 2e11f7e..438bcbf 100644
spdawson> --- a/package/libfreefare/Config.in
spdawson> +++ b/package/libfreefare/Config.in
spdawson> @@ -1,7 +1,11 @@
spdawson> config BR2_PACKAGE_LIBFREEFARE
spdawson> bool "libfreefare"
spdawson> + depends on BR2_PACKAGE_OPENSSL

Quoted 2 lines

We normally use 'depends on' for library dependencies (like libnfc), so I've changed that and committed, thanks.

s/depends on/select/

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#3 lore raw

PATCH 1/1 libfreefare: add missing openssl dependency

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

spdawson> config BR2_PACKAGE_LIBFREEFARE
spdawson> bool "libfreefare"
spdawson> + depends on BR2_PACKAGE_OPENSSL

Quoted 3 lines
Quoted 3 lines

We normally use 'depends on' for library dependencies (like libnfc), so I've changed that and committed, thanks.

Baruch> s/depends on/select/

Yes ;)

Signature · 1 line
Bye, Peter Korsgaard