Skip to contentSkip to conversation

Pull request for branch genautotargets-conversion

GIT PULL New Thomas Petazzoni 2 participants 9 messages Jul 25, 2010 – Jul 27, 2010

lore
Share & tools
lore
#0 lore raw

The following changes since commit 3435c1afb58307240be8e4607b5bb7d239fac4e9:
Peter Korsgaard (1):
kconfig: implement KCONFIG_PROBABILITY for rand{,package}config

are available in the git repository at:

git://git.busybox.net/~tpetazzoni/git/buildroot genautotargets-conversion

Thomas Petazzoni (4):
ltrace: convert to gentargets and bump to 0.5.3
tftpd: convert to autotargets
setserial: convert to autotargets and fix bug 2269 Deprecate pcmcia and microwin packages

 package/ltrace/ltrace-0.5-00-susv3-legacy.patch    |   11 --
 package/ltrace/ltrace-0.5.3-configure-fixes.patch  |  128 ++++++++++++++++++++
 package/ltrace/ltrace-0.5.3-susv3-legacy.patch     |   20 +++
 package/ltrace/ltrace.mk                           |   90 ++++-----------
 package/microwin/Config.in                         |    2 +
 package/pcmcia/Config.in                           |    2 +
 .../setserial-2.17-build-system-fix.patch          |   28 +++++
 package/setserial/setserial.mk                     |   16 ++-
 package/tftpd/tftpd.mk                             |   83 ++-----------
 9 files changed, 220 insertions(+), 160 deletions(-)
 delete mode 100644 package/ltrace/ltrace-0.5-00-susv3-legacy.patch
 create mode 100644 package/ltrace/ltrace-0.5.3-configure-fixes.patch
 create mode 100644 package/ltrace/ltrace-0.5.3-susv3-legacy.patch
 create mode 100644 package/setserial/setserial-2.17-build-system-fix.patch

Thanks,

Signature · 1 line
Thomas Petazzoni
#1 lore raw

PATCH 1/4 ltrace: convert to gentargets and bump to 0.5.3

---
 package/ltrace/ltrace-0.5-00-susv3-legacy.patch   |   11 --
 package/ltrace/ltrace-0.5.3-configure-fixes.patch |  128 +++++++++++++++++++++
 package/ltrace/ltrace-0.5.3-susv3-legacy.patch    |   20 +++
 package/ltrace/ltrace.mk                          |   90 ++++-----------
 4 files changed, 170 insertions(+), 79 deletions(-)
 delete mode 100644 package/ltrace/ltrace-0.5-00-susv3-legacy.patch
 create mode 100644 package/ltrace/ltrace-0.5.3-configure-fixes.patch
 create mode 100644 package/ltrace/ltrace-0.5.3-susv3-legacy.patch
package/ltrace/ltrace-0.5-00-susv3-legacy.patch deleted +0 -11
deleted file mode 100644
index 7518124..0000000
@@ -1,11 +0,0 @@
---- ltrace-0.5.orig/read_config_file.c	2006-02-20 22:48:07.000000000 +0100
-+++ ltrace-0.5/read_config_file.c	2007-10-02 12:18:21.000000000 +0200
-@@ -57,7 +57,7 @@
- 
- 	while (tmp->name) {
- 		if (!strncmp(*str, tmp->name, strlen(tmp->name))
--		    && index(" ,)#", *(*str + strlen(tmp->name)))) {
-+		    && strchr(" ,)#", *(*str + strlen(tmp->name)))) {
- 			*str += strlen(tmp->name);
- 			return tmp->pt;
- 		}
package/ltrace/ltrace-0.5.3-configure-fixes.patch new file +128 -0

128 lines not on this page · raw message

package/ltrace/ltrace-0.5.3-susv3-legacy.patch new file +20 -0
new file mode 100644
index 0000000..4c9bb8a
@@ -0,0 +1,20 @@
+Use the strchr() function instead of the legacy index() function.
+
+Signed-off-by: Thomas Petazzoni <[email protected]>
+---
+ read_config_file.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+Index: ltrace-0.5.3/read_config_file.c
+===================================================================
+--- ltrace-0.5.3.orig/read_config_file.c
++++ ltrace-0.5.3/read_config_file.c
+@@ -83,7 +83,7 @@
+ 
+ 	while (tmp->name) {
+ 		if (!strncmp(*str, tmp->name, strlen(tmp->name))
+-				&& index(" ,()#*;012345[", *(*str + strlen(tmp->name)))) {
++				&& strchr(" ,()#*;012345[", *(*str + strlen(tmp->name)))) {
+ 			*str += strlen(tmp->name);
+ 			return lookup_prototype(tmp->pt);
+ 		}
package/ltrace/ltrace.mk +22 -68

107 lines not on this page · raw message

Signature · 1 line
1.7.0.4
#2 lore raw

PATCH 2/4 tftpd: convert to autotargets

In reply to Thomas Petazzoni
---
 package/tftpd/tftpd.mk |   83 +++++------------------------------------------
 1 files changed, 9 insertions(+), 74 deletions(-)
package/tftpd/tftpd.mk +9 -74
index 795aab6..c4242f1 100644
@@ -3,79 +3,14 @@
 # tftpd
 #
 #############################################################
-TFTP_HPA_VERSION:=0.40
-TFTP_HPA_SOURCE:=tftp-hpa-$(TFTP_HPA_VERSION).tar.bz2
-TFTP_HPA_SITE:=$(BR2_KERNEL_MIRROR)/software/network/tftp/
-TFTP_HPA_DIR:=$(BUILD_DIR)/tftp-hpa-$(TFTP_HPA_VERSION)
-TFTP_HPA_CAT:=$(BZCAT)
-TFTP_HPA_BINARY:=tftpd/tftpd
-TFTP_HPA_TARGET_BINARY:=usr/sbin/in.tftpd
+TFTPD_VERSION  = 5.0
+TFTPD_SOURCE   = tftp-hpa-$(TFTPD_VERSION).tar.bz2
+TFTPD_SITE     = $(BR2_KERNEL_MIRROR)/software/network/tftp/
+TFTPD_CONF_OPT = --without-tcpwrappers
 
-$(DL_DIR)/$(TFTP_HPA_SOURCE):
-	 $(call DOWNLOAD,$(TFTP_HPA_SITE),$(TFTP_HPA_SOURCE))
+define TFTPD_INSTALL_TARGET_CMDS
+	$(INSTALL) -D $(@D)/tftpd/tftpd $(TARGET_DIR)/usr/sbin/tftpd
+	$(INSTALL) -D package/tftpd/S80tftpd-hpa $(TARGET_DIR)/etc/init.d/
+endef
 
-tftpd-source: $(DL_DIR)/$(TFTP_HPA_SOURCE)
-
-$(TFTP_HPA_DIR)/.unpacked: $(DL_DIR)/$(TFTP_HPA_SOURCE)
-	$(TFTP_HPA_CAT) $(DL_DIR)/$(TFTP_HPA_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
-	toolchain/patch-kernel.sh $(TFTP_HPA_DIR) package/tftpd/ tftpd\*.patch
-	touch $(TFTP_HPA_DIR)/.unpacked
-
-$(TFTP_HPA_DIR)/.configured: $(TFTP_HPA_DIR)/.unpacked
-	(cd $(TFTP_HPA_DIR); rm -rf config.cache; \
-		$(TARGET_CONFIGURE_OPTS) \
-		$(TARGET_CONFIGURE_ARGS) \
-		./configure $(QUIET) \
-		--target=$(GNU_TARGET_NAME) \
-		--host=$(GNU_TARGET_NAME) \
-		--build=$(GNU_HOST_NAME) \
-		--prefix=/usr \
-		--exec-prefix=/usr \
-		--bindir=/usr/bin \
-		--sbindir=/usr/sbin \
-		--libdir=/lib \
-		--libexecdir=/usr/lib \
-		--sysconfdir=/etc \
-		--datadir=/usr/share \
-		--localstatedir=/var \
-		--mandir=/usr/man \
-		--infodir=/usr/info \
-		$(DISABLE_LARGEFILE) \
-		--without-tcpwrappers \
-	)
-	touch $(TFTP_HPA_DIR)/.configured
-
-$(TFTP_HPA_DIR)/$(TFTP_HPA_BINARY): $(TFTP_HPA_DIR)/.configured
-	$(MAKE) -C $(TFTP_HPA_DIR)
-
-# This stuff is needed to work around GNU make deficiencies
-$(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY): $(TFTP_HPA_DIR)/$(TFTP_HPA_BINARY)
-	@if [ -L $(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY) ]; then \
-		rm -f $(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY); fi
-	@if [ ! -f $(TFTP_HPA_DIR)/$(TFTP_HPA_BINARY) -o $(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY) \
-	-ot $(TFTP_HPA_DIR)/$(TFTP_HPA_BINARY) ]; then \
-	    set -x; \
-	    rm -f $(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY); \
-	    cp -a $(TFTP_HPA_DIR)/$(TFTP_HPA_BINARY) $(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY); fi
-	@if [ ! -f $(TARGET_DIR)/etc/init.d/S80tftpd-hpa ]; then \
-		$(INSTALL) -m 0755 package/tftpd/S80tftpd-hpa $(TARGET_DIR)/etc/init.d; \
-	fi
-
-tftpd: $(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY)
-
-tftpd-clean:
-	rm -f $(TARGET_DIR)/etc/init.d/S80tftpd-hpa
-	rm -f $(TARGET_DIR)/usr/sbin/in.tftpd
-	-$(MAKE) -C $(TFTP_HPA_DIR) clean
-
-tftpd-dirclean:
-	rm -rf $(TFTP_HPA_DIR)
-
-#############################################################
-#
-# Toplevel Makefile options
-#
-#############################################################
-ifeq ($(BR2_PACKAGE_TFTPD),y)
-TARGETS+=tftpd
-endif
+$(eval $(call AUTOTARGETS,package,tftpd))
\ No newline at end of file
Signature · 1 line
1.7.0.4
#3 lore raw

PATCH 3/4 setserial: convert to autotargets and fix bug 2269

In reply to Thomas Petazzoni
---
 .../setserial-2.17-build-system-fix.patch          |   28 ++++++++++++++++++++
 package/setserial/setserial.mk                     |   16 ++++++-----
 2 files changed, 37 insertions(+), 7 deletions(-)
 create mode 100644 package/setserial/setserial-2.17-build-system-fix.patch
package/setserial/setserial-2.17-build-system-fix.patch new file +28 -0
new file mode 100644
index 0000000..598217e
@@ -0,0 +1,28 @@
+Install the setserial program in /usr/bin instead of /bin, and make
+sure that the directories (especially the manpages directory) are
+created before installing files to them. This is similar to what
+automake does.
+
+Signed-off-by: Thomas Petazzoni <[email protected]>
+---
+ Makefile.in |    6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+Index: setserial-2.17/Makefile.in
+===================================================================
+--- setserial-2.17.orig/Makefile.in
++++ setserial-2.17/Makefile.in
+@@ -26,9 +26,11 @@
+ 	nroff -man setserial.8 > setserial.cat
+ 
+ install: setserial setserial.8
+-	$(INSTALL_PROGRAM) setserial $(DESTDIR)/bin
++	mkdir -p $(DESTDIR)/usr/bin
++	$(INSTALL_PROGRAM) setserial $(DESTDIR)/usr/bin
+ 	$(STRIP) $(DESTDIR)/bin/setserial
+-	$(INSTALL_DATA) setserial.8 $(DESTDIR)/usr/man/man8
++	mkdir -p $(DESTDIR)/usr/share/man/man8
++	$(INSTALL_DATA) setserial.8 $(DESTDIR)/usr/share/man/man8
+ 
+ clean:
+ 	$(RM) setserial setserial.o setserial.cat *~
package/setserial/setserial.mk +9 -7
index 1c222a2..0b67346 100644
@@ -3,16 +3,18 @@
 # Setserial
 #
 #############################################################
-SETSERIAL_VERSION:=2.17
-SETSERIAL_PATCH_VERSION:=.orig
-SETSERIAL_PATCH_FILE:=setserial_2.17-45.diff.gz
-SETSERIAL_SOURCE:=setserial_$(SETSERIAL_VERSION)$(SETSERIAL_PATCH_VERSION).tar.gz
-SETSERIAL_SITE:=$(BR2_DEBIAN_MIRROR)/debian/pool/main/s/setserial/
-SETSERIAL_INSTALL_TARGET_OPT=DESTDIR=$(TARGET_DIR) install
+SETSERIAL_VERSION            = 2.17
+SETSERIAL_PATCH              = setserial_2.17-45.2.diff.gz
+SETSERIAL_SOURCE             = setserial_$(SETSERIAL_VERSION).orig.tar.gz
+SETSERIAL_SITE               = $(BR2_DEBIAN_MIRROR)/debian/pool/main/s/setserial/
+SETSERIAL_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install
 
 define SETSERIAL_APPLY_DEBIAN_PATCHES
+	# Touching gorhack.h is needed for the Debian patch 18 to work
 	if [ -d $(@D)/debian/patches ]; then \
-		toolchain/patch-kernel.sh $(@D) $(@D)/debian/patches \*.patch; \
+		touch $(@D)/gorhack.h; \
+		rm $(@D)/debian/patches/01_makefile.dpatch; \
+		toolchain/patch-kernel.sh $(@D) $(@D)/debian/patches *.dpatch; \
 	fi
 endef
 
Signature · 1 line
1.7.0.4
#4 lore raw

PATCH 3/4 setserial: convert to autotargets and fix bug 2269

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> +Index: setserial-2.17/Makefile.in
Thomas> +=================================================================== Thomas> +--- setserial-2.17.orig/Makefile.in
Thomas> ++++ setserial-2.17/Makefile.in
Thomas> +@@ -26,9 +26,11 @@
Thomas> + nroff -man setserial.8 > setserial.cat
Thomas> +
Thomas> + install: setserial setserial.8
Thomas> +- $(INSTALL_PROGRAM) setserial $(DESTDIR)/bin
Thomas> ++ mkdir -p $(DESTDIR)/usr/bin
Thomas> ++ $(INSTALL_PROGRAM) setserial $(DESTDIR)/usr/bin
Thomas> + $(STRIP) $(DESTDIR)/bin/setserial

That strip should go.

You're also not renaming setserial-tiocghayesesp-build-fix.patch, so we're back with 5a2844c748.

Other than that it looks good.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 3/4 setserial: convert to autotargets and fix bug 2269

Quoted 16 lines · On Tue, 27 Jul 2010 00:50:58 +0200 Peter Korsgaard <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Thomas" == Thomas Petazzoni
<[email protected]> writes:

Thomas> +Index: setserial-2.17/Makefile.in
Thomas> +=================================================================== Thomas> +--- setserial-2.17.orig/Makefile.in
Thomas> ++++ setserial-2.17/Makefile.in
Thomas> +@@ -26,9 +26,11 @@
Thomas> + nroff -man setserial.8 > setserial.cat
Thomas> +
Thomas> + install: setserial setserial.8
Thomas> +- $(INSTALL_PROGRAM) setserial $(DESTDIR)/bin
Thomas> ++ mkdir -p $(DESTDIR)/usr/bin
Thomas> ++ $(INSTALL_PROGRAM) setserial $(DESTDIR)/usr/bin
Thomas> + $(STRIP) $(DESTDIR)/bin/setserial

Quoted 1 line

That strip should go.

Well, it was here in the setserial Makefile. While I agree that we shouldn't explicitly add strip commands in Buildroot .mk files, I don't think it's worth the effort removing those strip commands from within the package.

Quoted 2 lines

You're also not renaming setserial-tiocghayesesp-build-fix.patch, so we're back with 5a2844c748.

Right, sorry.

Thanks for having fixed those issues.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#6 lore raw

PATCH 3/4 setserial: convert to autotargets and fix bug 2269

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Thomas> + install: setserial setserial.8
Thomas> +- $(INSTALL_PROGRAM) setserial $(DESTDIR)/bin
Thomas> ++ mkdir -p $(DESTDIR)/usr/bin
Thomas> ++ $(INSTALL_PROGRAM) setserial $(DESTDIR)/usr/bin
Thomas> + $(STRIP) $(DESTDIR)/bin/setserial

Quoted 2 lines
Quoted 2 lines

That strip should go.

Thomas> Well, it was here in the setserial Makefile. While I agree that we Thomas> shouldn't explicitly add strip commands in Buildroot .mk files, I don't Thomas> think it's worth the effort removing those strip commands from within Thomas> the package.

No, but it was stripping bin/setserial, not usr/bin/setserial.

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH 4/4 Deprecate pcmcia and microwin packages

In reply to Thomas Petazzoni

It isn't worth the effort to convert these packages to the new package infrastructure since they are deprecated.

---
 package/microwin/Config.in |    2 ++
 package/pcmcia/Config.in   |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)
package/microwin/Config.in +2 -0
index 5445f6a..3dd1e37 100644
@@ -1,5 +1,7 @@
 config BR2_PACKAGE_MICROWIN
 	bool "microwin"
+	# Old, unmaintained graphic stack
+	depends on BR2_DEPRECATED
 	help
 	 Microwindows Graphical User Interface for small and
 	 embedded enviroments.
package/pcmcia/Config.in +2 -0
index fe26fa3..de1e33b 100644
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_PCMCIA
 	bool "pcmcia"
 	depends on BR2_PACKAGE_LINUX
+	# The website says it's deprecated after 2.4.x kernels
+	depends on BR2_DEPRECATED
 	help
 	  PCMCIA tools for Linux.
 
Signature · 1 line
1.7.0.4
#8 lore raw
In reply to Thomas Petazzoni
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> The following changes since commit 3435c1afb58307240be8e4607b5bb7d239fac4e9:
Thomas> Peter Korsgaard (1):
Thomas> kconfig: implement KCONFIG_PROBABILITY for rand{,package}config

Thomas> are available in the git repository at:

Thomas> git://git.busybox.net/~tpetazzoni/git/buildroot genautotargets-conversion

Thomas> Thomas Petazzoni (4):

 Thomas>       ltrace: convert to gentargets and bump to 0.5.3
 Thomas>       tftpd: convert to autotargets
 Thomas>       setserial: convert to autotargets and fix bug 2269
 Thomas>       Deprecate pcmcia and microwin packages

Committed with minor modifications, thanks!

Signature · 1 line
Bye, Peter Korsgaard