Skip to contentSkip to conversation

Fix transmit LED on Acer Aspire One

PATCH In review Peter Chubb 3 participants 3 messages Feb 18, 2009 – Feb 23, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix transmit LED on Acer Aspire One

I've seen a whole heap of fixes for the Aspire One's wireless LED on the web, but nothing in the kernel yet.

Here's my take on it. My only worry is other machines with the same card.

---

---
 drivers/net/wireless/ath5k/base.c |    6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/wireless/ath5k/base.c +6 -0
Index: linux-2.6/drivers/net/wireless/ath5k/base.c
===================================================================
@@ -2619,6 +2619,12 @@
 		sc->led_pin = 1;
 		sc->led_on = 1;  /* active high */
 	}
+	/* Enable softled on Acer Aspire One */
+	else if (pdev->subsystem_vendor == 0x105b && pdev->subsystem_device == 0xe008) {
+		__set_bit(ATH_STAT_LEDSOFT, sc->status);
+		sc->led_pin = 3;
+		sc->led_on = 0;
+	}
 	if (!test_bit(ATH_STAT_LEDSOFT, sc->status))
 		goto out;
 

--
Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au
http://www.ertos.nicta.com.au ERTOS within National ICT Australia
A university is a non-profit organisation only in the sense that it spends everything it gets ... Luca Turin.

#1 lore raw
Quoted 19 lines · Peter Chubb

I've seen a whole heap of fixes for the Aspire One's wireless LED on the web, but nothing in the kernel yet.

Here's my take on it. My only worry is other machines with the same card.

---

---
 drivers/net/wireless/ath5k/base.c |    6 ++++++
 1 file changed, 6 insertions(+)

Index: linux-2.6/drivers/net/wireless/ath5k/base.c
===================================================================

drivers/net/wireless/ath5k/base.c +0 -0
@@ -2619,6 +2619,12 @@
 		sc->led_pin = 1;

drivers/net/wireless/ath5k/base.c line 2629

Quoted 10 lines
drivers/net/wireless/ath5k/base.c +6 -0
 		sc->led_on = 1;  /* active high */
 	}
+	/* Enable softled on Acer Aspire One */
+	else if (pdev->subsystem_vendor == 0x105b && pdev->subsystem_device == 0xe008) {
+		__set_bit(ATH_STAT_LEDSOFT, sc->status);
+		sc->led_pin = 3;
+		sc->led_on = 0;
+	}
 	if (!test_bit(ATH_STAT_LEDSOFT, sc->status))
 		goto out;

Any comment on this from the ath5k guys? That 0x105b subvendor ID would seem to correspond to "Foxconn International, Inc.", which doesn't sound much like "Acer"...

John

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.
#2 lore raw
Quoted 10 lines · John W. Linville

drivers/net/wireless/ath5k/base.c line 2629

Quoted 8 lines · Peter Chubb
drivers/net/wireless/ath5k/base.c +6 -0
+     /* Enable softled on Acer Aspire One */
+     else if (pdev->subsystem_vendor == 0x105b && pdev->subsystem_device == 0xe008) {
+             __set_bit(ATH_STAT_LEDSOFT, sc->status);
+             sc->led_pin = 3;
+             sc->led_on = 0;
+     }
      if (!test_bit(ATH_STAT_LEDSOFT, sc->status))
              goto out;
Quoted 3 lines

Any comment on this from the ath5k guys? That 0x105b subvendor ID would seem to correspond to "Foxconn International, Inc.", which doesn't sound much like "Acer"...

It's already in wireless-testing with similar values.

Not quite apropos to this patch, someone with the ambit chipset said the values didn't match up with his laptop, so we do need to add a subsystem_device test I think, but it should have a #define in pci.h. In any case there's usually no harm in enabling the wrong gpio pin, unless rfkill happens to sit there.

Signature · 1 line
Bob Copeland %% www.bobcopeland.com