ALSA: hda/realtek: fix mute/micmute LEDs don't work for HP 200 G2i
PATCH 1/1 ALSA: hda/realtek: fix mute/micmute LEDs don't work for HP 200 G2i
HP 200 G2i needs quirk to make mic-mute/audio-mute working.
Signed-off-by Dirk Su <[email protected]>
--- sound/hda/codecs/realtek/alc269.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
sound/hda/codecs/realtek/alc269.c +13 -0
@@ -1656,6 +1656,13 @@ static void alc236_fixup_hp_mute_led_micmute_vref(struct hda_codec *codec,alc236_fixup_hp_micmute_led_vref (codec, fix, action); } +static void alc236_fixup_hp_mute_led_micmute_gpio (struct hda_codec *codec, +const struct hda_fixup *fix,int action) +{ +alc236_fixup_hp_mute_led_coefbit2 (codec, fix, action); +alc236_fixup_hp_gpio_led (codec, fix, action); +} +static inline void alc298_samsung_write_coef_pack (struct hda_codec *codec,const unsigned short coefs[2 ]) {
@@ -3790,6 +3797,7 @@ enum {ALC245_FIXUP_HP_TAS2781_SPI_MUTE_LED ,ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED ,ALC288_FIXUP_SURFACE_SWAP_DACS , + ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO, };/* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -5323,6 +5331,10 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc236_fixup_hp_mute_led_micmute_vref, }, + [ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc236_fixup_hp_mute_led_micmute_gpio, + }, [ALC236_FIXUP_LENOVO_INV_DMIC] = { .type = HDA_FIXUP_FUNC, .v.func = alc_fixup_inv_dmic,
@@ -6760,6 +6772,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x103c ,0x8e60 ,"HP Trekker " ,ALC287_FIXUP_CS35L41_I2C_2 ),SND_PCI_QUIRK (0x103c ,0x8e61 ,"HP Trekker " ,ALC287_FIXUP_CS35L41_I2C_2 ),SND_PCI_QUIRK (0x103c ,0x8e62 ,"HP Trekker " ,ALC287_FIXUP_CS35L41_I2C_2 ), +SND_PCI_QUIRK (0x103c ,0x8ec1 ,"HP 200 G2i" ,ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO ),SND_PCI_QUIRK (0x103c ,0x8ed5 ,"HP EliteBook 8 Flip G2i 13" ,ALC245_FIXUP_HP_TAS2781_SPI_MUTE_LED ),SND_PCI_QUIRK (0x103c ,0x8ed6 ,"HP EliteBook 8 G2i 13" ,ALC245_FIXUP_HP_TAS2781_SPI_MUTE_LED ), SND_PCI_QUIRK(0x103c, 0x8ed7, "HP EliteBook 8 G2i 14", ALC245_FIXUP_HP_TAS2781_SPI_MUTE_LED),
Signature · 1 line
2.43.0
Quoted 4 lines · Dirk Su
HP 200 G2i needs quirk to make mic-mute/audio-mute working.
Signed-off-by Dirk Su <[email protected]>
This could be with a chained fixup instead, e.g.
[ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc236_fixup_hp_mute_led_coefbit2,
.chained = true,
.chain_id = ALC236_FIXUP_HP_GPIO_LED,
},Care to resubmit in this style?
thanks,
Takashi
Quoted 52 lines
--- sound/hda/codecs/realtek/alc269.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)sound/hda/codecs/realtek/alc269.c +13
-0@@ -1656,6 +1656,13 @@ static void alc236_fixup_hp_mute_led_micmute_vref(struct hda_codec *codec,alc236_fixup_hp_micmute_led_vref (codec, fix, action); } +static void alc236_fixup_hp_mute_led_micmute_gpio (struct hda_codec *codec, +const struct hda_fixup *fix,int action) +{ +alc236_fixup_hp_mute_led_coefbit2 (codec, fix, action); +alc236_fixup_hp_gpio_led (codec, fix, action); +} +static inline void alc298_samsung_write_coef_pack (struct hda_codec *codec,const unsigned short coefs[2 ]) {@@ -3790,6 +3797,7 @@ enum {ALC245_FIXUP_HP_TAS2781_SPI_MUTE_LED ,ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED ,ALC288_FIXUP_SURFACE_SWAP_DACS , + ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO, };/* A special fixup for Lenovo C940 and Yoga Duet 7; @@ -5323,6 +5331,10 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc236_fixup_hp_mute_led_micmute_vref, }, + [ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc236_fixup_hp_mute_led_micmute_gpio, + }, [ALC236_FIXUP_LENOVO_INV_DMIC] = { .type = HDA_FIXUP_FUNC, .v.func = alc_fixup_inv_dmic,@@ -6760,6 +6772,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x103c ,0x8e60 ,"HP Trekker " ,ALC287_FIXUP_CS35L41_I2C_2 ),SND_PCI_QUIRK (0x103c ,0x8e61 ,"HP Trekker " ,ALC287_FIXUP_CS35L41_I2C_2 ),SND_PCI_QUIRK (0x103c ,0x8e62 ,"HP Trekker " ,ALC287_FIXUP_CS35L41_I2C_2 ), +SND_PCI_QUIRK (0x103c ,0x8ec1 ,"HP 200 G2i" ,ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO ),SND_PCI_QUIRK (0x103c ,0x8ed5 ,"HP EliteBook 8 Flip G2i 13" ,ALC245_FIXUP_HP_TAS2781_SPI_MUTE_LED ),SND_PCI_QUIRK (0x103c ,0x8ed6 ,"HP EliteBook 8 G2i 13" ,ALC245_FIXUP_HP_TAS2781_SPI_MUTE_LED ), SND_PCI_QUIRK(0x103c, 0x8ed7, "HP EliteBook 8 G2i 14", ALC245_FIXUP_HP_TAS2781_SPI_MUTE_LED),Signature · 1 line
2.43.0